From: Andre Przywara <andre.przywara@arm.com>
To: qianfanguijin@163.com
Cc: linux-sunxi@lists.linux.dev, mripard@kernel.org, wens@csie.org,
jernej.skrabec@gmail.com
Subject: Re: [PATCH 2/3] ARM: dts: sun8i: r40: Add usb_otg device node
Date: Thu, 1 Jul 2021 15:29:35 +0100 [thread overview]
Message-ID: <20210701152935.19dc66a7@slackpad.fritz.box> (raw)
In-Reply-To: <20210701015009.13985-2-qianfanguijin@163.com>
On Thu, 1 Jul 2021 09:50:08 +0800
qianfanguijin@163.com wrote:
Hi,
> From: qianfan Zhao <qianfanguijin@163.com>
>
> R40's usb otg is compatibled with H3.
>
> Signed-off-by: qianfan Zhao <qianfanguijin@163.com>
> ---
> arch/arm/boot/dts/sun8i-r40.dtsi | 14 ++++++++++++++
> 1 file changed, 14 insertions(+)
>
> diff --git a/arch/arm/boot/dts/sun8i-r40.dtsi b/arch/arm/boot/dts/sun8i-r40.dtsi
> index d5ad3b9efd12..3edc849d39be 100644
> --- a/arch/arm/boot/dts/sun8i-r40.dtsi
> +++ b/arch/arm/boot/dts/sun8i-r40.dtsi
> @@ -363,6 +363,20 @@
> #size-cells = <0>;
> };
>
> + usb_otg: usb@1c13000 {
> + compatible = "allwinner,sun8i-h3-musb";
Please use a specific compatible string as well:
compatible = "allwinner,sun8i-r40-musb",
"allwinner,sun8i-h3-musb";
The rest looks alright (base address, IRQ compared to the manual).
Thanks,
Andre
> + reg = <0x01c13000 0x0400>;
> + clocks = <&ccu CLK_BUS_OTG>;
> + resets = <&ccu RST_BUS_OTG>;
> + interrupts = <GIC_SPI 38 IRQ_TYPE_LEVEL_HIGH>;
> + interrupt-names = "mc";
> + phys = <&usbphy 0>;
> + phy-names = "usb";
> + extcon = <&usbphy 0>;
> + dr_mode = "otg";
> + status = "disabled";
> + };
> +
> usbphy: phy@1c13400 {
> compatible = "allwinner,sun8i-r40-usb-phy";
> reg = <0x01c13400 0x14>,
next prev parent reply other threads:[~2021-07-01 14:40 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-01 1:50 [PATCH 1/3] phy-sun4i-usb: Fix sun8i_r40_cfg qianfanguijin
2021-07-01 1:50 ` [PATCH 2/3] ARM: dts: sun8i: r40: Add usb_otg device node qianfanguijin
2021-07-01 14:29 ` Andre Przywara [this message]
2021-07-01 1:50 ` [PATCH 3/3] ARM: dts: sun8i: r40: bananapi-m2-ultra: Enable usb_otg qianfanguijin
2021-07-01 14:37 ` Andre Przywara
2021-07-01 14:47 ` Chen-Yu Tsai
2021-07-02 2:46 ` qianfan
2021-07-02 12:06 ` Maxime Ripard
2021-07-02 12:24 ` Andre Przywara
2021-07-02 12:30 ` Chen-Yu Tsai
2021-07-05 3:50 ` qianfan
2021-07-05 6:20 ` Chen-Yu Tsai
2021-07-05 6:29 ` qianfan
2021-07-05 14:20 ` Chen-Yu Tsai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210701152935.19dc66a7@slackpad.fritz.box \
--to=andre.przywara@arm.com \
--cc=jernej.skrabec@gmail.com \
--cc=linux-sunxi@lists.linux.dev \
--cc=mripard@kernel.org \
--cc=qianfanguijin@163.com \
--cc=wens@csie.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).