archive mirror
 help / color / mirror / Atom feed
From: Mark Brown <>
To: "Jernej Škrabec" <>
Subject: Re: Re: [PATCH 1/2] dt-bindings: sound: sun4i-i2s: add Allwinner R40 I2S compatible
Date: Mon, 13 Sep 2021 16:42:53 +0100	[thread overview]
Message-ID: <> (raw)
In-Reply-To: <22661441.uYPlIyrNLm@kista>

[-- Attachment #1: Type: text/plain, Size: 1199 bytes --]

On Mon, Sep 13, 2021 at 05:33:22PM +0200, Jernej Škrabec wrote:
> Dne ponedeljek, 13. september 2021 ob 13:11:17 CEST je Mark Brown napisal(a):
> > On Sun, Sep 12, 2021 at 09:29:13AM +0200, Jernej Skrabec wrote:

> > Please submit patches using subject lines reflecting the style for the
> > subsystem, this makes it easier for people to identify relevant patches.
> > Look at what existing commits in the area you're changing are doing and
> > make sure your subject lines visually resemble what they're doing.
> > There's no need to resubmit to fix this alone.

> I did exactly that. But history is not uniform:


> Most subjects contain "dt-bindings: sound: " at the beginning. I selected 
> variant from latest commit (ce09d1a6800d).

If you look at more than just this one file the numbers look rather
different there, I see I will have to start being super strict with the
sunxi stuff here :( .  Other people messing up is not a good reason to
follow them, nor is the occasional thing that's part of a larger series
being let slide without a maintainer fixup.

Nothing in this patch series had anything about ASoC in it meaning I
very nearly deleted this unread.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

  reply	other threads:[~2021-09-13 15:43 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-09-12  7:29 [PATCH 0/2] ARM: dts: sun8i: r40: Add I2S nodes Jernej Skrabec
2021-09-12  7:29 ` [PATCH 1/2] dt-bindings: sound: sun4i-i2s: add Allwinner R40 I2S compatible Jernej Skrabec
2021-09-13 11:11   ` Mark Brown
2021-09-13 15:33     ` Jernej Škrabec
2021-09-13 15:42       ` Mark Brown [this message]
2021-09-12  7:29 ` [PATCH 2/2] ARM: dts: sun8i: r40: Add I2S nodes Jernej Skrabec
2021-09-13  7:16 ` [PATCH 0/2] " Maxime Ripard

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \ \ \ \ \ \ \ \ \ \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).