From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from new4-smtp.messagingengine.com (new4-smtp.messagingengine.com [66.111.4.230]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CA2EF1113 for ; Fri, 29 Jul 2022 16:37:23 +0000 (UTC) Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailnew.nyi.internal (Postfix) with ESMTP id ED3FF580998; Fri, 29 Jul 2022 12:37:22 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute4.internal (MEProxy); Fri, 29 Jul 2022 12:37:22 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cerno.tech; h=cc :cc:content-transfer-encoding:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to; s=fm2; t=1659112642; x= 1659119842; bh=z4dxjRqvnKjKZwixc6luRyBYXpbYzQTl9ZlCu9EH/IU=; b=Q qP2/0/C+YlMyNU+sk1Kdeqo8bSQ3lwkno0QIHBxNQSNZqNIFKHzXaPKP0itf1aOY 3CaBxbDIE+F9pk1CipIetvq0DmMiqzryDtJDyFJSPd7rMuYxSyqfmN5tZKLai+Xg OlkjZ+0mwPPvkoD69fS/IfG5QxNeK3HtKWWjfZ2/hQjvaI5p5tgE9lV20uJCorvg R8ikZVCpbRzxRUM/JIoU7GGxsWy+UXMOt7tt35meCMWI4LgRBNgHCVOoMZjsfi6w GICVRAKcuPVqHePSvUohIfxsCye9MJmCjzh2c5r2K5eoZkkr5XxUlT3R5GfI3MXo zQdaw3D7wInlLeM2mRVEQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:date:date:feedback-id:feedback-id:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm3; t=1659112642; x= 1659119842; bh=z4dxjRqvnKjKZwixc6luRyBYXpbYzQTl9ZlCu9EH/IU=; b=W 7oJFQyOa/ClnJErQ7+wP0S9yo2XmGYZdadbj0KKqNKw0fL34M3v9inLPmmJe+L5D 6PqOM9oqJ5dHASzIgQjGwvng/K/G0J9vxY/HuExgrmSa38DQYj7iiKEHEBFOUiOK xRNRXUIcv1jYF+KmOP6VrX21CBhXQlfFtvgO7vbg/JoXLrvo45boXwhM6oyWN1Zt uVO23e3nOM25+kCAhBAEqdhcIg6jJ4y4lYITCaW7LsJJnsoC60LUesJEWsdVPHq/ vQpY7qZQcuHujD6HZBoQO0Dh8vKCaX7beBBZ1aObKLZhjf9HmMMRPTi/NWzX08OD tONJUkWlPSEeBtxSNLgBg== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvfedrvddujedguddtgecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd enucfjughrpefhvfevufffkffojghfgggtoffgsehtkeertdertdejnecuhfhrohhmpefo rgigihhmvgcutfhiphgrrhguuceomhgrgihimhgvsegtvghrnhhordhtvggthheqnecugg ftrfgrthhtvghrnhepgfffgfetffduudelhfevieffffduleevgfegkeeutefgffejheel leekjeefhfejnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrh homhepmhgrgihimhgvsegtvghrnhhordhtvggthh X-ME-Proxy: Feedback-ID: i8771445c:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Fri, 29 Jul 2022 12:37:21 -0400 (EDT) From: Maxime Ripard To: Jernej Skrabec , Martin Blumenstingl , Chen-Yu Tsai , Philipp Zabel , Jerome Brunet , Samuel Holland , Thomas Zimmermann , Daniel Vetter , Emma Anholt , David Airlie , Maarten Lankhorst , =?UTF-8?q?Noralf=20Tr=C3=B8nnes?= , Kevin Hilman , Neil Armstrong , Maxime Ripard Cc: Maxime Ripard , linux-sunxi@lists.linux.dev, linux-kernel@vger.kernel.org, Phil Elwell , Mateusz Kwiatkowski , linux-arm-kernel@lists.infradead.org, Geert Uytterhoeven , Dave Stevenson , linux-amlogic@lists.infradead.org, dri-devel@lists.freedesktop.org, Dom Cobley Subject: [PATCH v1 31/35] drm/sun4i: tv: Add missing reset assertion Date: Fri, 29 Jul 2022 18:35:14 +0200 Message-Id: <20220728-rpi-analog-tv-properties-v1-31-3d53ae722097@cerno.tech> X-Mailer: git-send-email 2.37.1 In-Reply-To: <20220728-rpi-analog-tv-properties-v1-0-3d53ae722097@cerno.tech> References: <20220728-rpi-analog-tv-properties-v1-0-3d53ae722097@cerno.tech> Precedence: bulk X-Mailing-List: linux-sunxi@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" X-Mailer: b4 0.10.0-dev-49460 X-Developer-Signature: v=1; a=openpgp-sha256; l=761; i=maxime@cerno.tech; h=from:subject:message-id; bh=rG0fPy6TTfoZ/9j5IF0mB2xjJYA3taP2O8nA2ubJBbY=; b=owGbwMvMwCHc4XzqmfnC7acZT6slMSQ94VGKOrZow3PTjO3hm1/mWvau6GpTXVbIW3fdqLTs0CLl JWHiHaUsDMIcDLJiiizXBd/a8YVFuUXwfNgMM4eVCWQIAxenAEwkWoSR4ea5cmWVmhw+/uYopR1bPi RtXqyVws+38MUqU7auiwLhZxgZ7v+QO92VcuqCw5p7uzYv/MAerqZwYfKuqRJXH17O4Chv3Q4A X-Developer-Key: i=maxime@cerno.tech; a=openpgp; fpr=BE5675C37E818C8B5764241C254BCFC56BF6CE8D Content-Transfer-Encoding: 8bit The reset line is deasserted at bind, and asserted if we ever encounter an error there. However, it's never deasserted in unbind which will lead to a resource unbalance. Signed-off-by: Maxime Ripard diff --git a/drivers/gpu/drm/sun4i/sun4i_tv.c b/drivers/gpu/drm/sun4i/sun4i_tv.c index ad6a3739bfa9..74ff5ad6a8b9 100644 --- a/drivers/gpu/drm/sun4i/sun4i_tv.c +++ b/drivers/gpu/drm/sun4i/sun4i_tv.c @@ -605,6 +605,7 @@ static void sun4i_tv_unbind(struct device *dev, struct device *master, drm_connector_cleanup(&tv->connector); drm_encoder_cleanup(&tv->encoder); clk_disable_unprepare(tv->clk); + reset_control_assert(tv->reset); } static const struct component_ops sun4i_tv_ops = { -- b4 0.10.0-dev-49460