From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [213.167.242.64]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1205516432 for ; Thu, 8 Jun 2023 16:26:55 +0000 (UTC) Received: from pendragon.ideasonboard.com (om126033089000.35.openmobile.ne.jp [126.33.89.0]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id ABD6FF7C; Thu, 8 Jun 2023 18:26:17 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1686241579; bh=9rruNaQgl/oQBE2oLPlmpO6slCgdtIRvea2nyNzPSZs=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=LLXEiASpvCS+K6TnETZR+gAVntREVUQlWqSFAEd8t5iunYhMtLxUDYZ7ZD4AjpFdD n9hRLmIFvh9Nfrccon6V6aV4cRl+tSQCd+S/RISk+hv5rWicoVYu0qcAItyObwwlvE dO+yQN68ltwo5R0MgrqYlmfk5q+3Kvczr50XtQSw= Date: Thu, 8 Jun 2023 19:26:42 +0300 From: Laurent Pinchart To: Doug Anderson Cc: Uwe =?utf-8?Q?Kleine-K=C3=B6nig?= , Liviu Dudau , Mihail Atanassov , Brian Starkey , David Airlie , Daniel Vetter , Russell King , Joel Stanley , Sam Ravnborg , Boris Brezillon , Nicolas Ferre , Alexandre Belloni , Claudiu Beznea , Andrzej Hajda , Neil Armstrong , Robert Foss , Tomi Valkeinen , Rahul T R , Jayshri Pawar , Liu Ying , Shawn Guo , Sascha Hauer , Minghao Chi , Mark Brown , Kuninori Morimoto , Lucas Stach , Inki Dae , Seung-Woo Kim , Kyungmin Park , Krzysztof Kozlowski , Jingoo Han , Stefan Agner , Alison Wang , Xinliang Liu , Tian Tao , Ville =?utf-8?B?U3lyasOkbMOk?= , Jani Nikula , Thomas Zimmermann , Danilo Krummrich , Javier Martinez Canillas , Laurentiu Palcu , Philipp Zabel , Paul Cercueil , Anitha Chrisanthus , Qiang Yu , Paul Kocialkowski , Linus Walleij , Chun-Kuang Hu , Matthias Brugger , Kevin Hilman , Rob Clark , Abhinav Kumar , Dmitry Baryshkov , Akhil P Oommen , Ricardo Ribalda , Konrad Dybcio , Johan Hovold , Stephen Boyd , Marijn Suijten , Liu Shixin , Miaoqian Lin , Kuogee Hsieh , Bjorn Andersson , Marek Vasut , Ben Skeggs , Karol Herbst , Lyude Paul , Tomi Valkeinen , Guo Zhengkui , Yuan Can , Arnd Bergmann , Liang He , Thierry Reding , Rob Herring , Kieran Bingham , Sandy Huang , Heiko =?utf-8?Q?St=C3=BCbner?= , Orson Zhai , Baolin Wang , Chunyan Zhang , Deepak R Varma , Alex Deucher , Alain Volmat , Yannick Fertre , Raphael Gallais-Pou , Philippe Cornu , Maxime Coquelin , Alexandre Torgue , Maxime Ripard , Chen-Yu Tsai , Jernej Skrabec , Samuel Holland , Jonathan Hunter , Maxime Ripard , =?utf-8?B?TWHDrXJh?= Canal , Noralf =?utf-8?Q?Tr=C3=B8nnes?= , Jyri Sarha , Alexey Brodkin , Emma Anholt , Melissa Wen , Hyun Kwon , Michal Simek , linux-aspeed@lists.ozlabs.org, nouveau@lists.freedesktop.org, dri-devel@lists.freedesktop.org, John Stultz , Alim Akhtar , Fabio Estevam , Sumit Semwal , Jerome Brunet , linux-samsung-soc@vger.kernel.org, lima@lists.freedesktop.org, Steven Price , linux-rockchip@lists.infradead.org, Xinwei Kong , Mali DP Maintainers , NXP Linux Team , Russell King , linux-sunxi@lists.linux.dev, Jonas Karlman , Martin Blumenstingl , linux-arm-msm@vger.kernel.org, etnaviv@lists.freedesktop.org, Christian Gmeiner , linux-mediatek@lists.infradead.org, linux-tegra@vger.kernel.org, linux-amlogic@lists.infradead.org, Sean Paul , linux-arm-kernel@lists.infradead.org, AngeloGioacchino Del Regno , Andrew Jeffery , linux-stm32@st-md-mailman.stormreply.com, linux-mips@vger.kernel.org, linux-renesas-soc@vger.kernel.org, kernel@pengutronix.de, Yongqin Liu , freedreno@lists.freedesktop.org Subject: Re: [PATCH 00/53] drm: Convert to platform remove callback returning void Message-ID: <20230608162642.GA23400@pendragon.ideasonboard.com> References: <20230507162616.1368908-1-u.kleine-koenig@pengutronix.de> <20230601154002.uv2wfatpb7b45duz@pengutronix.de> Precedence: bulk X-Mailing-List: linux-sunxi@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: Hi Doug, On Thu, Jun 08, 2023 at 09:08:15AM -0700, Doug Anderson wrote: > On Thu, Jun 1, 2023 at 8:40 AM Uwe Kleine-König wrote: > > On Sun, May 07, 2023 at 06:25:23PM +0200, Uwe Kleine-König wrote: > > > this patch series adapts the platform drivers below drivers/gpu/drm > > > to use the .remove_new() callback. Compared to the traditional .remove() > > > callback .remove_new() returns no value. This is a good thing because > > > the driver core doesn't (and cannot) cope for errors during remove. The > > > only effect of a non-zero return value in .remove() is that the driver > > > core emits a warning. The device is removed anyhow and an early return > > > from .remove() usually yields a resource leak. > > > > > > By changing the remove callback to return void driver authors cannot > > > reasonably (but wrongly) assume any more that there happens some kind of > > > cleanup later. > > > > I wonder if someone would volunteer to add the whole series to > > drm-misc-next?! > > It looks as if Neil applied quite a few of them already, so I looked > at what was left... > > I'm a little hesitant to just apply the whole kit-and-caboodle to > drm-misc-next since there are specific DRM trees for a bunch of them > and it would be better if they landed there. ...so I went through all > the patches that still applied to drm-misc-next, then used > 'scripts/get_maintainer.pl --scm' to check if they were maintained > through drm-misc. That still left quite a few patches. I've applied > those ones and pushed to drm-misc-next: > > 71722685cd17 drm/xlnx/zynqmp_dpsub: Convert to platform remove > callback returning void > 1ed54a19f3b3 drm/vc4: Convert to platform remove callback returning void > b957812839f8 drm/v3d: Convert to platform remove callback returning void > e2fd3192e267 drm/tve200: Convert to platform remove callback returning void > 84e6da7ad553 drm/tiny: Convert to platform remove callback returning void > 34cdd1f691ad drm/tidss: Convert to platform remove callback returning void > d665e3c9d37a drm/sun4i: Convert to platform remove callback returning void > 0c259ab19146 drm/stm: Convert to platform remove callback returning void > 9a865e45884a drm/sti: Convert to platform remove callback returning void > 3c855610840e drm/rockchip: Convert to platform remove callback returning void > e41977a83b71 drm/panfrost: Convert to platform remove callback returning void > cef3776d0b5a drm/panel: Convert to platform remove callback returning void > bd296a594e87 drm/mxsfb: Convert to platform remove callback returning void > 38ca2d93d323 drm/meson: Convert to platform remove callback returning void > fd1457d84bae drm/mcde: Convert to platform remove callback returning void > 41a56a18615c drm/logicvc: Convert to platform remove callback returning void > 980ec6444372 drm/lima: Convert to platform remove callback returning void > 82a2c0cc1a22 drm/hisilicon: Convert to platform remove callback returning void > c3b28b29ac0a drm/fsl-dcu: Convert to platform remove callback returning void > a118fc6e71f9 drm/atmel-hlcdc: Convert to platform remove callback returning void > 9a32dd324c46 drm/aspeed: Convert to platform remove callback returning void > 2c7d291c498c drm/arm/malidp: Convert to platform remove callback returning void > a920028df679 drm/arm/hdlcd: Convert to platform remove callback returning void > 1bf3d76a7d15 drm/komeda: Convert to platform remove callback returning void > > The following ones appeared to apply to the top of drm-misc-next, but > I didn't apply them since get_maintainer didn't say they were part of > drm-misc-next: > > drm/tiny: Convert to platform remove callback returning void > drm/tilcdc: Convert to platform remove callback returning void > drm/sprd: Convert to platform remove callback returning void > drm/shmobile: Convert to platform remove callback returning void > drm/rcar-du: Convert to platform remove callback returning void If you don't mind, could you take the rcar-du patch through drm-misc too ? I don't plan to send another pull request for v6.5. > drm/omap: Convert to platform remove callback returning void Tomi, should drm/omap moved to being maintained through drm-misc ? > drm/nouveau: Convert to platform remove callback returning void > drm/mediatek: Convert to platform remove callback returning void > drm/kmb: Convert to platform remove callback returning void > drm/ingenic: Convert to platform remove callback returning void > drm/imx/ipuv3: Convert to platform remove callback returning void > drm/imx/dcss: Convert to platform remove callback returning void > drm/etnaviv: Convert to platform remove callback returning void > drm/armada: Convert to platform remove callback returning void -- Regards, Laurent Pinchart