From: Andre Przywara <andre.przywara@arm.com>
To: fuyao <fuyao1697@cyg.com>
Cc: Lee Jones <lee@kernel.org>, Chen-Yu Tsai <wens@csie.org>,
Jernej Skrabec <jernej.skrabec@gmail.com>,
Samuel Holland <samuel@sholland.org>,
linux-arm-kernel@lists.infradead.org,
linux-sunxi@lists.linux.dev, linux-kernel@vger.kernel.org,
Maxime Ripard <mripard@kernel.org>,
maijianzhang <maijianzhang@allwinnertech.com>
Subject: Re: [PATCH RESEND] iio: adc: sun4i-gpadc-iio: adaptation interrupt number
Date: Wed, 20 Dec 2023 11:54:12 +0000 [thread overview]
Message-ID: <20231220115412.65bbc8c7@donnerap.manchester.arm.com> (raw)
In-Reply-To: <YwdhTlk+9h+9Mrwm@scg>
On Wed, 20 Dec 2023 15:23:17 +0800
fuyao <fuyao1697@cyg.com> wrote:
Hi,
> __platform_get_irq_byname determinies whether the interrupt
> number is 0 and returns EINVAL.
can you please say what this fixes, exactly? Is something not working at
the moment? Can you please provide parts of the error message?
And maybe expand the explanation a bit more? For instance mention that the
identifiers are used as IRQ resource numbers, where 0 is treated specially.
Cheers,
Andre
>
> Signed-off-by: fuyao <fuyao1697@cyg.com>
> Acked-by: Jernej Skrabec <jernej.skrabec@gmail.com>
> ---
> include/linux/mfd/sun4i-gpadc.h | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/include/linux/mfd/sun4i-gpadc.h b/include/linux/mfd/sun4i-gpadc.h
> index ea0ccf33a459..021f820f9d52 100644
> --- a/include/linux/mfd/sun4i-gpadc.h
> +++ b/include/linux/mfd/sun4i-gpadc.h
> @@ -81,8 +81,8 @@
> #define SUN4I_GPADC_TEMP_DATA 0x20
> #define SUN4I_GPADC_DATA 0x24
>
> -#define SUN4I_GPADC_IRQ_FIFO_DATA 0
> -#define SUN4I_GPADC_IRQ_TEMP_DATA 1
> +#define SUN4I_GPADC_IRQ_FIFO_DATA 1
> +#define SUN4I_GPADC_IRQ_TEMP_DATA 2
>
> /* 10s delay before suspending the IP */
> #define SUN4I_GPADC_AUTOSUSPEND_DELAY 10000
next prev parent reply other threads:[~2023-12-20 11:54 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-25 11:47 [PATCH] iio: adc: sun4i-gpadc-iio: adaptation interrupt number fuyao
2022-08-25 20:18 ` Jernej Škrabec
2022-09-08 6:55 ` Lee Jones
2023-12-20 7:15 ` [PATCH RESEND] " fuyao
2023-12-20 7:23 ` fuyao
2023-12-20 11:54 ` Andre Przywara [this message]
2023-12-21 15:25 ` Lee Jones
2023-12-21 15:26 ` Lee Jones
2023-12-22 17:54 ` Jernej Škrabec
2023-12-25 9:54 ` fuyao
2024-01-09 8:55 ` Lee Jones
2023-12-25 9:52 ` fuyao
2023-12-20 7:08 ` fuyao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231220115412.65bbc8c7@donnerap.manchester.arm.com \
--to=andre.przywara@arm.com \
--cc=fuyao1697@cyg.com \
--cc=jernej.skrabec@gmail.com \
--cc=lee@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sunxi@lists.linux.dev \
--cc=maijianzhang@allwinnertech.com \
--cc=mripard@kernel.org \
--cc=samuel@sholland.org \
--cc=wens@csie.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).