From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(No client certificate requested)
	by smtp.subspace.kernel.org (Postfix) with ESMTPS id D8B3958229;
	Thu, 21 Dec 2023 15:25:59 +0000 (UTC)
Authentication-Results: smtp.subspace.kernel.org;
	dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="bp/howPs"
Received: by smtp.kernel.org (Postfix) with ESMTPSA id DE8F8C433C8;
	Thu, 21 Dec 2023 15:25:56 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
	s=k20201202; t=1703172359;
	bh=bOn20U9lRPRlbVYe+5E72j85AFisfz3+P+95H5MAc04=;
	h=Date:From:To:Cc:Subject:References:In-Reply-To:From;
	b=bp/howPs7iub2Al7Z8sBtYS3cyJPnK2yVP+txsU/o6SIivy282qZpAPrDGcOphc72
	 16ak6461Hb3ipSsrOAjaf0XT+43Ehjo2gFPAF2rRaszCPJJt29Pr5e5Lg/0a9SrE/9
	 X51lMzhzuIdG7ju29EbQbyo4l2qE2mvOaCBXk6/qjeTguM3BRhHp4KSIZWPCxNb9lG
	 /fk1XgqbfLz0Scyae+akKN8YM3fjBCxQanDDhMiqXy9QPM0rUKEbQoz0W1/xuNsOsR
	 N0+iIwdY4A640o4oHqjmmAuhPqjCHFFRjXmwmfN74omuD7QecQvUiZILLw5yxCk5qH
	 VKchfyUFwZ8LQ==
Date: Thu, 21 Dec 2023 15:25:53 +0000
From: Lee Jones <lee@kernel.org>
To: Andre Przywara <andre.przywara@arm.com>
Cc: fuyao <fuyao1697@cyg.com>, Chen-Yu Tsai <wens@csie.org>,
	Jernej Skrabec <jernej.skrabec@gmail.com>,
	Samuel Holland <samuel@sholland.org>,
	linux-arm-kernel@lists.infradead.org, linux-sunxi@lists.linux.dev,
	linux-kernel@vger.kernel.org, Maxime Ripard <mripard@kernel.org>,
	maijianzhang <maijianzhang@allwinnertech.com>
Subject: Re: [PATCH RESEND] iio: adc: sun4i-gpadc-iio: adaptation interrupt
 number
Message-ID: <20231221152553.GM10102@google.com>
References: <YxmR5SPPY18O7LaG@google.com>
 <YwdhTlk+9h+9Mrwm@scg>
 <20231220115412.65bbc8c7@donnerap.manchester.arm.com>
Precedence: bulk
X-Mailing-List: linux-sunxi@lists.linux.dev
List-Id: <linux-sunxi.lists.linux.dev>
List-Subscribe: <mailto:linux-sunxi+subscribe@lists.linux.dev>
List-Unsubscribe: <mailto:linux-sunxi+unsubscribe@lists.linux.dev>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <20231220115412.65bbc8c7@donnerap.manchester.arm.com>

On Wed, 20 Dec 2023, Andre Przywara wrote:

> On Wed, 20 Dec 2023 15:23:17 +0800
> fuyao <fuyao1697@cyg.com> wrote:
> 
> Hi,
> 
> > __platform_get_irq_byname determinies whether the interrupt
> > number is 0 and returns EINVAL.
> 
> can you please say what this fixes, exactly? Is something not working at
> the moment? Can you please provide parts of the error message?
> 
> And maybe expand the explanation a bit more? For instance mention that the
> identifiers are used as IRQ resource numbers, where 0 is treated specially.
> 
> Cheers,
> Andre
> 
> > 
> > Signed-off-by: fuyao <fuyao1697@cyg.com>

You have to use your full real name as well.

> > Acked-by: Jernej Skrabec <jernej.skrabec@gmail.com>
> > ---
> >  include/linux/mfd/sun4i-gpadc.h | 4 ++--
> >  1 file changed, 2 insertions(+), 2 deletions(-)
> > 
> > diff --git a/include/linux/mfd/sun4i-gpadc.h b/include/linux/mfd/sun4i-gpadc.h
> > index ea0ccf33a459..021f820f9d52 100644
> > --- a/include/linux/mfd/sun4i-gpadc.h
> > +++ b/include/linux/mfd/sun4i-gpadc.h
> > @@ -81,8 +81,8 @@
> >  #define SUN4I_GPADC_TEMP_DATA				0x20
> >  #define SUN4I_GPADC_DATA				0x24
> >  
> > -#define SUN4I_GPADC_IRQ_FIFO_DATA			0
> > -#define SUN4I_GPADC_IRQ_TEMP_DATA			1
> > +#define SUN4I_GPADC_IRQ_FIFO_DATA			1
> > +#define SUN4I_GPADC_IRQ_TEMP_DATA			2
> >  
> >  /* 10s delay before suspending the IP */
> >  #define SUN4I_GPADC_AUTOSUSPEND_DELAY			10000
> 

-- 
Lee Jones [李琼斯]