From: Maxime Ripard <mripard@kernel.org>
To: "Maarten Lankhorst" <maarten.lankhorst@linux.intel.com>,
"Thomas Zimmermann" <tzimmermann@suse.de>,
"David Airlie" <airlied@gmail.com>,
"Daniel Vetter" <daniel@ffwll.ch>,
"Jonathan Corbet" <corbet@lwn.net>,
"Sandy Huang" <hjc@rock-chips.com>,
"Heiko Stübner" <heiko@sntech.de>, "Chen-Yu Tsai" <wens@csie.org>,
"Jernej Skrabec" <jernej.skrabec@gmail.com>,
"Samuel Holland" <samuel@sholland.org>,
"Andy Yan" <andy.yan@rock-chips.com>
Cc: "Hans Verkuil" <hverkuil@xs4all.nl>,
"Sebastian Wick" <sebastian.wick@redhat.com>,
"Ville Syrjälä" <ville.syrjala@linux.intel.com>,
dri-devel@lists.freedesktop.org,
linux-arm-kernel@lists.infradead.org, linux-doc@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-media@vger.kernel.org,
linux-rockchip@lists.infradead.org, linux-sunxi@lists.linux.dev,
"Maxime Ripard" <mripard@kernel.org>,
"Maíra Canal" <mcanal@igalia.com>
Subject: [PATCH v12 26/28] drm/vc4: tests: Convert to plane creation helper
Date: Tue, 23 Apr 2024 12:45:55 +0200 [thread overview]
Message-ID: <20240423-kms-hdmi-connector-state-v12-26-3338e4c0b189@kernel.org> (raw)
In-Reply-To: <20240423-kms-hdmi-connector-state-v12-0-3338e4c0b189@kernel.org>
Now that we have a plane create helper for kunit mocked drivers, let's
convert to it in vc4.
Reviewed-by: Maíra Canal <mcanal@igalia.com>
Signed-off-by: Maxime Ripard <mripard@kernel.org>
---
drivers/gpu/drm/vc4/tests/vc4_mock_plane.c | 34 +++++++-----------------------
1 file changed, 8 insertions(+), 26 deletions(-)
diff --git a/drivers/gpu/drm/vc4/tests/vc4_mock_plane.c b/drivers/gpu/drm/vc4/tests/vc4_mock_plane.c
index 973f5f929097..14357db82238 100644
--- a/drivers/gpu/drm/vc4/tests/vc4_mock_plane.c
+++ b/drivers/gpu/drm/vc4/tests/vc4_mock_plane.c
@@ -1,43 +1,25 @@
// SPDX-License-Identifier: GPL-2.0
-#include <drm/drm_atomic_state_helper.h>
-#include <drm/drm_fourcc.h>
-#include <drm/drm_modeset_helper_vtables.h>
+#include <drm/drm_kunit_helpers.h>
#include <drm/drm_plane.h>
#include <kunit/test.h>
#include "vc4_mock.h"
-static const struct drm_plane_helper_funcs vc4_dummy_plane_helper_funcs = {
-};
-
-static const struct drm_plane_funcs vc4_dummy_plane_funcs = {
- .atomic_destroy_state = drm_atomic_helper_plane_destroy_state,
- .atomic_duplicate_state = drm_atomic_helper_plane_duplicate_state,
- .reset = drm_atomic_helper_plane_reset,
-};
-
-static const uint32_t vc4_dummy_plane_formats[] = {
- DRM_FORMAT_XRGB8888,
-};
-
struct drm_plane *vc4_dummy_plane(struct kunit *test, struct drm_device *drm,
enum drm_plane_type type)
{
struct drm_plane *plane;
- plane = __drmm_universal_plane_alloc(drm, sizeof(struct drm_plane), 0,
- 0,
- &vc4_dummy_plane_funcs,
- vc4_dummy_plane_formats,
- ARRAY_SIZE(vc4_dummy_plane_formats),
- NULL,
- DRM_PLANE_TYPE_PRIMARY,
- NULL);
- KUNIT_ASSERT_NOT_ERR_OR_NULL(test, plane);
+ KUNIT_ASSERT_EQ(test, type, DRM_PLANE_TYPE_PRIMARY);
- drm_plane_helper_add(plane, &vc4_dummy_plane_helper_funcs);
+ plane = drm_kunit_helper_create_primary_plane(test, drm,
+ NULL,
+ NULL,
+ NULL, 0,
+ NULL);
+ KUNIT_ASSERT_NOT_ERR_OR_NULL(test, plane);
return plane;
}
--
2.44.0
next prev parent reply other threads:[~2024-04-23 10:46 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-23 10:45 [PATCH v12 00/28] drm/connector: Create HDMI Connector infrastructure Maxime Ripard
2024-04-23 10:45 ` [PATCH v12 01/28] drm/connector: Introduce an HDMI connector initialization function Maxime Ripard
2024-04-23 10:45 ` [PATCH v12 02/28] drm/mode_object: Export drm_mode_obj_find_prop_id for tests Maxime Ripard
2024-04-23 10:45 ` [PATCH v12 03/28] drm/tests: connector: Add tests for drmm_connector_hdmi_init Maxime Ripard
2024-04-23 10:45 ` [PATCH v12 04/28] drm/connector: hdmi: Create an HDMI sub-state Maxime Ripard
2024-04-23 10:45 ` [PATCH v12 05/28] drm/connector: hdmi: Add output BPC to the connector state Maxime Ripard
2024-04-23 10:45 ` [PATCH v12 06/28] drm/tests: Add output bpc tests Maxime Ripard
2024-04-23 10:45 ` [PATCH v12 07/28] drm/connector: hdmi: Add support for output format Maxime Ripard
2024-04-23 10:45 ` [PATCH v12 08/28] drm/tests: Add output formats tests Maxime Ripard
2024-04-23 10:45 ` [PATCH v12 09/28] drm/display: hdmi: Add HDMI compute clock helper Maxime Ripard
2024-04-23 10:45 ` [PATCH v12 10/28] drm/tests: Add HDMI TDMS character rate tests Maxime Ripard
2024-04-23 10:45 ` [PATCH v12 11/28] drm/connector: hdmi: Calculate TMDS character rate Maxime Ripard
2024-04-23 10:45 ` [PATCH v12 12/28] drm/tests: Add TDMS character rate connector state tests Maxime Ripard
2024-04-23 10:45 ` [PATCH v12 13/28] drm/connector: hdmi: Add custom hook to filter TMDS character rate Maxime Ripard
2024-04-23 10:45 ` [PATCH v12 14/28] drm/tests: Add HDMI connector rate filter hook tests Maxime Ripard
2024-04-23 10:45 ` [PATCH v12 15/28] drm/connector: hdmi: Compute bpc and format automatically Maxime Ripard
2024-04-23 10:45 ` [PATCH v12 16/28] drm/tests: Add HDMI connector bpc and format tests Maxime Ripard
2024-04-23 10:45 ` [PATCH v12 17/28] drm/connector: hdmi: Add Broadcast RGB property Maxime Ripard
2024-04-23 10:45 ` [PATCH v12 18/28] drm/tests: Add tests for " Maxime Ripard
2024-04-23 10:45 ` [PATCH v12 19/28] drm/connector: hdmi: Add RGB Quantization Range to the connector state Maxime Ripard
2024-04-23 10:45 ` [PATCH v12 20/28] drm/tests: Add RGB Quantization tests Maxime Ripard
2024-04-23 10:45 ` [PATCH v12 21/28] drm/connector: hdmi: Add Infoframes generation Maxime Ripard
2024-04-23 10:45 ` [PATCH v12 22/28] drm/tests: Add infoframes test Maxime Ripard
2024-04-23 10:45 ` [PATCH v12 23/28] drm/connector: hdmi: Create Infoframe DebugFS entries Maxime Ripard
2024-04-23 10:45 ` [PATCH v12 24/28] drm/vc4: hdmi: Switch to HDMI connector Maxime Ripard
2024-04-23 10:45 ` [PATCH v12 25/28] drm/vc4: tests: Remove vc4_dummy_plane structure Maxime Ripard
2024-04-23 10:45 ` Maxime Ripard [this message]
2024-04-23 10:45 ` [PATCH v12 27/28] drm/rockchip: inno_hdmi: Switch to HDMI connector Maxime Ripard
2024-04-27 10:12 ` Andy Yan
2024-05-06 7:49 ` Maxime Ripard
2024-04-27 10:44 ` Andy Yan
2024-05-06 7:59 ` Maxime Ripard
2024-05-06 8:22 ` Andy Yan
2024-05-07 1:32 ` Andy Yan
2024-04-23 10:45 ` [PATCH v12 28/28] drm/sun4i: hdmi: " Maxime Ripard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240423-kms-hdmi-connector-state-v12-26-3338e4c0b189@kernel.org \
--to=mripard@kernel.org \
--cc=airlied@gmail.com \
--cc=andy.yan@rock-chips.com \
--cc=corbet@lwn.net \
--cc=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=heiko@sntech.de \
--cc=hjc@rock-chips.com \
--cc=hverkuil@xs4all.nl \
--cc=jernej.skrabec@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=linux-sunxi@lists.linux.dev \
--cc=maarten.lankhorst@linux.intel.com \
--cc=mcanal@igalia.com \
--cc=samuel@sholland.org \
--cc=sebastian.wick@redhat.com \
--cc=tzimmermann@suse.de \
--cc=ville.syrjala@linux.intel.com \
--cc=wens@csie.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).