archive mirror
 help / color / mirror / Atom feed
From: Samuel Holland <>
To: Ivaylo Dimitrov <>,
Cc:,,, Merlijn Wajer <>
Subject: Re: [BISECTED] Allwinner A33 tablet does not fully power off
Date: Fri, 4 Nov 2022 21:21:23 -0500	[thread overview]
Message-ID: <> (raw)
In-Reply-To: <>

Hi Ivo,

On 10/29/22 10:23, Ivaylo Dimitrov wrote:
> After commit 843107498f91e57d1d4b22cd8787112726fdaeb4 (bus: sunxi-rsb:
> Implement suspend/resume/shutdown callbacks) Q8 A33 tablet I have here
> cannot be powered-on after power-off, it needs press-and-hold of the
> power button for 10 seconds (I guess some HW assisted power down
> happens) before it can be powered-on again.
> The following patch makes it behave correctly:
> diff --git a/drivers/bus/sunxi-rsb.c b/drivers/bus/sunxi-rsb.c
> index 60b082fe2ed0..30016d62044c 100644
> --- a/drivers/bus/sunxi-rsb.c
> +++ b/drivers/bus/sunxi-rsb.c
> @@ -818,10 +818,7 @@ static int sunxi_rsb_remove(struct platform_device
> *pdev)
>  static void sunxi_rsb_shutdown(struct platform_device *pdev)
>  {
> -       struct sunxi_rsb *rsb = platform_get_drvdata(pdev);
> -
>         pm_runtime_disable(&pdev->dev);
> -       sunxi_rsb_hw_exit(rsb);
>  }
>  static const struct dev_pm_ops sunxi_rsb_dev_pm_ops = {
> I guess the issue comes from the fact that by the time 'power off'
> command to the power management IC has to be send, the bus it lives on
> is already down, so the device is left in semi-powered down state. Ofc
> this is a wild guess, however, preventing the bus being turned off on
> shutdown fixes the issue.

Your guess is correct. The controller gets shut down in


but the PMIC communication needs to happen later in


> Please LMK if the above is the correct approach so I will send a proper
> patch or something else shall be fixed.

Yes, this is exactly the right approach. The whole sunxi_rsb_shutdown()
function should be removed. When you send a patch, please add a Fixes:
tag referencing the commit that you bisected to.


  reply	other threads:[~2022-11-05  2:21 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-10-29 15:23 [BISECTED] Allwinner A33 tablet does not fully power off Ivaylo Dimitrov
2022-11-05  2:21 ` Samuel Holland [this message]
2022-11-05  8:23   ` Ivaylo Dimitrov
2022-11-05 19:18     ` Samuel Holland
2022-11-06  7:15       ` Ivaylo Dimitrov
2022-11-06  7:27         ` Jernej Škrabec

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \ \ \ \ \ \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).