* [PATCH] arm64: dts: allwinner: Pine H64: Enable USB 3.0 port
@ 2021-05-10 13:01 Andre Przywara
2021-05-10 15:30 ` Jernej Škrabec
0 siblings, 1 reply; 3+ messages in thread
From: Andre Przywara @ 2021-05-10 13:01 UTC (permalink / raw)
To: Rob Herring, Maxime Ripard, Chen-Yu Tsai
Cc: Jernej Skrabec, Icenowy Zheng, Samuel Holland, Corentin Labbe,
Clément Péron, devicetree, linux-arm-kernel,
linux-sunxi, linux-sunxi
The Pine H64 board features an USB 3.0 type A port, which works just
fine.
Enable the controller and USB PHY in the .dts to make it usable.
Signed-off-by: Andre Przywara <andre.przywara@arm.com>
---
arch/arm64/boot/dts/allwinner/sun50i-h6-pine-h64.dts | 9 +++++++++
1 file changed, 9 insertions(+)
diff --git a/arch/arm64/boot/dts/allwinner/sun50i-h6-pine-h64.dts b/arch/arm64/boot/dts/allwinner/sun50i-h6-pine-h64.dts
index 1ffd68f43f87..9061c9913f4c 100644
--- a/arch/arm64/boot/dts/allwinner/sun50i-h6-pine-h64.dts
+++ b/arch/arm64/boot/dts/allwinner/sun50i-h6-pine-h64.dts
@@ -89,6 +89,10 @@
status = "okay";
};
+&dwc3 {
+ status = "okay";
+};
+
&ehci0 {
status = "okay";
};
@@ -332,3 +336,8 @@
usb3_vbus-supply = <®_usb_vbus>;
status = "okay";
};
+
+&usb3phy {
+ phy-supply = <®_usb_vbus>;
+ status = "okay";
+};
--
2.17.5
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] arm64: dts: allwinner: Pine H64: Enable USB 3.0 port
2021-05-10 13:01 [PATCH] arm64: dts: allwinner: Pine H64: Enable USB 3.0 port Andre Przywara
@ 2021-05-10 15:30 ` Jernej Škrabec
2021-05-10 15:36 ` Jernej Škrabec
0 siblings, 1 reply; 3+ messages in thread
From: Jernej Škrabec @ 2021-05-10 15:30 UTC (permalink / raw)
To: Rob Herring, Maxime Ripard, Chen-Yu Tsai, Andre Przywara
Cc: Icenowy Zheng, Samuel Holland, Corentin Labbe,
Clément Péron, devicetree, linux-arm-kernel,
linux-sunxi, linux-sunxi
Hi Andre!
Dne ponedeljek, 10. maj 2021 ob 15:01:19 CEST je Andre Przywara napisal(a):
> The Pine H64 board features an USB 3.0 type A port, which works just
> fine.
>
> Enable the controller and USB PHY in the .dts to make it usable.
>
> Signed-off-by: Andre Przywara <andre.przywara@arm.com>
> ---
> arch/arm64/boot/dts/allwinner/sun50i-h6-pine-h64.dts | 9 +++++++++
> 1 file changed, 9 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/allwinner/sun50i-h6-pine-h64.dts b/arch/
arm64/boot/dts/allwinner/sun50i-h6-pine-h64.dts
> index 1ffd68f43f87..9061c9913f4c 100644
> --- a/arch/arm64/boot/dts/allwinner/sun50i-h6-pine-h64.dts
> +++ b/arch/arm64/boot/dts/allwinner/sun50i-h6-pine-h64.dts
> @@ -89,6 +89,10 @@
> status = "okay";
> };
>
> +&dwc3 {
> + status = "okay";
> +};
> +
> &ehci0 {
> status = "okay";
> };
> @@ -332,3 +336,8 @@
> usb3_vbus-supply = <®_usb_vbus>;
> status = "okay";
> };
> +
> +&usb3phy {
> + phy-supply = <®_usb_vbus>;
> + status = "okay";
> +};
> --
> 2.17.5
>
Exactly the same patch was already proposed by Icenowy. In short, PHY is
powered by internal power and doesn't need phy-supply property. It's connector
that needs power supply. One of her latest attempts can be found here:
https://lore.kernel.org/patchwork/cover/1058917/
Best regards,
Jernej
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: Re: [PATCH] arm64: dts: allwinner: Pine H64: Enable USB 3.0 port
2021-05-10 15:30 ` Jernej Škrabec
@ 2021-05-10 15:36 ` Jernej Škrabec
0 siblings, 0 replies; 3+ messages in thread
From: Jernej Škrabec @ 2021-05-10 15:36 UTC (permalink / raw)
To: Rob Herring, Maxime Ripard, Chen-Yu Tsai, Andre Przywara
Cc: Icenowy Zheng, Samuel Holland, Corentin Labbe,
Clément Péron, devicetree, linux-arm-kernel,
linux-sunxi, linux-sunxi
Dne ponedeljek, 10. maj 2021 ob 17:30:44 CEST je Jernej Škrabec napisal(a):
> Hi Andre!
>
> Dne ponedeljek, 10. maj 2021 ob 15:01:19 CEST je Andre Przywara napisal(a):
> > The Pine H64 board features an USB 3.0 type A port, which works just
> > fine.
> >
> > Enable the controller and USB PHY in the .dts to make it usable.
> >
> > Signed-off-by: Andre Przywara <andre.przywara@arm.com>
> > ---
> > arch/arm64/boot/dts/allwinner/sun50i-h6-pine-h64.dts | 9 +++++++++
> > 1 file changed, 9 insertions(+)
> >
> > diff --git a/arch/arm64/boot/dts/allwinner/sun50i-h6-pine-h64.dts b/arch/
> arm64/boot/dts/allwinner/sun50i-h6-pine-h64.dts
> > index 1ffd68f43f87..9061c9913f4c 100644
> > --- a/arch/arm64/boot/dts/allwinner/sun50i-h6-pine-h64.dts
> > +++ b/arch/arm64/boot/dts/allwinner/sun50i-h6-pine-h64.dts
> > @@ -89,6 +89,10 @@
> > status = "okay";
> > };
> >
> > +&dwc3 {
> > + status = "okay";
> > +};
> > +
> > &ehci0 {
> > status = "okay";
> > };
> > @@ -332,3 +336,8 @@
> > usb3_vbus-supply = <®_usb_vbus>;
> > status = "okay";
> > };
> > +
> > +&usb3phy {
> > + phy-supply = <®_usb_vbus>;
> > + status = "okay";
> > +};
> > --
> > 2.17.5
> >
>
> Exactly the same patch was already proposed by Icenowy. In short, PHY is
> powered by internal power and doesn't need phy-supply property. It's
connector
> that needs power supply. One of her latest attempts can be found here:
> https://lore.kernel.org/patchwork/cover/1058917/
P.S: Maybe wait on outcome of https://lore.kernel.org/linux-sunxi/
20210430031912.42252-1-samuel@sholland.org/T/#t which may change USB3 node
form.
Best regards,
Jernej
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-05-10 15:36 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-05-10 13:01 [PATCH] arm64: dts: allwinner: Pine H64: Enable USB 3.0 port Andre Przywara
2021-05-10 15:30 ` Jernej Škrabec
2021-05-10 15:36 ` Jernej Škrabec
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).