From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ed1-f46.google.com (mail-ed1-f46.google.com [209.85.208.46]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C15B31FAA for ; Sat, 30 Jul 2022 09:12:28 +0000 (UTC) Received: by mail-ed1-f46.google.com with SMTP id e15so8293267edj.2 for ; Sat, 30 Jul 2022 02:12:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=hll3ibUAqwWMG/OtKvhLlM3Hjch+TNh/bFfU6jv+6g4=; b=UIvlOiZjgq7+FWhOckuO00o7AIlyQZ2vDqbOSmqJnIrmhVs3J56EiTFct5I279Lkqf +eXwGIIecQdAbHOb+l2dJWwK/lr4IWvn2nDdgucESnOsZS3WLnG5r++kWrEXnIqL6t2b yElo8+B3x0fX7dLh4mMQabuoB0PE5PO1XMK0gYrC8qDyYujV8TAHQoCZmLn6j1f9azUc YzVJhvTOSMTX0zI6cAaIxHiY3BP2ybwCILXOVPqgwxt77MANU1iyXgpXCb3NvDHNJTTv yxUakWjvKPdk7KDgqdeB9DGPej6EBT8/T7FmJtCr7c9E7l+2NpQKxRwl65Ts+1XWrk52 tsWA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=hll3ibUAqwWMG/OtKvhLlM3Hjch+TNh/bFfU6jv+6g4=; b=xi0K4bNGbLDVullfxKh49rJgKSuqIBJzoUQLpgc7jIh0fdOtX6MquR4cYX4Y8M9FUt WeZT24HblIuAvSXLAMpRPKmscuVI//5pfaFsQ0Ch8t1wmKdVDPn486/CtJTKiaZPFW5b c6NGVociRHpnfNIDLN8g/vdYu+fik2ksSxEtb+5SmiIRXTECi26SyFpKgtHyJ43W1bTW a609Sc3GrLer6vrvQ4buPx8ea6CKmdQcxj4+5fMtgegqgX7fZWHTV+aS30oCqPzJ0Xhz O3V5s18a8Dt21T+O1r+yW5WthXXT87kfp26JUBlg8Bi7m56Y64dpXskTm8evGg6+8JOw 0JHA== X-Gm-Message-State: AJIora/yE7oi0zYYlu+Y5iq7jqmvsa0jcGGHReHIIOiI0BtgH4tQkNrA CYnWdO6toYdKHh0H03f1Jwg= X-Google-Smtp-Source: AGRyM1s0xAfvYSqaUCZnsf6TarPfFgDLdgevrEr1is/O1hRHAi0uogjW59OUmgXy0aJbO16CWW7UwQ== X-Received: by 2002:a05:6402:51d1:b0:43b:f89e:a751 with SMTP id r17-20020a05640251d100b0043bf89ea751mr6943326edd.391.1659172347045; Sat, 30 Jul 2022 02:12:27 -0700 (PDT) Received: from jernej-laptop.localnet (194-152-27-124.dynamic.telemach.net. [194.152.27.124]) by smtp.gmail.com with ESMTPSA id 1-20020a170906200100b0072b40cb28a8sm2706263ejo.29.2022.07.30.02.12.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 30 Jul 2022 02:12:26 -0700 (PDT) From: Jernej =?utf-8?B?xaBrcmFiZWM=?= To: Martin Blumenstingl , Chen-Yu Tsai , Philipp Zabel , Jerome Brunet , Samuel Holland , Thomas Zimmermann , Daniel Vetter , Emma Anholt , David Airlie , Maarten Lankhorst , Noralf =?ISO-8859-1?Q?Tr=F8nnes?= , Kevin Hilman , Neil Armstrong , Maxime Ripard , Maxime Ripard Cc: Maxime Ripard , linux-sunxi@lists.linux.dev, linux-kernel@vger.kernel.org, Phil Elwell , Mateusz Kwiatkowski , linux-arm-kernel@lists.infradead.org, Geert Uytterhoeven , Dave Stevenson , linux-amlogic@lists.infradead.org, dri-devel@lists.freedesktop.org, Dom Cobley Subject: Re: [PATCH v1 26/35] drm/sun4i: tv: Convert to atomic hooks Date: Sat, 30 Jul 2022 11:12:24 +0200 Message-ID: <2638619.mvXUDI8C0e@jernej-laptop> In-Reply-To: <20220728-rpi-analog-tv-properties-v1-26-3d53ae722097@cerno.tech> References: <20220728-rpi-analog-tv-properties-v1-0-3d53ae722097@cerno.tech> <20220728-rpi-analog-tv-properties-v1-26-3d53ae722097@cerno.tech> Precedence: bulk X-Mailing-List: linux-sunxi@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Dne petek, 29. julij 2022 ob 18:35:09 CEST je Maxime Ripard napisal(a): > The VC4 VEC driver still uses legacy enable and disable hook s/VC4 VEC/sun4i tv/ Best regards, Jernej > implementation. Let's convert to the atomic variants. > > Signed-off-by: Maxime Ripard > > diff --git a/drivers/gpu/drm/sun4i/sun4i_tv.c > b/drivers/gpu/drm/sun4i/sun4i_tv.c index 53152d77c392..f7aad995ab5b 100644 > --- a/drivers/gpu/drm/sun4i/sun4i_tv.c > +++ b/drivers/gpu/drm/sun4i/sun4i_tv.c > @@ -339,7 +339,8 @@ static void sun4i_tv_mode_to_drm_mode(const struct > tv_mode *tv_mode, mode->vtotal = mode->vsync_end + tv_mode->vback_porch; > } > > -static void sun4i_tv_disable(struct drm_encoder *encoder) > +static void sun4i_tv_disable(struct drm_encoder *encoder, > + struct drm_atomic_state *state) > { > struct sun4i_tv *tv = drm_encoder_to_sun4i_tv(encoder); > struct sun4i_crtc *crtc = drm_crtc_to_sun4i_crtc(encoder->crtc); > @@ -353,7 +354,8 @@ static void sun4i_tv_disable(struct drm_encoder > *encoder) sunxi_engine_disable_color_correction(crtc->engine); > } > > -static void sun4i_tv_enable(struct drm_encoder *encoder) > +static void sun4i_tv_enable(struct drm_encoder *encoder, > + struct drm_atomic_state *state) > { > struct sun4i_tv *tv = drm_encoder_to_sun4i_tv(encoder); > struct sun4i_crtc *crtc = drm_crtc_to_sun4i_crtc(encoder->crtc); > @@ -469,8 +471,8 @@ static void sun4i_tv_mode_set(struct drm_encoder > *encoder, } > > static const struct drm_encoder_helper_funcs sun4i_tv_helper_funcs = { > - .disable = sun4i_tv_disable, > - .enable = sun4i_tv_enable, > + .atomic_disable = sun4i_tv_disable, > + .atomic_enable = sun4i_tv_enable, > .mode_set = sun4i_tv_mode_set, > };