From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ed1-f54.google.com (mail-ed1-f54.google.com [209.85.208.54]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D52CD3FC4 for ; Wed, 15 Sep 2021 16:31:23 +0000 (UTC) Received: by mail-ed1-f54.google.com with SMTP id n10so5616425eda.10 for ; Wed, 15 Sep 2021 09:31:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=EFqug29mO3vbFWGSrI/1RvpvL9yEVHmFJFSMpcyO/D0=; b=UXufWIgN+iIt2kTGcgk2/QvgWZXZxZmsFdb+oZHQ/ZaIWInpXjpPT1TO19otc7dapr xCU8SGOLOJYNO5DtjYXx6VtC2Xcph0fy1/m13VC658uw+4m8WeYnejuSuN7uoijpZeCH 7osLtNe+9H1/WyAHbX+HjTYIq/x3wnIkv1eU/dBIyIawdUue/tJd7U0FVmKSUBcc/hp8 jqNASK8RoNT0KmuKhxlyqzbLtiH70OqW4gHyWCbo83Q1CifY0i0RfxFMa2nsIHo4vYVf hWyE0fkxO4errp83fDAqDSfZT3Y1Av30dnq9UnfXumsucC/J6eprSfHOhY/T+7rzs951 DKjQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=EFqug29mO3vbFWGSrI/1RvpvL9yEVHmFJFSMpcyO/D0=; b=ElJZ7uXbn5E2H+ZTcWUUrHBXSlMwegCwpEKiHE3IjkbL29J3qgiOUOt04pq7wW209n eWSjv8TkvGtFpzC7rdNiPEPXzOiPkQyJenJA6mul9OIvnaEPRWyoKjLIAdaDoIXsn43T qXZIZFEmIK/QZMdzKqY9alqvOHYa0O7zmoVa0fyvFf5e+vAPuFMqN6Tt3JiJ7/4rodqS oRVSeG55s+D20+hVIaUH2d1bjK1dX0HBsAgm+PCvclDGA5Cuu1DQIN2+s6MJlFBt/KAH Y7NF2q5d8Vkk3JlsDiWfncoaYiIBWGSZI4a8skY7SMHrklG6XhWmcRovlt9GPSwhgsJN LNMQ== X-Gm-Message-State: AOAM530K9Ukrps0C186hcLXvCHpDFXMpNqlqh+XcBw2fqi7sIxpUD3Yb rR/k+qIYemtSah81u3WQlL8= X-Google-Smtp-Source: ABdhPJyNT5tuWqL5VdFq6b5f10J9qWPN4RnW1uZ2pn60g/i01gH6ZIFSvdpUuCcq2ox80ka2Twlc0Q== X-Received: by 2002:a05:6402:1c87:: with SMTP id cy7mr892737edb.311.1631723482246; Wed, 15 Sep 2021 09:31:22 -0700 (PDT) Received: from kista.localnet (cpe-86-58-29-253.static.triera.net. [86.58.29.253]) by smtp.gmail.com with ESMTPSA id kt19sm207194ejb.26.2021.09.15.09.31.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 15 Sep 2021 09:31:21 -0700 (PDT) From: Jernej =?utf-8?B?xaBrcmFiZWM=?= To: Dang Huynh Cc: Rob Herring , Maxime Ripard , Chen-Yu Tsai , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-sunxi@lists.linux.dev, linux-kernel@vger.kernel.org Subject: Re: Re: [PATCH] arm64: dts: allwinner: pinetab: Add HDMI support Date: Wed, 15 Sep 2021 18:31:20 +0200 Message-ID: <2776109.MaXvng3DlT@kista> In-Reply-To: <4816863.IXWdtHWlKd@melttower> References: <20210914193732.3047668-1-danct12@disroot.org> <2558517.IGp7HM5rsX@kista> <4816863.IXWdtHWlKd@melttower> Precedence: bulk X-Mailing-List: linux-sunxi@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="UTF-8" Dne sreda, 15. september 2021 ob 07:47:31 CEST je Dang Huynh napisal(a): > On Wednesday, September 15, 2021 3:26:51 AM +07 Jernej =C5=A0krabec wrote: > > > +&simplefb_hdmi { > > > + vcc-hdmi-supply =3D <®_dldo1>; > >=20 > > You have to set status to okay here. Sorry, this is actually the job of bootloader, so it's all good. > >=20 > > With that fixed, you can add: No fixing needed for R-b tag. > > Reviewed-by: Jernej Skrabec > >=20 > > Best regards, > > Jernej > >=20 >=20 > Is it really needed? The DE2 HDMI driver can be loaded and make this pret= ty=20 > much obsolete. DE2 and HDMI driver could read current settings from that node and implemen= t=20 flicker free transition. However, that's not supported yet. Another use cas= e is=20 to optimize kernel size to minimum for storing it in SPI flash by removing = DRM=20 driver if simplefb is good enough. Anyway, patch looks good. Thanks! Best regards, Jernej