* [PATCH] arm: dts: sunxi: h3/h5: Fix I2S2 node
@ 2021-09-05 19:26 Jernej Skrabec
2021-09-05 19:40 ` Jernej Škrabec
0 siblings, 1 reply; 2+ messages in thread
From: Jernej Skrabec @ 2021-09-05 19:26 UTC (permalink / raw)
To: mripard, wens
Cc: robh+dt, codekipper, peron.clem, devicetree, linux-arm-kernel,
linux-sunxi, linux-kernel, Jernej Skrabec
I2S2 controller has RX DMA channel according to documentation.
Add it.
Fixes: cd7c897821a0 ("arm: dts: sunxi: h3/h5: Add I2S2 node")
Signed-off-by: Jernej Skrabec <jernej.skrabec@gmail.com>
---
arch/arm/boot/dts/sunxi-h3-h5.dtsi | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/arch/arm/boot/dts/sunxi-h3-h5.dtsi b/arch/arm/boot/dts/sunxi-h3-h5.dtsi
index c7428df9469e..bd26f2059220 100644
--- a/arch/arm/boot/dts/sunxi-h3-h5.dtsi
+++ b/arch/arm/boot/dts/sunxi-h3-h5.dtsi
@@ -670,9 +670,9 @@ i2s2: i2s@1c22800 {
interrupts = <GIC_SPI 15 IRQ_TYPE_LEVEL_HIGH>;
clocks = <&ccu CLK_BUS_I2S2>, <&ccu CLK_I2S2>;
clock-names = "apb", "mod";
- dmas = <&dma 27>;
+ dmas = <&dma 27>, <&dma 27>;
resets = <&ccu RST_BUS_I2S2>;
- dma-names = "tx";
+ dma-names = "tx", "rx";
status = "disabled";
};
--
2.33.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] arm: dts: sunxi: h3/h5: Fix I2S2 node
2021-09-05 19:26 [PATCH] arm: dts: sunxi: h3/h5: Fix I2S2 node Jernej Skrabec
@ 2021-09-05 19:40 ` Jernej Škrabec
0 siblings, 0 replies; 2+ messages in thread
From: Jernej Škrabec @ 2021-09-05 19:40 UTC (permalink / raw)
To: mripard, wens
Cc: robh+dt, codekipper, peron.clem, devicetree, linux-arm-kernel,
linux-sunxi, linux-kernel
Hi all,
Dne nedelja, 05. september 2021 ob 21:26:28 CEST je Jernej Skrabec napisal(a):
> I2S2 controller has RX DMA channel according to documentation.
>
Sorry for mistake. This is not true. Documentation doesn't have RX DMA
documented (I2S2 is connected to HDMI).
Marcus, do you remember if loopback mode actually works on H3, with DMA
enabled? Maybe DMA is there, just undocumented. Some SoCs (H6, R40) have RX
DMA channel documented, even though it's used for HDMI TX only, and others
don't (A64, H3, H5).
Anyway, I got report that I2S driver from 5.14 onwards can't register
controller anymore due to missing RX DMA channel. So either driver or DT has
to be fixed.
Please disregard this patch for now.
Best regards,
Jernej
> Add it.
>
> Fixes: cd7c897821a0 ("arm: dts: sunxi: h3/h5: Add I2S2 node")
> Signed-off-by: Jernej Skrabec <jernej.skrabec@gmail.com>
> ---
> arch/arm/boot/dts/sunxi-h3-h5.dtsi | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/arch/arm/boot/dts/sunxi-h3-h5.dtsi b/arch/arm/boot/dts/sunxi-h3-
h5.dtsi
> index c7428df9469e..bd26f2059220 100644
> --- a/arch/arm/boot/dts/sunxi-h3-h5.dtsi
> +++ b/arch/arm/boot/dts/sunxi-h3-h5.dtsi
> @@ -670,9 +670,9 @@ i2s2: i2s@1c22800 {
> interrupts = <GIC_SPI 15
IRQ_TYPE_LEVEL_HIGH>;
> clocks = <&ccu CLK_BUS_I2S2>, <&ccu
CLK_I2S2>;
> clock-names = "apb", "mod";
> - dmas = <&dma 27>;
> + dmas = <&dma 27>, <&dma 27>;
> resets = <&ccu RST_BUS_I2S2>;
> - dma-names = "tx";
> + dma-names = "tx", "rx";
> status = "disabled";
> };
>
> --
> 2.33.0
>
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-09-05 19:40 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-09-05 19:26 [PATCH] arm: dts: sunxi: h3/h5: Fix I2S2 node Jernej Skrabec
2021-09-05 19:40 ` Jernej Škrabec
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).