From: "Jernej Škrabec" <jernej.skrabec@gmail.com>
To: Rob Herring <robh@kernel.org>, Maxime Ripard <mripard@kernel.org>,
Chen-Yu Tsai <wens@csie.org>,
Andre Przywara <andre.przywara@arm.com>
Cc: "Icenowy Zheng" <icenowy@aosc.io>,
"Samuel Holland" <samuel@sholland.org>,
"Corentin Labbe" <clabbe@baylibre.com>,
"Clément Péron" <peron.clem@gmail.com>,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-sunxi@googlegroups.com, linux-sunxi@lists.linux.dev
Subject: Re: Re: [PATCH] arm64: dts: allwinner: Pine H64: Enable USB 3.0 port
Date: Mon, 10 May 2021 17:36:05 +0200 [thread overview]
Message-ID: <5404798.YEtBip1y79@kista> (raw)
In-Reply-To: <2288435.7XXmsQVVxE@kista>
Dne ponedeljek, 10. maj 2021 ob 17:30:44 CEST je Jernej Škrabec napisal(a):
> Hi Andre!
>
> Dne ponedeljek, 10. maj 2021 ob 15:01:19 CEST je Andre Przywara napisal(a):
> > The Pine H64 board features an USB 3.0 type A port, which works just
> > fine.
> >
> > Enable the controller and USB PHY in the .dts to make it usable.
> >
> > Signed-off-by: Andre Przywara <andre.przywara@arm.com>
> > ---
> > arch/arm64/boot/dts/allwinner/sun50i-h6-pine-h64.dts | 9 +++++++++
> > 1 file changed, 9 insertions(+)
> >
> > diff --git a/arch/arm64/boot/dts/allwinner/sun50i-h6-pine-h64.dts b/arch/
> arm64/boot/dts/allwinner/sun50i-h6-pine-h64.dts
> > index 1ffd68f43f87..9061c9913f4c 100644
> > --- a/arch/arm64/boot/dts/allwinner/sun50i-h6-pine-h64.dts
> > +++ b/arch/arm64/boot/dts/allwinner/sun50i-h6-pine-h64.dts
> > @@ -89,6 +89,10 @@
> > status = "okay";
> > };
> >
> > +&dwc3 {
> > + status = "okay";
> > +};
> > +
> > &ehci0 {
> > status = "okay";
> > };
> > @@ -332,3 +336,8 @@
> > usb3_vbus-supply = <®_usb_vbus>;
> > status = "okay";
> > };
> > +
> > +&usb3phy {
> > + phy-supply = <®_usb_vbus>;
> > + status = "okay";
> > +};
> > --
> > 2.17.5
> >
>
> Exactly the same patch was already proposed by Icenowy. In short, PHY is
> powered by internal power and doesn't need phy-supply property. It's
connector
> that needs power supply. One of her latest attempts can be found here:
> https://lore.kernel.org/patchwork/cover/1058917/
P.S: Maybe wait on outcome of https://lore.kernel.org/linux-sunxi/
20210430031912.42252-1-samuel@sholland.org/T/#t which may change USB3 node
form.
Best regards,
Jernej
prev parent reply other threads:[~2021-05-10 15:36 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-10 13:01 [PATCH] arm64: dts: allwinner: Pine H64: Enable USB 3.0 port Andre Przywara
2021-05-10 15:30 ` Jernej Škrabec
2021-05-10 15:36 ` Jernej Škrabec [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5404798.YEtBip1y79@kista \
--to=jernej.skrabec@gmail.com \
--cc=andre.przywara@arm.com \
--cc=clabbe@baylibre.com \
--cc=devicetree@vger.kernel.org \
--cc=icenowy@aosc.io \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-sunxi@googlegroups.com \
--cc=linux-sunxi@lists.linux.dev \
--cc=mripard@kernel.org \
--cc=peron.clem@gmail.com \
--cc=robh@kernel.org \
--cc=samuel@sholland.org \
--cc=wens@csie.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).