From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ej1-f45.google.com (mail-ej1-f45.google.com [209.85.218.45]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9AA6E23D9 for ; Sat, 30 Jul 2022 09:13:09 +0000 (UTC) Received: by mail-ej1-f45.google.com with SMTP id l23so12162681ejr.5 for ; Sat, 30 Jul 2022 02:13:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=F8fhUxE3x4wOe3m4a14najZDDA734PpdZ0zvY9IBgdA=; b=ZG2IrV2r1EWLt75BM97iRoI2Fc0pagt70o4R2poxmBf1kaPFF05otKfuGf7gXtlNu+ /dCPH7viH0STK8OcySYRw+QBBy73BSHjr+CT0al1b+vpb2imlIe74RmeRrf9pQqUJaH5 TmBS8LD7rue5YdqAeAFvd+htM27uzgkRJKkN/kfIiTlXZVxmf1bjlsTP2BM0P0T1kNv7 XoxF9QpD+8/TlHICB89Z2XN/1dNWdNao5r8EoIVdL+YOvRB+TDYnU99NpmticLyjn5B1 8h1LYPxQE/lZczOWieZs/hZZCk2VgzErcnMC5xg6qLsBux25HfhSNtlgrJRdhFhQT/L2 aydg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=F8fhUxE3x4wOe3m4a14najZDDA734PpdZ0zvY9IBgdA=; b=NsiAtL1buXwbu7eJSD7UN0kJWJCd6NUPVF4hfWJ9ulBiNOE1wYsG2l6B5lT2oht6GL pw3nd5TMEgugqwS7iQUN55djcsWV/LTt8fXDQx3/1PWTAgE1mmCpcDIbJagfKA8v+IrV mVtjQTujLvNrdFXTU7IAbCS/dHP5c64l6adr+ebgKnTyAiZl4qWmevZbh4bOeFJvPgM/ CwSqPuAYunzLtUSCgqfD75VvEVAhSWbxjrPPcyCok39F4YzYSx368K2WnjvBuRiXuM5t lX90HMu8kaMZUopvvWTyvO/e4ALoW5jNtrsRo5C73g/Ntg1epeV5ktcHs6V/b2nvr3pf NkgQ== X-Gm-Message-State: AJIora82inZ+4mxC4du9wFwNyEx+YpTqfdHBxe8uNlA6o2J8sDGY5oHL vYrMjEifmdf92ZRoTfS9fCI= X-Google-Smtp-Source: AGRyM1vnGZx3SWdOvFK05YcUTuAQpbJMQBq6meu894/eIUroxXOHiUFMsPL5aHg++vyEFuUAzaEVrw== X-Received: by 2002:a17:907:948e:b0:72d:3fd2:5da0 with SMTP id dm14-20020a170907948e00b0072d3fd25da0mr5613928ejc.225.1659172387794; Sat, 30 Jul 2022 02:13:07 -0700 (PDT) Received: from jernej-laptop.localnet (194-152-27-124.dynamic.telemach.net. [194.152.27.124]) by smtp.gmail.com with ESMTPSA id j10-20020a17090623ea00b0072b616ade26sm1344215ejg.216.2022.07.30.02.13.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 30 Jul 2022 02:13:07 -0700 (PDT) From: Jernej =?utf-8?B?xaBrcmFiZWM=?= To: Martin Blumenstingl , Chen-Yu Tsai , Philipp Zabel , Jerome Brunet , Samuel Holland , Thomas Zimmermann , Daniel Vetter , Emma Anholt , David Airlie , Maarten Lankhorst , Noralf =?ISO-8859-1?Q?Tr=F8nnes?= , Kevin Hilman , Neil Armstrong , Maxime Ripard , Maxime Ripard Cc: Maxime Ripard , linux-sunxi@lists.linux.dev, linux-kernel@vger.kernel.org, Phil Elwell , Mateusz Kwiatkowski , linux-arm-kernel@lists.infradead.org, Geert Uytterhoeven , Dave Stevenson , linux-amlogic@lists.infradead.org, dri-devel@lists.freedesktop.org, Dom Cobley Subject: Re: [PATCH v1 25/35] drm/sun4i: tv: Remove unused mode_valid Date: Sat, 30 Jul 2022 11:13:05 +0200 Message-ID: <5587265.DvuYhMxLoT@jernej-laptop> In-Reply-To: <20220728-rpi-analog-tv-properties-v1-25-3d53ae722097@cerno.tech> References: <20220728-rpi-analog-tv-properties-v1-0-3d53ae722097@cerno.tech> <20220728-rpi-analog-tv-properties-v1-25-3d53ae722097@cerno.tech> Precedence: bulk X-Mailing-List: linux-sunxi@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Dne petek, 29. julij 2022 ob 18:35:08 CEST je Maxime Ripard napisal(a): > The mode_valid implementation is pretty much a nop, let's remove it. > > Signed-off-by: Maxime Ripard Reviewed-by: Jernej Skrabec Best regards, Jernej > > diff --git a/drivers/gpu/drm/sun4i/sun4i_tv.c > b/drivers/gpu/drm/sun4i/sun4i_tv.c index 94883abe0dfd..53152d77c392 100644 > --- a/drivers/gpu/drm/sun4i/sun4i_tv.c > +++ b/drivers/gpu/drm/sun4i/sun4i_tv.c > @@ -497,16 +497,8 @@ static int sun4i_tv_comp_get_modes(struct drm_connector > *connector) return i; > } > > -static int sun4i_tv_comp_mode_valid(struct drm_connector *connector, > - struct drm_display_mode *mode) > -{ > - /* TODO */ > - return MODE_OK; > -} > - > static const struct drm_connector_helper_funcs > sun4i_tv_comp_connector_helper_funcs = { .get_modes = > sun4i_tv_comp_get_modes, > - .mode_valid = sun4i_tv_comp_mode_valid, > }; > > static void