From: "Jernej Škrabec" <jernej.skrabec@gmail.com>
To: Liam Girdwood <lgirdwood@gmail.com>,
Mark Brown <broonie@kernel.org>, Jaroslav Kysela <perex@perex.cz>,
Takashi Iwai <tiwai@suse.com>, Chen-Yu Tsai <wens@csie.org>,
Samuel Holland <samuel@sholland.org>,
Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>,
Mikhail Rudenko <mike.rudenko@gmail.com>
Cc: Mikhail Rudenko <mike.rudenko@gmail.com>,
alsa-devel@alsa-project.org,
linux-arm-kernel@lists.infradead.org,
linux-sunxi@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] ASoC: sunxi: sun4i-codec: silence misleading error in probe
Date: Mon, 12 Sep 2022 18:14:44 +0200 [thread overview]
Message-ID: <5600291.DvuYhMxLoT@jernej-laptop> (raw)
In-Reply-To: <20220911145713.55199-1-mike.rudenko@gmail.com>
Dne nedelja, 11. september 2022 ob 16:57:11 CEST je Mikhail Rudenko
napisal(a):
> In the case when a codec device is probed before codec analog
> controls, snd_soc_register_card() returns -EPROBE_DEFER, resulting in
> a misleading error message
>
> sun4i-codec 1c22c00.codec: Failed to register our card
>
> even if the device is probed successfully later. Use dev_err_probe()
> to demote the above error to a debug message.
>
> Signed-off-by: Mikhail Rudenko <mike.rudenko@gmail.com>
Acked-by: Jernej Skrabec <jernej.skrabec@gmail.com>
Best regards,
Jernej
> ---
> sound/soc/sunxi/sun4i-codec.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/sound/soc/sunxi/sun4i-codec.c b/sound/soc/sunxi/sun4i-codec.c
> index 60712f24ade5..01b461c64d68 100644
> --- a/sound/soc/sunxi/sun4i-codec.c
> +++ b/sound/soc/sunxi/sun4i-codec.c
> @@ -1825,7 +1825,7 @@ static int sun4i_codec_probe(struct platform_device
> *pdev)
>
> ret = snd_soc_register_card(card);
> if (ret) {
> - dev_err(&pdev->dev, "Failed to register our card\n");
> + dev_err_probe(&pdev->dev, ret, "Failed to register our
card\n");
> goto err_assert_reset;
> }
next prev parent reply other threads:[~2022-09-12 16:14 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-11 14:57 [PATCH 1/2] ASoC: sunxi: sun4i-codec: silence misleading error in probe Mikhail Rudenko
2022-09-11 14:57 ` [PATCH 2/2] ASoC: sunxi: sun4i-codec: set debugfs_prefix for CPU DAI component Mikhail Rudenko
2022-09-12 16:15 ` Jernej Škrabec
2022-09-13 16:04 ` Mark Brown
2022-09-13 21:22 ` [PATCH v2 1/2] ASoC: sunxi: sun4i-codec: silence misleading error in probe Mikhail Rudenko
2022-09-13 21:22 ` [PATCH v2 2/2] ASoC: sunxi: sun4i-codec: set debugfs_prefix for CPU DAI component Mikhail Rudenko
2022-09-19 23:10 ` [PATCH v2 1/2] ASoC: sunxi: sun4i-codec: silence misleading error in probe Mark Brown
2022-09-12 16:14 ` Jernej Škrabec [this message]
2022-09-14 9:40 ` [PATCH " Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5600291.DvuYhMxLoT@jernej-laptop \
--to=jernej.skrabec@gmail.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=kuninori.morimoto.gx@renesas.com \
--cc=lgirdwood@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sunxi@lists.linux.dev \
--cc=mike.rudenko@gmail.com \
--cc=perex@perex.cz \
--cc=samuel@sholland.org \
--cc=tiwai@suse.com \
--cc=wens@csie.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).