linux-sunxi.lists.linux.dev archive mirror
 help / color / mirror / Atom feed
From: Samuel Holland <samuel@sholland.org>
To: Joerg Roedel <joro@8bytes.org>
Cc: Will Deacon <will@kernel.org>,
	Robin Murphy <robin.murphy@arm.com>, Chen-Yu Tsai <wens@csie.org>,
	Jernej Skrabec <jernej.skrabec@gmail.com>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
	Rob Herring <robh+dt@kernel.org>,
	iommu@lists.linux.dev, linux-arm-kernel@lists.infradead.org,
	linux-sunxi@lists.linux.dev, linux-kernel@vger.kernel.org,
	devicetree@vger.kernel.org, Maxime Ripard <mripard@kernel.org>
Subject: Re: [PATCH v2 0/6] iommu/sun50i: Allwinner D1 support
Date: Sat, 4 Feb 2023 08:49:48 -0600	[thread overview]
Message-ID: <6302b081-fab5-2eea-1a56-5ad903ff7d54@sholland.org> (raw)
In-Reply-To: <Y9zgKUUjjPq8ifPn@8bytes.org>

Hi Joerg,

On 2/3/23 04:21, Joerg Roedel wrote:
> On Fri, Jan 20, 2023 at 04:11:30PM +0100, Joerg Roedel wrote:
>> There is a conflict between these patches and changes in the IOMMU
>> core branch. With those merged in there is a compile warning about 
>> sun50i_iommu_detach_domain() being unused. Fixing that requires
>> removing of 3-4 functions, which I am not sure is the right
>> solution.
>>
>> Once this is fixed I will include the arm/allwinner branch into my
>> next branch again.
> 
> Since there was no reply to this I nuked the patches from the IOMMU 
> tree. If this is still relevant please resubmit them after the next 
> merge window.

I am not sure what the right solution is here either, and I have not had
the chance to look at it again. With my limited understanding of how the
default domain logic works, and the fact that the IOMMU driver only
supports one domain, it seems the driver should keep that domain enabled
permanently, regardless of which devices are attached. So my patch 2
would be wrong. I will investigate and send a v3 after the merge window.

Regards,
Samuel

      reply	other threads:[~2023-02-04 14:49 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-01-03  1:08 [PATCH v2 0/6] iommu/sun50i: Allwinner D1 support Samuel Holland
2023-01-03  1:08 ` [PATCH v2 1/6] dt-bindings: iommu: sun50i: Add compatible for Allwinner D1 Samuel Holland
2023-01-08 20:53   ` Rob Herring
2023-01-03  1:08 ` [PATCH v2 2/6] iommu/sun50i: Track masters attached to the domain Samuel Holland
2023-01-04 22:04   ` Jernej Škrabec
2023-01-03  1:09 ` [PATCH v2 3/6] iommu/sun50i: Keep the bypass register up to date Samuel Holland
2023-01-04 22:06   ` Jernej Škrabec
2023-01-03  1:09 ` [PATCH v2 4/6] iommu/sun50i: Support variants without an external reset Samuel Holland
2023-01-03  1:09 ` [PATCH v2 5/6] iommu/sun50i: Add support for the D1 variant Samuel Holland
2023-01-03  1:09 ` [PATCH v2 6/6] riscv: dts: allwinner: d1: Add the IOMMU node Samuel Holland
2023-01-04 22:07   ` Jernej Škrabec
2023-01-13 15:35   ` Joerg Roedel
2023-01-14 17:17     ` Samuel Holland
2023-01-20  9:18       ` Joerg Roedel
2023-01-20 15:11 ` [PATCH v2 0/6] iommu/sun50i: Allwinner D1 support Joerg Roedel
2023-02-03 10:21   ` Joerg Roedel
2023-02-04 14:49     ` Samuel Holland [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=6302b081-fab5-2eea-1a56-5ad903ff7d54@sholland.org \
    --to=samuel@sholland.org \
    --cc=devicetree@vger.kernel.org \
    --cc=iommu@lists.linux.dev \
    --cc=jernej.skrabec@gmail.com \
    --cc=joro@8bytes.org \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-sunxi@lists.linux.dev \
    --cc=mripard@kernel.org \
    --cc=robh+dt@kernel.org \
    --cc=robin.murphy@arm.com \
    --cc=wens@csie.org \
    --cc=will@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).