From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ed1-f46.google.com (mail-ed1-f46.google.com [209.85.208.46]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 45A2963A9 for ; Sat, 17 Jun 2023 18:05:09 +0000 (UTC) Received: by mail-ed1-f46.google.com with SMTP id 4fb4d7f45d1cf-5147e40bbbbso2379883a12.3 for ; Sat, 17 Jun 2023 11:05:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1687025108; x=1689617108; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=sD3IWEzBGQZ8mcTerhCj4o67e1f5v1lsAPNkuhRyMbk=; b=IEV5Yt08YCAqcCOWQBYcV04CNBynEpE3ay2W+5BO2S+RwJkOE5pFMo78kpso2ssa7w 5U/wdsMorxouzodS0NL7sHzaliYuzlm5JgIGjA3tiDaWp/gYSiPhyGyQVF3zXzJE8t+K Y0+WxK+zwfONT3ZaQ4QL3FtEQQFSYSxHIqIb8= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1687025108; x=1689617108; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=sD3IWEzBGQZ8mcTerhCj4o67e1f5v1lsAPNkuhRyMbk=; b=RNi5pfAIqWgQssZTxubiA9X0AUAHgM8knJqborsoco+GPOSsu1DTQTFkbitX9RfMtg 55MQ3c0KJSdAls5KBLOsOtVKM/E2U5afABqFbKBEy0lfk1+bMulS2FVxlqoeQINeesi/ N6W6cfBYKKvYihKIPYhAzGCfwRYHJcVQ6Lyf3JQIlSVL44wBR2n3ruYs5N0aV7O6JI6C XtM2yq74eglgjLcN+YOVrHUiaIPpi0El0gzqUrSz9ezXawWJof2txLQ3dqvkMSx/rDgC OcZs3oqrBl6kI2tHYEF7aiTIPDe3+rKI+gmmTzI+0Nl9iMbwxX/mOTeth/9VnBFFjpLc lSsw== X-Gm-Message-State: AC+VfDw7IKIacfKkwTO6XgJ8E2EfZJiFjlwwvx7rY9OxAaqTrZviiAsR XatWsXX5G9R3GGc7pSP91+YJO6vbuWkhWaLEXfacGEBsGBA= X-Google-Smtp-Source: ACHHUZ4QpIT7cbgmtngJHfme6GL3oezkUc+Dmjf6ZIQnqsFRO+eoN8RHvnG9zJ7uvTq6G/XczMqM/A== X-Received: by 2002:a17:907:940e:b0:988:3ce8:c5bf with SMTP id dk14-20020a170907940e00b009883ce8c5bfmr686097ejc.33.1687025108007; Sat, 17 Jun 2023 11:05:08 -0700 (PDT) Received: from mail-wm1-f50.google.com (mail-wm1-f50.google.com. [209.85.128.50]) by smtp.gmail.com with ESMTPSA id y21-20020a17090614d500b009886192584esm167269ejc.28.2023.06.17.11.05.07 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 17 Jun 2023 11:05:07 -0700 (PDT) Received: by mail-wm1-f50.google.com with SMTP id 5b1f17b1804b1-3f7f7dfc037so61265e9.0 for ; Sat, 17 Jun 2023 11:05:07 -0700 (PDT) X-Received: by 2002:a05:600c:444e:b0:3f4:2736:b5eb with SMTP id v14-20020a05600c444e00b003f42736b5ebmr491530wmn.1.1687024655682; Sat, 17 Jun 2023 10:57:35 -0700 (PDT) Precedence: bulk X-Mailing-List: linux-sunxi@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 References: <20230507162616.1368908-1-u.kleine-koenig@pengutronix.de> <20230601154002.uv2wfatpb7b45duz@pengutronix.de> <20230617161222.wy55pbomnrrlfy5u@pengutronix.de> In-Reply-To: <20230617161222.wy55pbomnrrlfy5u@pengutronix.de> From: Doug Anderson Date: Sat, 17 Jun 2023 10:57:23 -0700 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: patches dropped from drm-misc-next [Was: Re: [PATCH 00/53] drm: Convert to platform remove callback returning] void To: =?UTF-8?Q?Uwe_Kleine=2DK=C3=B6nig?= Cc: =?UTF-8?Q?Heiko_St=C3=BCbner?= , Xinliang Liu , Linus Walleij , dri-devel@lists.freedesktop.org, Russell King , Alim Akhtar , Anitha Chrisanthus , Marijn Suijten , Steven Price , Sumit Semwal , Jerome Brunet , linux-samsung-soc@vger.kernel.org, Robert Foss , Karol Herbst , Samuel Holland , Kevin Hilman , =?UTF-8?B?TWHDrXJhIENhbmFs?= , Javier Martinez Canillas , Kuogee Hsieh , Akhil P Oommen , Danilo Krummrich , NXP Linux Team , Miaoqian Lin , linux-sunxi@lists.linux.dev, Rahul T R , Raphael Gallais-Pou , Jani Nikula , Sascha Hauer , etnaviv@lists.freedesktop.org, Stephen Boyd , Inki Dae , Sean Paul , Johan Hovold , Hyun Kwon , Andrew Jeffery , Jingoo Han , Seung-Woo Kim , =?UTF-8?Q?Noralf_Tr=C3=B8nnes?= , kernel@pengutronix.de, Alex Deucher , freedreno@lists.freedesktop.org, Claudiu Beznea , Alexandre Belloni , linux-aspeed@lists.ozlabs.org, Tomi Valkeinen , Thierry Reding , John Stultz , Mihail Atanassov , Liang He , =?UTF-8?B?VmlsbGUgU3lyasOkbMOk?= , lima@lists.freedesktop.org, Chunyan Zhang , Alexey Brodkin , Minghao Chi , Jonathan Hunter , linux-rockchip@lists.infradead.org, Ben Skeggs , Russell King , Alain Volmat , Liu Ying , linux-arm-msm@vger.kernel.org, Maxime Ripard , linux-amlogic@lists.infradead.org, linux-arm-kernel@lists.infradead.org, Neil Armstrong , Boris Brezillon , Sandy Huang , Paul Kocialkowski , Kyungmin Park , Maxime Coquelin , Brian Starkey , Kuninori Morimoto , Yuan Can , Stefan Agner , Michal Simek , linux-tegra@vger.kernel.org, Laurent Pinchart , Andrzej Hajda , Sam Ravnborg , Rob Herring , Xinwei Kong , Jernej Skrabec , Chen-Yu Tsai , Mali DP Maintainers , Joel Stanley , nouveau@lists.freedesktop.org, Orson Zhai , Chun-Kuang Hu , Lyude Paul , Arnd Bergmann , Guo Zhengkui , Konrad Dybcio , Alison Wang , Abhinav Kumar , Christian Gmeiner , Mark Brown , Maxime Ripard , Baolin Wang , Daniel Vetter , Liu Shixin , Tomi Valkeinen , Deepak R Varma , Kieran Bingham , Ricardo Ribalda , Tian Tao , Shawn Guo , Yannick Fertre , linux-stm32@st-md-mailman.stormreply.com, Emma Anholt , Liviu Dudau , Alexandre Torgue , linux-mips@vger.kernel.org, Paul Cercueil , David Airlie , Marek Vasut , linux-renesas-soc@vger.kernel.org, Yongqin Liu , Jayshri Pawar , Jonas Karlman , Rob Clark , Martin Blumenstingl , Philippe Cornu , Thomas Zimmermann , Melissa Wen , linux-mediatek@lists.infradead.org, Fabio Estevam , Laurentiu Palcu , Matthias Brugger , AngeloGioacchino Del Regno , Bjorn Andersson , Nicolas Ferre , Krzysztof Kozlowski , Qiang Yu , Philipp Zabel , Dmitry Baryshkov , Jyri Sarha , Lucas Stach , Christophe JAILLET , Jessica Zhang , Karol Wachowski , Laura Nao , Wang Jianzheng , Raymond Tan , Stanislaw Gruszka Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Hi, On Sat, Jun 17, 2023 at 9:15=E2=80=AFAM Uwe Kleine-K=C3=B6nig wrote: > > [expanding recipents by the other affected persons] > > On Thu, Jun 08, 2023 at 09:08:15AM -0700, Doug Anderson wrote: > > On Thu, Jun 1, 2023 at 8:40=E2=80=AFAM Uwe Kleine-K=C3=B6nig > > wrote: > > > > > > Hello, > > > > > > On Sun, May 07, 2023 at 06:25:23PM +0200, Uwe Kleine-K=C3=B6nig wrote= : > > > > this patch series adapts the platform drivers below drivers/gpu/drm > > > > to use the .remove_new() callback. Compared to the traditional .rem= ove() > > > > callback .remove_new() returns no value. This is a good thing becau= se > > > > the driver core doesn't (and cannot) cope for errors during remove.= The > > > > only effect of a non-zero return value in .remove() is that the dri= ver > > > > core emits a warning. The device is removed anyhow and an early ret= urn > > > > from .remove() usually yields a resource leak. > > > > > > > > By changing the remove callback to return void driver authors canno= t > > > > reasonably (but wrongly) assume any more that there happens some ki= nd of > > > > cleanup later. > > > > > > I wonder if someone would volunteer to add the whole series to > > > drm-misc-next?! > > > > It looks as if Neil applied quite a few of them already, so I looked > > at what was left... > > > > I'm a little hesitant to just apply the whole kit-and-caboodle to > > drm-misc-next since there are specific DRM trees for a bunch of them > > and it would be better if they landed there. ...so I went through all > > the patches that still applied to drm-misc-next, then used > > 'scripts/get_maintainer.pl --scm' to check if they were maintained > > through drm-misc. That still left quite a few patches. I've applied > > those ones and pushed to drm-misc-next: > > > > 71722685cd17 drm/xlnx/zynqmp_dpsub: Convert to platform remove > > callback returning void > > 1ed54a19f3b3 drm/vc4: Convert to platform remove callback returning voi= d > > b957812839f8 drm/v3d: Convert to platform remove callback returning voi= d > > e2fd3192e267 drm/tve200: Convert to platform remove callback returning = void > > 84e6da7ad553 drm/tiny: Convert to platform remove callback returning vo= id > > 34cdd1f691ad drm/tidss: Convert to platform remove callback returning v= oid > > d665e3c9d37a drm/sun4i: Convert to platform remove callback returning v= oid > > 0c259ab19146 drm/stm: Convert to platform remove callback returning voi= d > > 9a865e45884a drm/sti: Convert to platform remove callback returning voi= d > > 3c855610840e drm/rockchip: Convert to platform remove callback returnin= g void > > e41977a83b71 drm/panfrost: Convert to platform remove callback returnin= g void > > cef3776d0b5a drm/panel: Convert to platform remove callback returning v= oid > > bd296a594e87 drm/mxsfb: Convert to platform remove callback returning v= oid > > 38ca2d93d323 drm/meson: Convert to platform remove callback returning v= oid > > fd1457d84bae drm/mcde: Convert to platform remove callback returning vo= id > > 41a56a18615c drm/logicvc: Convert to platform remove callback returning= void > > 980ec6444372 drm/lima: Convert to platform remove callback returning vo= id > > 82a2c0cc1a22 drm/hisilicon: Convert to platform remove callback returni= ng void > > c3b28b29ac0a drm/fsl-dcu: Convert to platform remove callback returning= void > > a118fc6e71f9 drm/atmel-hlcdc: Convert to platform remove callback retur= ning void > > 9a32dd324c46 drm/aspeed: Convert to platform remove callback returning = void > > 2c7d291c498c drm/arm/malidp: Convert to platform remove callback return= ing void > > a920028df679 drm/arm/hdlcd: Convert to platform remove callback returni= ng void > > 1bf3d76a7d15 drm/komeda: Convert to platform remove callback returning = void > > Together with the patches that were applied later the topmost commit > from this series is c2807ecb5290 ("drm/omap: Convert to platform remove > callback returning void"). This commit was part for the following next > tags: > > $ git tag -l --contains c2807ecb5290 > next-20230609 > next-20230613 > next-20230614 > next-20230615 > > However in next-20230616 they are missing. In next-20230616 > drm-misc/for-linux-next was cf683e8870bd4be0fd6b98639286700a35088660. > Compared to c2807ecb5290 this adds 1149 patches but drops 37 (that are > also not included with a different commit id). The 37 patches dropped > are 13cdd12a9f934158f4ec817cf048fcb4384aa9dc..c2807ecb5290: > > $ git shortlog -s 13cdd12a9f934158f4ec817cf048fcb4384aa9dc..c2807= ecb5290 > 1 Christophe JAILLET > 2 Jessica Zhang > 5 Karol Wachowski > 1 Laura Nao > 27 Uwe Kleine-K=C3=B6nig > 1 Wang Jianzheng > > > I guess this was done by mistake because nobody told me about dropping > my/these patches? Can c2807ecb5290 please be merged into drm-misc-next > again? Actually, it was probably a mistake that these patches got merged to linuxnext during the 4 days that you noticed. However, your patches aren't dropped and are still present in drm-misc-next. drm-misc has a bit of a unique model and it's documented fairly well here: https://drm.pages.freedesktop.org/maintainer-tools/drm-misc.html The key is that committers can commit to drm-misc-next _at any time_ regardless of the merge window. The drm-misc merge strategy makes this OK. Specifically, when it's late in the linux cycle then drm-misc-next is supposed to stop merging to linuxnext. Then, shortly after the merge window closes, patches will start flowing again. So basically your patches are landed and should even keep the same git hashes when they eventually make it to Linux. They just won't land for another release cycle of Linux. Hope that makes sense! -Doug