From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-io1-f54.google.com (mail-io1-f54.google.com [209.85.166.54]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0CC9619930 for ; Thu, 8 Jun 2023 18:05:43 +0000 (UTC) Received: by mail-io1-f54.google.com with SMTP id ca18e2360f4ac-777a9d7efabso45054939f.0 for ; Thu, 08 Jun 2023 11:05:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1686247542; x=1688839542; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=PeA6Fr7MyJEEh+PxA+wsyF1Cp1tipvwi/ySisRbvhVk=; b=QVIb3x4WRDDWBuV5B9/5Y9wcWe6Cw3Z3t2DYjOvxpwaJI2Vhz/qyUsyxII5OFSe2JQ kRJ7GiP3fjIS/w6ZkJkvIcv8OUq5pGLIt1BLCbk67TasRHq0upeXB9Bj3xq77vUmagSE ++JBW2FVFTkKuMy2BCzZz/Tp+NrzYlFG5Rj/g= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1686247542; x=1688839542; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=PeA6Fr7MyJEEh+PxA+wsyF1Cp1tipvwi/ySisRbvhVk=; b=CVVNOZ3KJhXLw2rfVQpTGuxTYcdemfbqiJnATol/LglxR6F3zOny3L94XQhgBJjcbJ he5UHkGB5KxpCfpTmEvyuKpyQf/5aPkO5eJmhAuIzbaKHAY5If04P1sn0eJ2fwr14MGG t4zE7IxDCBS/sfzm9/0ohREA5kn43AGJM0T1c/jJFrU2LdiEVAAk865B4jsb9bGayMzR w2HHEo5kOqej9nXVXE57QKzUbXtUMe1jYUHDacOb2xYEypJBuLLhlTZfEkA3KDUMB9F4 ibGzGaE9zIOePEzr5/GIuqIFdHTMt8j0jxDfMxnR0jyii4FlNxXna+l3BJDGlSq+Wwlm Jw8Q== X-Gm-Message-State: AC+VfDy98UfPWiqCQmLnLpAYPGgvDBgv9enwmKUHPGxDz1GgyL/cpKS3 RN342Vlv94QsxQUZhQyXUQ/jW/rXzVaqt6L1fa1o6A== X-Google-Smtp-Source: ACHHUZ6fIQNB0f54AIx1UBT9Z6yBNTfxh+/B5053KuH8TFpOxqAeKku6uUnag26lVW9x20AWklCYfw== X-Received: by 2002:a5e:c10b:0:b0:76c:5ba7:7ef with SMTP id v11-20020a5ec10b000000b0076c5ba707efmr11803120iol.3.1686247542415; Thu, 08 Jun 2023 11:05:42 -0700 (PDT) Received: from mail-il1-f179.google.com (mail-il1-f179.google.com. [209.85.166.179]) by smtp.gmail.com with ESMTPSA id l17-20020a056638221100b0041f4da30787sm400302jas.167.2023.06.08.11.05.42 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 08 Jun 2023 11:05:42 -0700 (PDT) Received: by mail-il1-f179.google.com with SMTP id e9e14a558f8ab-33d928a268eso154585ab.0 for ; Thu, 08 Jun 2023 11:05:42 -0700 (PDT) X-Received: by 2002:a05:6e02:188a:b0:33e:6b65:6f78 with SMTP id o10-20020a056e02188a00b0033e6b656f78mr167838ilu.27.1686245934574; Thu, 08 Jun 2023 10:38:54 -0700 (PDT) Precedence: bulk X-Mailing-List: linux-sunxi@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 References: <20230507162616.1368908-1-u.kleine-koenig@pengutronix.de> <20230601154002.uv2wfatpb7b45duz@pengutronix.de> <20230608162642.GA23400@pendragon.ideasonboard.com> <2b8ccac8-2828-1279-93aa-a601d8d72e43@ideasonboard.com> In-Reply-To: <2b8ccac8-2828-1279-93aa-a601d8d72e43@ideasonboard.com> From: Doug Anderson Date: Thu, 8 Jun 2023 10:38:41 -0700 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH 00/53] drm: Convert to platform remove callback returning void To: Tomi Valkeinen Cc: Laurent Pinchart , =?UTF-8?Q?Uwe_Kleine=2DK=C3=B6nig?= , Liviu Dudau , Mihail Atanassov , Brian Starkey , David Airlie , Daniel Vetter , Russell King , Joel Stanley , Sam Ravnborg , Boris Brezillon , Nicolas Ferre , Alexandre Belloni , Claudiu Beznea , Andrzej Hajda , Neil Armstrong , Robert Foss , Rahul T R , Jayshri Pawar , Liu Ying , Shawn Guo , Sascha Hauer , Minghao Chi , Mark Brown , Kuninori Morimoto , Lucas Stach , Inki Dae , Seung-Woo Kim , Kyungmin Park , Krzysztof Kozlowski , Jingoo Han , Stefan Agner , Alison Wang , Xinliang Liu , Tian Tao , =?UTF-8?B?VmlsbGUgU3lyasOkbMOk?= , Jani Nikula , Thomas Zimmermann , Danilo Krummrich , Javier Martinez Canillas , Laurentiu Palcu , Philipp Zabel , Paul Cercueil , Anitha Chrisanthus , Qiang Yu , Paul Kocialkowski , Linus Walleij , Chun-Kuang Hu , Matthias Brugger , Kevin Hilman , Rob Clark , Abhinav Kumar , Dmitry Baryshkov , Akhil P Oommen , Ricardo Ribalda , Konrad Dybcio , Johan Hovold , Stephen Boyd , Marijn Suijten , Liu Shixin , Miaoqian Lin , Kuogee Hsieh , Bjorn Andersson , Marek Vasut , Ben Skeggs , Karol Herbst , Lyude Paul , Tomi Valkeinen , Guo Zhengkui , Yuan Can , Arnd Bergmann , Liang He , Thierry Reding , Rob Herring , Kieran Bingham , Sandy Huang , =?UTF-8?Q?Heiko_St=C3=BCbner?= , Orson Zhai , Baolin Wang , Chunyan Zhang , Deepak R Varma , Alex Deucher , Alain Volmat , Yannick Fertre , Raphael Gallais-Pou , Philippe Cornu , Maxime Coquelin , Alexandre Torgue , Maxime Ripard , Chen-Yu Tsai , Jernej Skrabec , Samuel Holland , Jonathan Hunter , Maxime Ripard , =?UTF-8?B?TWHDrXJhIENhbmFs?= , =?UTF-8?Q?Noralf_Tr=C3=B8nnes?= , Jyri Sarha , Alexey Brodkin , Emma Anholt , Melissa Wen , Hyun Kwon , Michal Simek , linux-aspeed@lists.ozlabs.org, nouveau@lists.freedesktop.org, dri-devel@lists.freedesktop.org, John Stultz , Alim Akhtar , Fabio Estevam , Sumit Semwal , Jerome Brunet , linux-samsung-soc@vger.kernel.org, lima@lists.freedesktop.org, Steven Price , linux-rockchip@lists.infradead.org, Xinwei Kong , Mali DP Maintainers , NXP Linux Team , Russell King , linux-sunxi@lists.linux.dev, Jonas Karlman , Martin Blumenstingl , linux-arm-msm@vger.kernel.org, etnaviv@lists.freedesktop.org, Christian Gmeiner , linux-mediatek@lists.infradead.org, linux-tegra@vger.kernel.org, linux-amlogic@lists.infradead.org, Sean Paul , linux-arm-kernel@lists.infradead.org, AngeloGioacchino Del Regno , Andrew Jeffery , linux-stm32@st-md-mailman.stormreply.com, linux-mips@vger.kernel.org, linux-renesas-soc@vger.kernel.org, kernel@pengutronix.de, Yongqin Liu , freedreno@lists.freedesktop.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Hi, On Thu, Jun 8, 2023 at 10:19=E2=80=AFAM Tomi Valkeinen wrote: > > On 08/06/2023 19:26, Laurent Pinchart wrote: > > Hi Doug, > > > > On Thu, Jun 08, 2023 at 09:08:15AM -0700, Doug Anderson wrote: > >> On Thu, Jun 1, 2023 at 8:40=E2=80=AFAM Uwe Kleine-K=C3=B6nig wrote: > >>> On Sun, May 07, 2023 at 06:25:23PM +0200, Uwe Kleine-K=C3=B6nig wrote= : > >>>> this patch series adapts the platform drivers below drivers/gpu/drm > >>>> to use the .remove_new() callback. Compared to the traditional .remo= ve() > >>>> callback .remove_new() returns no value. This is a good thing becaus= e > >>>> the driver core doesn't (and cannot) cope for errors during remove. = The > >>>> only effect of a non-zero return value in .remove() is that the driv= er > >>>> core emits a warning. The device is removed anyhow and an early retu= rn > >>>> from .remove() usually yields a resource leak. > >>>> > >>>> By changing the remove callback to return void driver authors cannot > >>>> reasonably (but wrongly) assume any more that there happens some kin= d of > >>>> cleanup later. > >>> > >>> I wonder if someone would volunteer to add the whole series to > >>> drm-misc-next?! > >> > >> It looks as if Neil applied quite a few of them already, so I looked > >> at what was left... > >> > >> I'm a little hesitant to just apply the whole kit-and-caboodle to > >> drm-misc-next since there are specific DRM trees for a bunch of them > >> and it would be better if they landed there. ...so I went through all > >> the patches that still applied to drm-misc-next, then used > >> 'scripts/get_maintainer.pl --scm' to check if they were maintained > >> through drm-misc. That still left quite a few patches. I've applied > >> those ones and pushed to drm-misc-next: > >> > >> 71722685cd17 drm/xlnx/zynqmp_dpsub: Convert to platform remove > >> callback returning void > >> 1ed54a19f3b3 drm/vc4: Convert to platform remove callback returning vo= id > >> b957812839f8 drm/v3d: Convert to platform remove callback returning vo= id > >> e2fd3192e267 drm/tve200: Convert to platform remove callback returning= void > >> 84e6da7ad553 drm/tiny: Convert to platform remove callback returning v= oid > >> 34cdd1f691ad drm/tidss: Convert to platform remove callback returning = void > >> d665e3c9d37a drm/sun4i: Convert to platform remove callback returning = void > >> 0c259ab19146 drm/stm: Convert to platform remove callback returning vo= id > >> 9a865e45884a drm/sti: Convert to platform remove callback returning vo= id > >> 3c855610840e drm/rockchip: Convert to platform remove callback returni= ng void > >> e41977a83b71 drm/panfrost: Convert to platform remove callback returni= ng void > >> cef3776d0b5a drm/panel: Convert to platform remove callback returning = void > >> bd296a594e87 drm/mxsfb: Convert to platform remove callback returning = void > >> 38ca2d93d323 drm/meson: Convert to platform remove callback returning = void > >> fd1457d84bae drm/mcde: Convert to platform remove callback returning v= oid > >> 41a56a18615c drm/logicvc: Convert to platform remove callback returnin= g void > >> 980ec6444372 drm/lima: Convert to platform remove callback returning v= oid > >> 82a2c0cc1a22 drm/hisilicon: Convert to platform remove callback return= ing void > >> c3b28b29ac0a drm/fsl-dcu: Convert to platform remove callback returnin= g void > >> a118fc6e71f9 drm/atmel-hlcdc: Convert to platform remove callback retu= rning void > >> 9a32dd324c46 drm/aspeed: Convert to platform remove callback returning= void > >> 2c7d291c498c drm/arm/malidp: Convert to platform remove callback retur= ning void > >> a920028df679 drm/arm/hdlcd: Convert to platform remove callback return= ing void > >> 1bf3d76a7d15 drm/komeda: Convert to platform remove callback returning= void > >> > >> The following ones appeared to apply to the top of drm-misc-next, but > >> I didn't apply them since get_maintainer didn't say they were part of > >> drm-misc-next: > >> > >> drm/tiny: Convert to platform remove callback returning void > >> drm/tilcdc: Convert to platform remove callback returning void > >> drm/sprd: Convert to platform remove callback returning void > >> drm/shmobile: Convert to platform remove callback returning void > >> drm/rcar-du: Convert to platform remove callback returning void > > > > If you don't mind, could you take the rcar-du patch through drm-misc to= o > > ? I don't plan to send another pull request for v6.5. > > > >> drm/omap: Convert to platform remove callback returning void > > > > Tomi, should drm/omap moved to being maintained through drm-misc ? > > Yes. tilcdc, tidss and omapdrm are all maintained through drm-misc. tidss was already in my list of applied patches. I've applied the other two and pushed: c2807ecb5290 drm/omap: Convert to platform remove callback returning void e52d1282f919 drm/tilcdc: Convert to platform remove callback returning void > But > I guess I need to add something to the MAINTAINERS to make this clear. > I'll look at it. The key I was looking for was: T: git git://anongit.freedesktop.org/drm/drm-misc -Doug