linux-sunxi.lists.linux.dev archive mirror
 help / color / mirror / Atom feed
From: 班涛 <fengzheng923@gmail.com>
To: Mark Brown <broonie@kernel.org>
Cc: lgirdwood@gmail.com, perex@perex.cz, tiwai@suse.com,
	mripard@kernel.org,  wens@csie.org, jernej.skrabec@gmail.com,
	p.zabel@pengutronix.de,  Samuel Holland <samuel@sholland.org>,
	krzk@kernel.org, linux-kernel@vger.kernel.org,
	 alsa-devel@alsa-project.org,
	linux-arm-kernel@lists.infradead.org,
	 linux-sunxi@lists.linux.dev
Subject: Re: [PATCH 1/2] ASoC: sunxi: Add Allwinner H6 Digital MIC driver
Date: Thu, 17 Jun 2021 20:18:43 +0800	[thread overview]
Message-ID: <CAE=m618zRgqd8vP=ugyZv0RMcENY5ZCmznrFOR6SoovKNpMCag@mail.gmail.com> (raw)
In-Reply-To: <20210617120747.GB5067@sirena.org.uk>

Hi,

Mark Brown <broonie@kernel.org> 于2021年6月17日周四 下午8:08写道：
>
> On Thu, Jun 17, 2021 at 07:50:42PM +0800, 班涛 wrote:
> > Mark Brown <broonie@kernel.org> 于2021年6月17日周四 下午6:48写道：
> > > On Thu, Jun 17, 2021 at 03:42:43PM +0800, 班涛 wrote:
> > > > Mark Brown <broonie@kernel.org> 于2021年6月15日周二 下午9:22写道：
>
> > > No, that's what you have already make the entire thing a C++ comment
> > > with //s.
>
> > I don’t understand. For example, sun4i-codec.c sun4i-i2s.c
> > sun8i-codec.c and sun4i-spdif.c files are the same as mine.
>
> Other people doing a bad job is no excuse for doing a bad job yourself.
>
> > Which file can I refer to? what should I do......
>
> Make every line of the comment start with //.  See soc-core.c

Thanks, I understand, I will fix it in v2.

  reply	other threads:[~2021-06-17 12:18 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-06-15 13:03 [PATCH 1/2] ASoC: sunxi: Add Allwinner H6 Digital MIC driver Ban Tao
2021-06-15 13:18 ` Philipp Zabel
2021-06-15 13:22 ` Mark Brown
2021-06-17  7:42   ` 班涛
2021-06-17 10:48     ` Mark Brown
2021-06-17 11:50       ` 班涛
2021-06-17 12:07         ` Mark Brown
2021-06-17 12:18           ` 班涛 [this message]
2021-06-16  3:06 ` Samuel Holland
     [not found]   ` <CAE=m61_aiPWUvDEcjRTG9+FmMzPTxaL7-n2ZM3r3e7fqg2B1TQ@mail.gmail.com>
2021-06-19 19:52     ` Samuel Holland

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAE=m618zRgqd8vP=ugyZv0RMcENY5ZCmznrFOR6SoovKNpMCag@mail.gmail.com' \
    --to=fengzheng923@gmail.com \
    --cc=alsa-devel@alsa-project.org \
    --cc=broonie@kernel.org \
    --cc=jernej.skrabec@gmail.com \
    --cc=krzk@kernel.org \
    --cc=lgirdwood@gmail.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-sunxi@lists.linux.dev \
    --cc=mripard@kernel.org \
    --cc=p.zabel@pengutronix.de \
    --cc=perex@perex.cz \
    --cc=samuel@sholland.org \
    --cc=tiwai@suse.com \
    --cc=wens@csie.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).