From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ej1-f44.google.com (mail-ej1-f44.google.com [209.85.218.44]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5E30F72; Tue, 6 Jul 2021 10:31:59 +0000 (UTC) Received: by mail-ej1-f44.google.com with SMTP id nd37so33379637ejc.3; Tue, 06 Jul 2021 03:31:59 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:reply-to :from:date:message-id:subject:to:cc:content-transfer-encoding; bh=QFd4cSgjRlNs6aAHRKVeotkaIh4ASKGZEfmqK4rh/rE=; b=p8OIoWMXDZcK3Ozy3qg2MFbLkiM83YCRJgkniRB2u3jp4hPM2dE4yvN2LeJt9K7mJD 0WazN7EXUrrnDJA3AHCvMirnt607Y6x+fDPp/5M3b6FIusHkjQNZAn5niVoJHxMW62gJ i4JLnK/p2D5Orc1gJKahdRnI32kA1HnaGy29w29OaLDQN8eFWzsAcN4n+SwnSG1Y489n 3OJQ5i0OLwSVw5LR5BizeJTmTXYBC2vZy4BpJRU4urlOuRGan4d/uUDlCkGwH5TEMiBy vvbqf6JLRgvhOqN8Y/z115y0HVk9jIsuy95XPeImoE1x2WcynVC9eUpxJQcTnoQRmmcp EgBw== X-Gm-Message-State: AOAM533SUiAkqnpq7oQ+iheDA2tPyH9DRlELBK4rsA4gNes2TWCpzN3k Eoo9MKCVBfgbl3aN0CLHX/5Onw099u7r8ESFXMg= X-Google-Smtp-Source: ABdhPJzpkPJDIroOexYQM/W5yc1EsqHsNbr9rAw37ZDwQaEZ008/KnAbERYhzBTQwZQg8v5BlcoS6g== X-Received: by 2002:a17:906:3cc:: with SMTP id c12mr16751357eja.268.1625567516451; Tue, 06 Jul 2021 03:31:56 -0700 (PDT) Received: from mail-ej1-f46.google.com (mail-ej1-f46.google.com. [209.85.218.46]) by smtp.gmail.com with ESMTPSA id g8sm6967971edv.84.2021.07.06.03.31.56 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 06 Jul 2021 03:31:56 -0700 (PDT) Received: by mail-ej1-f46.google.com with SMTP id o5so33404927ejy.7; Tue, 06 Jul 2021 03:31:56 -0700 (PDT) X-Received: by 2002:a2e:1409:: with SMTP id u9mr9759960ljd.94.1625567102788; Tue, 06 Jul 2021 03:25:02 -0700 (PDT) Precedence: bulk X-Mailing-List: linux-sunxi@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 References: <20210706095037.1425211-1-u.kleine-koenig@pengutronix.de> In-Reply-To: <20210706095037.1425211-1-u.kleine-koenig@pengutronix.de> Reply-To: wens@csie.org From: Chen-Yu Tsai Date: Tue, 6 Jul 2021 18:24:51 +0800 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH] bus: Make remove callback return void To: =?UTF-8?Q?Uwe_Kleine=2DK=C3=B6nig?= Cc: Greg Kroah-Hartman , Sascha Hauer , linux-kernel , Russell King , Thomas Bogendoerfer , "James E.J. Bottomley" , Helge Deller , Geoff Levand , Michael Ellerman , Benjamin Herrenschmidt , Paul Mackerras , "Rafael J. Wysocki" , Len Brown , William Breathitt Gray , =?UTF-8?B?UmFmYcWCIE1pxYJlY2tp?= , Maxime Ripard , Jernej Skrabec , Alison Schofield , Vishal Verma , Ira Weiny , Ben Widawsky , Dan Williams , Dave Jiang , Vinod Koul , Stefan Richter , Sudeep Holla , Cristian Marussi , Wu Hao , Tom Rix , Moritz Fischer , Jiri Kosina , Benjamin Tissoires , Srinivas Pandruvada , "K. Y. Srinivasan" , Haiyang Zhang , Stephen Hemminger , Wei Liu , Dexuan Cui , Alexander Shishkin , Wolfram Sang , Alexandre Belloni , Dmitry Torokhov , Samuel Iglesias Gonsalvez , Jens Taprogge , Johannes Thumshirn , Mauro Carvalho Chehab , Maxim Levitsky , Alex Dubov , Ulf Hansson , Lee Jones , Tomas Winkler , Arnd Bergmann , Jakub Kicinski , "David S. Miller" , Jon Mason , Allen Hubbe , Kishon Vijay Abraham I , Lorenzo Pieralisi , =?UTF-8?Q?Krzysztof_Wilczy=C5=84ski?= , Bjorn Helgaas , Dominik Brodowski , Maximilian Luz , Hans de Goede , Mark Gross , Matt Porter , Alexandre Bounine , Ohad Ben-Cohen , Bjorn Andersson , Mathieu Poirier , "Martin K. Petersen" , Thorsten Scherer , Srinivas Kandagatla , Andy Gross , Mark Brown , Stephen Boyd , Michael Buesch , Sven Van Asbroeck , Johan Hovold , Alex Elder , Andreas Noever , Michael Jamet , Mika Westerberg , Yehezkel Bernat , Rob Herring , Jiri Slaby , Heikki Krogerus , "Michael S. Tsirkin" , Jason Wang , Kirti Wankhede , Alex Williamson , Cornelia Huck , Martyn Welch , Manohar Vanga , Boris Ostrovsky , Juergen Gross , Stefano Stabellini , Johannes Berg , Jaroslav Kysela , Takashi Iwai , Marc Zyngier , Tyrel Datwyler , Vladimir Zapolskiy , Samuel Holland , Qinglang Miao , Alexey Kardashevskiy , Kai-Heng Feng , Joey Pabalan , =?UTF-8?Q?Pali_Roh=C3=A1r?= , Adrian Hunter , Frank Li , Mike Christie , Bodo Stroesser , Hannes Reinecke , David Woodhouse , SeongJae Park , Julien Grall , linux-arm-kernel , linux-mips@vger.kernel.org, linux-parisc@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-acpi@vger.kernel.org, linux-wireless , linux-sunxi@lists.linux.dev, linux-cxl@vger.kernel.org, nvdimm@lists.linux.dev, "open list:DMA GENERIC OFFLOAD ENGINE SUBSYSTEM" , linux1394-devel@lists.sourceforge.net, linux-fpga@vger.kernel.org, linux-input@vger.kernel.org, linux-hyperv@vger.kernel.org, linux-i2c@vger.kernel.org, linux-i3c@lists.infradead.org, industrypack-devel@lists.sourceforge.net, Linux Media Mailing List , linux-mmc , netdev , linux-ntb@googlegroups.com, PCI , platform-driver-x86@vger.kernel.org, linux-remoteproc@vger.kernel.org, linux-scsi@vger.kernel.org, Linux-ALSA , linux-arm-msm , linux-spi@vger.kernel.org, linux-staging@lists.linux.dev, greybus-dev@lists.linaro.org, target-devel@vger.kernel.org, linux-usb , linux-serial@vger.kernel.org, virtualization@lists.linux-foundation.org, kvm@vger.kernel.org, xen-devel@lists.xenproject.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Tue, Jul 6, 2021 at 5:54 PM Uwe Kleine-K=C3=B6nig wrote: > > The driver core ignores the return value of this callback because there > is only little it can do when a device disappears. > > This is the final bit of a long lasting cleanup quest where several > buses were converted to also return void from their remove callback. > Additionally some resource leaks were fixed that were caused by drivers > returning an error code in the expectation that the driver won't go > away. > > With struct bus_type::remove returning void it's prevented that newly > implemented buses return an ignored error code and so don't anticipate > wrong expectations for driver authors. > > Signed-off-by: Uwe Kleine-K=C3=B6nig > --- > Hello, > > this patch depends on "PCI: endpoint: Make struct pci_epf_driver::remove > return void" that is not yet applied, see > https://lore.kernel.org/r/20210223090757.57604-1-u.kleine-koenig@pengutro= nix.de. > > I tested it using allmodconfig on amd64 and arm, but I wouldn't be > surprised if I still missed to convert a driver. So it would be great to > get this into next early after the merge window closes. > > I send this mail to all people that get_maintainer.pl emits for this > patch. I wonder how many recipents will refuse this mail because of the > long Cc: list :-) > > Best regards > Uwe > > drivers/bus/sunxi-rsb.c | 4 +--- Acked-by: Chen-Yu Tsai