From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ej1-f51.google.com (mail-ej1-f51.google.com [209.85.218.51]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A18941117 for ; Sat, 17 Jun 2023 16:58:22 +0000 (UTC) Received: by mail-ej1-f51.google.com with SMTP id a640c23a62f3a-977d55ac17bso297724166b.3 for ; Sat, 17 Jun 2023 09:58:22 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1687021100; x=1689613100; h=content-transfer-encoding:cc:to:subject:message-id:date:from :reply-to:in-reply-to:references:mime-version:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=IIAlmExRE6EbIYR/X1OU/hkRy+rZ5PC7Pr91ssHegm8=; b=dwubeIGdwuKkLzoOvhaWiXEFZrebBGQteVxo91U1Q6w/GM4jqbxMyHJ7t1hYDIy7tO 6hQ/W/0LK3G4gmNTcH7mLl7N0SbQFEQPGjCR/BGrPiUpnLw/+1Fujbhg1AUIhHcg2Eax 24XYStXf/1TtJYOXsdT3WbF+W2J6sXxwMXSyBiMDHB7fKkD3moOF+XEnPC95Qz9NauFW B0Gv4P1Fze1ZTG8dNl75T67GnRhreKTEbC8K08coRrvcAh4cuvYhCtQkgUuSccrCjFl/ 3aWerJsbcbjzQo4IKtCCyp8wf5pAVgEMaod5GbiRoHAuOdOsBZJWLBxEtPfFPdsxNX48 za7g== X-Gm-Message-State: AC+VfDx+nScQn3cGv6SE3NF+ODLM9V7h4WRqS/Tp0NGMXLGHEk9TlkXI gDMfF5iZYoY+gZl1cT/kfChUE2fMDifkq/Fd31w= X-Google-Smtp-Source: ACHHUZ4QUcApoyJHRz1cMJc6SlXzrN/OcpOX0VIn3aLjnsGgC6AVqXzcOXTbPQEyF70UB3lwzevPUA== X-Received: by 2002:a17:907:7287:b0:96a:ff7f:692 with SMTP id dt7-20020a170907728700b0096aff7f0692mr4972521ejc.68.1687021100358; Sat, 17 Jun 2023 09:58:20 -0700 (PDT) Received: from mail-wr1-f51.google.com (mail-wr1-f51.google.com. [209.85.221.51]) by smtp.gmail.com with ESMTPSA id d18-20020a170906371200b0098282bb8effsm4626303ejc.196.2023.06.17.09.58.20 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 17 Jun 2023 09:58:20 -0700 (PDT) Received: by mail-wr1-f51.google.com with SMTP id ffacd0b85a97d-310e6e6a8d4so1343755f8f.2 for ; Sat, 17 Jun 2023 09:58:20 -0700 (PDT) X-Received: by 2002:a2e:9896:0:b0:2ad:8380:770d with SMTP id b22-20020a2e9896000000b002ad8380770dmr3881903ljj.21.1687020704207; Sat, 17 Jun 2023 09:51:44 -0700 (PDT) Precedence: bulk X-Mailing-List: linux-sunxi@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 References: <20230507162616.1368908-1-u.kleine-koenig@pengutronix.de> <20230601154002.uv2wfatpb7b45duz@pengutronix.de> <20230617161222.wy55pbomnrrlfy5u@pengutronix.de> In-Reply-To: <20230617161222.wy55pbomnrrlfy5u@pengutronix.de> Reply-To: wens@csie.org From: Chen-Yu Tsai Date: Sun, 18 Jun 2023 00:51:32 +0800 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: patches dropped from drm-misc-next [Was: Re: [PATCH 00/53] drm: Convert to platform remove callback returning] void To: =?UTF-8?Q?Uwe_Kleine=2DK=C3=B6nig?= Cc: Doug Anderson , =?UTF-8?Q?Heiko_St=C3=BCbner?= , Xinliang Liu , Linus Walleij , dri-devel@lists.freedesktop.org, Russell King , Alim Akhtar , Anitha Chrisanthus , Marijn Suijten , Steven Price , Sumit Semwal , Jerome Brunet , linux-samsung-soc@vger.kernel.org, Robert Foss , Karol Herbst , Samuel Holland , Kevin Hilman , =?UTF-8?B?TWHDrXJhIENhbmFs?= , Javier Martinez Canillas , Kuogee Hsieh , Akhil P Oommen , Danilo Krummrich , NXP Linux Team , Miaoqian Lin , linux-sunxi@lists.linux.dev, Rahul T R , Raphael Gallais-Pou , Jani Nikula , Sascha Hauer , etnaviv@lists.freedesktop.org, Stephen Boyd , Inki Dae , Sean Paul , Johan Hovold , Hyun Kwon , Andrew Jeffery , Jingoo Han , Seung-Woo Kim , =?UTF-8?Q?Noralf_Tr=C3=B8nnes?= , kernel@pengutronix.de, Alex Deucher , freedreno@lists.freedesktop.org, Claudiu Beznea , Alexandre Belloni , linux-aspeed@lists.ozlabs.org, Tomi Valkeinen , Thierry Reding , John Stultz , Mihail Atanassov , Liang He , =?UTF-8?B?VmlsbGUgU3lyasOkbMOk?= , lima@lists.freedesktop.org, Chunyan Zhang , Alexey Brodkin , Minghao Chi , Jonathan Hunter , linux-rockchip@lists.infradead.org, Ben Skeggs , Russell King , Alain Volmat , Liu Ying , linux-arm-msm@vger.kernel.org, Maxime Ripard , linux-amlogic@lists.infradead.org, linux-arm-kernel@lists.infradead.org, Neil Armstrong , Boris Brezillon , Sandy Huang , Paul Kocialkowski , Kyungmin Park , Maxime Coquelin , Brian Starkey , Kuninori Morimoto , Yuan Can , Stefan Agner , Michal Simek , linux-tegra@vger.kernel.org, Laurent Pinchart , Andrzej Hajda , Sam Ravnborg , Rob Herring , Xinwei Kong , Jernej Skrabec , Mali DP Maintainers , Joel Stanley , nouveau@lists.freedesktop.org, Orson Zhai , Chun-Kuang Hu , Lyude Paul , Arnd Bergmann , Guo Zhengkui , Konrad Dybcio , Alison Wang , Abhinav Kumar , Christian Gmeiner , Mark Brown , Maxime Ripard , Baolin Wang , Daniel Vetter , Liu Shixin , Tomi Valkeinen , Deepak R Varma , Kieran Bingham , Ricardo Ribalda , Tian Tao , Shawn Guo , Yannick Fertre , linux-stm32@st-md-mailman.stormreply.com, Emma Anholt , Liviu Dudau , Alexandre Torgue , linux-mips@vger.kernel.org, Paul Cercueil , David Airlie , Marek Vasut , linux-renesas-soc@vger.kernel.org, Yongqin Liu , Jayshri Pawar , Jonas Karlman , Rob Clark , Martin Blumenstingl , Philippe Cornu , Thomas Zimmermann , Melissa Wen , linux-mediatek@lists.infradead.org, Fabio Estevam , Laurentiu Palcu , Matthias Brugger , AngeloGioacchino Del Regno , Bjorn Andersson , Nicolas Ferre , Krzysztof Kozlowski , Qiang Yu , Philipp Zabel , Dmitry Baryshkov , Jyri Sarha , Lucas Stach , Christophe JAILLET , Jessica Zhang , Karol Wachowski , Laura Nao , Wang Jianzheng , Raymond Tan , Stanislaw Gruszka Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Sun, Jun 18, 2023 at 12:13=E2=80=AFAM Uwe Kleine-K=C3=B6nig wrote: > > [expanding recipents by the other affected persons] > > On Thu, Jun 08, 2023 at 09:08:15AM -0700, Doug Anderson wrote: > > On Thu, Jun 1, 2023 at 8:40=E2=80=AFAM Uwe Kleine-K=C3=B6nig > > wrote: > > > > > > Hello, > > > > > > On Sun, May 07, 2023 at 06:25:23PM +0200, Uwe Kleine-K=C3=B6nig wrote= : > > > > this patch series adapts the platform drivers below drivers/gpu/drm > > > > to use the .remove_new() callback. Compared to the traditional .rem= ove() > > > > callback .remove_new() returns no value. This is a good thing becau= se > > > > the driver core doesn't (and cannot) cope for errors during remove.= The > > > > only effect of a non-zero return value in .remove() is that the dri= ver > > > > core emits a warning. The device is removed anyhow and an early ret= urn > > > > from .remove() usually yields a resource leak. > > > > > > > > By changing the remove callback to return void driver authors canno= t > > > > reasonably (but wrongly) assume any more that there happens some ki= nd of > > > > cleanup later. > > > > > > I wonder if someone would volunteer to add the whole series to > > > drm-misc-next?! > > > > It looks as if Neil applied quite a few of them already, so I looked > > at what was left... > > > > I'm a little hesitant to just apply the whole kit-and-caboodle to > > drm-misc-next since there are specific DRM trees for a bunch of them > > and it would be better if they landed there. ...so I went through all > > the patches that still applied to drm-misc-next, then used > > 'scripts/get_maintainer.pl --scm' to check if they were maintained > > through drm-misc. That still left quite a few patches. I've applied > > those ones and pushed to drm-misc-next: > > > > 71722685cd17 drm/xlnx/zynqmp_dpsub: Convert to platform remove > > callback returning void > > 1ed54a19f3b3 drm/vc4: Convert to platform remove callback returning voi= d > > b957812839f8 drm/v3d: Convert to platform remove callback returning voi= d > > e2fd3192e267 drm/tve200: Convert to platform remove callback returning = void > > 84e6da7ad553 drm/tiny: Convert to platform remove callback returning vo= id > > 34cdd1f691ad drm/tidss: Convert to platform remove callback returning v= oid > > d665e3c9d37a drm/sun4i: Convert to platform remove callback returning v= oid > > 0c259ab19146 drm/stm: Convert to platform remove callback returning voi= d > > 9a865e45884a drm/sti: Convert to platform remove callback returning voi= d > > 3c855610840e drm/rockchip: Convert to platform remove callback returnin= g void > > e41977a83b71 drm/panfrost: Convert to platform remove callback returnin= g void > > cef3776d0b5a drm/panel: Convert to platform remove callback returning v= oid > > bd296a594e87 drm/mxsfb: Convert to platform remove callback returning v= oid > > 38ca2d93d323 drm/meson: Convert to platform remove callback returning v= oid > > fd1457d84bae drm/mcde: Convert to platform remove callback returning vo= id > > 41a56a18615c drm/logicvc: Convert to platform remove callback returning= void > > 980ec6444372 drm/lima: Convert to platform remove callback returning vo= id > > 82a2c0cc1a22 drm/hisilicon: Convert to platform remove callback returni= ng void > > c3b28b29ac0a drm/fsl-dcu: Convert to platform remove callback returning= void > > a118fc6e71f9 drm/atmel-hlcdc: Convert to platform remove callback retur= ning void > > 9a32dd324c46 drm/aspeed: Convert to platform remove callback returning = void > > 2c7d291c498c drm/arm/malidp: Convert to platform remove callback return= ing void > > a920028df679 drm/arm/hdlcd: Convert to platform remove callback returni= ng void > > 1bf3d76a7d15 drm/komeda: Convert to platform remove callback returning = void > > Together with the patches that were applied later the topmost commit > from this series is c2807ecb5290 ("drm/omap: Convert to platform remove > callback returning void"). This commit was part for the following next > tags: > > $ git tag -l --contains c2807ecb5290 > next-20230609 > next-20230613 > next-20230614 > next-20230615 > > However in next-20230616 they are missing. In next-20230616 > drm-misc/for-linux-next was cf683e8870bd4be0fd6b98639286700a35088660. > Compared to c2807ecb5290 this adds 1149 patches but drops 37 (that are > also not included with a different commit id). The 37 patches dropped > are 13cdd12a9f934158f4ec817cf048fcb4384aa9dc..c2807ecb5290: > > $ git shortlog -s 13cdd12a9f934158f4ec817cf048fcb4384aa9dc..c2807= ecb5290 > 1 Christophe JAILLET > 2 Jessica Zhang > 5 Karol Wachowski > 1 Laura Nao > 27 Uwe Kleine-K=C3=B6nig > 1 Wang Jianzheng > > > I guess this was done by mistake because nobody told me about dropping > my/these patches? Can c2807ecb5290 please be merged into drm-misc-next > again? AFAIK drm-misc/for-linux-next cuts off at -rc6, at which point any patches merged get queued up for -next-next. I think that's what happened to your patches? ChenYu