From: Simon Glass <sjg@chromium.org>
To: Andre Przywara <andre.przywara@arm.com>
Cc: Jagan Teki <jagan@amarulasolutions.com>,
Samuel Holland <samuel@sholland.org>,
Jernej Skrabec <jernej.skrabec@gmail.com>,
Icenowy Zheng <icenowy@aosc.io>,
Sunil Mohan Adapa <sunil@medhas.org>,
linux-sunxi@lists.linux.dev,
U-Boot Mailing List <u-boot@lists.denx.de>,
Stefano Babic <sbabic@denx.de>,
Fabio Estevam <festevam@gmail.com>,
"NXP i . MX U-Boot Team" <uboot-imx@nxp.com>,
Lokesh Vutla <lokeshvutla@ti.com>,
Philipp Tomsich <philipp.tomsich@vrull.eu>,
Kever Yang <kever.yang@rock-chips.com>,
Marek Vasut <marex@denx.de>,
Simon Goldschmidt <simon.k.r.goldschmidt@gmail.com>,
Ley Foon Tan <lftan.linux@gmail.com>,
Patrick Delaunay <patrick.delaunay@foss.st.com>,
Patrice Chotard <patrice.chotard@foss.st.com>
Subject: Re: [RESEND PATCH v2 1/3] spl: mmc: extend spl_mmc_boot_mode() to take mmc argument
Date: Tue, 20 Jul 2021 12:32:53 -0600 [thread overview]
Message-ID: <CAPnjgZ1qhkxrQ-2jm3A8b4wtZMJe5YH-KtBxp10FK_mxc6YWtg@mail.gmail.com> (raw)
In-Reply-To: <20210712100651.6912-2-andre.przywara@arm.com>
Hi Andre,
On Mon, 12 Jul 2021 at 04:07, Andre Przywara <andre.przywara@arm.com> wrote:
>
> Platforms can overwrite the weak definition of spl_mmc_boot_mode() to
> determine where to load U-Boot proper from.
> For most of them this is a trivial decision based on Kconfig variables,
> but it might be desirable the probe the actual device to answer this
> question.
>
> Pass the pointer to the mmc struct to that function, so implementations
> can make use of that.
>
> Compile-tested for all users changed.
>
> Signed-off-by: Andre Przywara <andre.przywara@arm.com>
> Reviewed-by: Stefano Babic <sbabic@denx.de>
> Reviewed-by: Ley Foon Tan <ley.foon.tan@inte.com> (for SoCFPGA)
> Acked-by: Lokesh Vutla <lokeshvutla@ti.com> (for OMAP and K3)
> ---
> (resent to also include forgotten U-Boot list)
>
> arch/arm/mach-imx/spl.c | 2 +-
> arch/arm/mach-k3/am6_init.c | 2 +-
> arch/arm/mach-k3/j721e_init.c | 2 +-
> arch/arm/mach-omap2/boot-common.c | 2 +-
> arch/arm/mach-rockchip/spl.c | 2 +-
> arch/arm/mach-socfpga/spl_a10.c | 2 +-
> arch/arm/mach-socfpga/spl_gen5.c | 2 +-
> arch/arm/mach-stm32mp/spl.c | 2 +-
> arch/arm/mach-uniphier/mmc-boot-mode.c | 5 +----
> common/spl/spl_mmc.c | 4 ++--
> include/spl.h | 3 ++-
> 11 files changed, 13 insertions(+), 15 deletions(-)
Reviewed-by: Simon Glass <sjg@chromium.org>
But I think this should come from a sysinfo driver.
Regards,
Simon
next prev parent reply other threads:[~2021-07-20 18:33 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-12 10:06 [RESEND PATCH v2 0/3] sunxi: Improve automatic eMMC boot partition support Andre Przywara
2021-07-12 10:06 ` [RESEND PATCH v2 1/3] spl: mmc: extend spl_mmc_boot_mode() to take mmc argument Andre Przywara
2021-07-20 18:32 ` Simon Glass [this message]
2021-07-12 10:06 ` [RESEND PATCH v2 2/3] sunxi: eMMC: Improve automatic boot source detection Andre Przywara
2021-07-12 10:57 ` Jaehoon Chung
2021-07-12 11:53 ` Andre Przywara
2021-07-12 10:06 ` [RESEND PATCH v2 3/3] sunxi: defconfig: enable eMMC boot partition support Andre Przywara
2022-04-05 22:59 ` [RESEND PATCH v2 0/3] sunxi: Improve automatic " Andre Przywara
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAPnjgZ1qhkxrQ-2jm3A8b4wtZMJe5YH-KtBxp10FK_mxc6YWtg@mail.gmail.com \
--to=sjg@chromium.org \
--cc=andre.przywara@arm.com \
--cc=festevam@gmail.com \
--cc=icenowy@aosc.io \
--cc=jagan@amarulasolutions.com \
--cc=jernej.skrabec@gmail.com \
--cc=kever.yang@rock-chips.com \
--cc=lftan.linux@gmail.com \
--cc=linux-sunxi@lists.linux.dev \
--cc=lokeshvutla@ti.com \
--cc=marex@denx.de \
--cc=patrice.chotard@foss.st.com \
--cc=patrick.delaunay@foss.st.com \
--cc=philipp.tomsich@vrull.eu \
--cc=samuel@sholland.org \
--cc=sbabic@denx.de \
--cc=simon.k.r.goldschmidt@gmail.com \
--cc=sunil@medhas.org \
--cc=u-boot@lists.denx.de \
--cc=uboot-imx@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).