linux-sunxi.lists.linux.dev archive mirror
 help / color / mirror / Atom feed
From: Simon Glass <sjg@chromium.org>
To: Icenowy Zheng <icenowy@aosc.io>
Cc: Andre Przywara <andre.przywara@arm.com>,
	Jagan Teki <jagan@amarulasolutions.com>,
	 Samuel Holland <samuel@sholland.org>,
	U-Boot Mailing List <u-boot@lists.denx.de>,
	linux-sunxi@lists.linux.dev
Subject: Re: [RFC PATCH 1/4] mkimage: add a flag to describe whether -A is specified
Date: Sat, 26 Jun 2021 12:31:48 -0600	[thread overview]
Message-ID: <CAPnjgZ3FzF714HWWw2Ay8b5HnPPx82cf8piAVc3pU7eFe=LH=A@mail.gmail.com> (raw)
In-Reply-To: <20210617184621.4083311-2-icenowy@aosc.io>

Hi Icenowy,

On Thu, 17 Jun 2021 at 12:47, Icenowy Zheng <icenowy@aosc.io> wrote:
>
> The sunxi_egon type used to take no -A argument (because we assume sunxi
> targets are all ARM). However, as Allwinner D1 appears as the first
> RISC-V sunxi target, we need to support -A; in addition, as external
> projects rely on U-Boot mkimage to generate sunxi eGON.BT0 header, we
> need to keep compatibility with command line without -A.
>
> As the default value of arch in mkimage is not proper (IH_ARCH_PPC
> instead of IH_ARCH_INVALID), to keep more compatibility, add an Aflag
> field to image parameters to describe whether an architecture is
> explicitly specified.
>
> Signed-off-by: Icenowy Zheng <icenowy@aosc.io>
> ---
>  tools/imagetool.h | 1 +
>  tools/mkimage.c   | 1 +
>  2 files changed, 2 insertions(+)
>
> diff --git a/tools/imagetool.h b/tools/imagetool.h
> index e229a34ffc..5dc28312c2 100644
> --- a/tools/imagetool.h
> +++ b/tools/imagetool.h
> @@ -51,6 +51,7 @@ struct image_tool_params {
>         int pflag;
>         int vflag;
>         int xflag;
> +       int Aflag;

aflag

>         int skipcpy;
>         int os;
>         int arch;
> diff --git a/tools/mkimage.c b/tools/mkimage.c
> index cc7b242faf..54d8e3835a 100644
> --- a/tools/mkimage.c
> +++ b/tools/mkimage.c
> @@ -168,6 +168,7 @@ static void process_args(int argc, char **argv)
>                                 show_valid_options(IH_ARCH);
>                                 usage("Invalid architecture");
>                         }
> +                       params.Aflag = 1;
>                         break;
>                 case 'b':
>                         if (add_content(IH_TYPE_FLATDT, optarg)) {
> --
> 2.30.2

Regards,
Simon

  parent reply	other threads:[~2021-06-26 18:32 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-06-17 18:46 [RFC PATCH 0/4] mkimage: sunxi_egon: add riscv support Icenowy Zheng
2021-06-17 18:46 ` [RFC PATCH 1/4] mkimage: add a flag to describe whether -A is specified Icenowy Zheng
2021-06-18 16:38   ` Tom Rini
2021-06-26 18:31   ` Simon Glass [this message]
2021-06-17 18:47 ` [RFC PATCH 2/4] mkimage: sunxi_egon: refactor for multi-architecture support Icenowy Zheng
2021-06-18 16:38   ` Tom Rini
2021-06-17 18:47 ` [RFC PATCH 3/4] mkimage: sunxi_egon: add support for riscv Icenowy Zheng
2021-06-17 18:48 ` [RFC PATCH 4/4] sunxi: specify architecture when generating SPL boot image Icenowy Zheng

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAPnjgZ3FzF714HWWw2Ay8b5HnPPx82cf8piAVc3pU7eFe=LH=A@mail.gmail.com' \
    --to=sjg@chromium.org \
    --cc=andre.przywara@arm.com \
    --cc=icenowy@aosc.io \
    --cc=jagan@amarulasolutions.com \
    --cc=linux-sunxi@lists.linux.dev \
    --cc=samuel@sholland.org \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).