From: Paul Kocialkowski <paul.kocialkowski@bootlin.com>
To: linux-kernel@vger.kernel.org, linux-media@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-sunxi@lists.linux.dev
Cc: Yong Deng <yong.deng@magewell.com>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
Chen-Yu Tsai <wens@csie.org>,
Jernej Skrabec <jernej.skrabec@gmail.com>,
Samuel Holland <samuel@sholland.org>,
Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
Maxime Ripard <mripard@kernel.org>,
Thomas Petazzoni <thomas.petazzoni@bootlin.com>
Subject: Re: [PATCH v6 00/43] Allwinner A31/A83T MIPI CSI-2 and A31 ISP / CSI Rework
Date: Fri, 21 Oct 2022 16:13:14 +0200 [thread overview]
Message-ID: <Y1Ko+rNREvM2QClC@aptenodytes> (raw)
In-Reply-To: <20220826183240.604834-1-paul.kocialkowski@bootlin.com>
[-- Attachment #1: Type: text/plain, Size: 6376 bytes --]
Hi everyone,
On Fri 26 Aug 22, 20:31, Paul Kocialkowski wrote:
> This part only concerns the rework of the CSI driver to support the MIPI CSI-2
> and ISP workflows.
>
> Very few patches have not received any review at this point and the whole
> thing looks good to go. Since this multi-part series has been going on for a
> while, it would be great to see it merged soon!
Could this series be considered for merging soon? It would be great to see it
in Linux 6.2.
A few patches are still in need of review but I don't think anything
stands in the way at this point.
Thanks in advance,
Paul
> Changes since v5:
> - Rebased on latest media tree;
> - Switched to using media_pad_remote_pad_first;
> - Switched to using media_pad_remote_pad_unique.
>
> Changes since v4:
> - Removed the v4l2 controls handler from the driver;
> - Removed the info message about video device registration;
> - Fixed "literature" typos;
> - Moved patches dependent on the ISP driver to its dedicated series;
> - Rebased on the latest media tree;
> - Added collected tags;
>
> Changes since v3:
> - Updated Kconfig to follow the latest media-wide changes;
> - Rebased on latest changes to the driver (JPEG/sRGB colorspaces);
> - Added helper to get a single enabled link for an entity's pad, to replace
> source selection at link_validate time and select the remote source at
> stream on time instead;
> - Kept clock-managed regmap mmio;
> - Added collected review tags;
> - Various cosmetic cleanups;
>
> Changes since all-in-one v2:
> - Reworked capture video device registration, which stays in the main path.
> - Reworked async subdev handling with a dedicated structure holding the
> corresponding source to avoid matching in the driver;
> - Added mutex for mbus format serialization;
> - Remove useless else in link_validate;
> - Reworked commit logs to include missing information;
> - Cleaned up Kconfig, added PM dependency;
> - Moved platform-specific clock rate to of match data;
> - Added collected Reviewed-by tags;
> - Updated copyright years;
>
> Paul Kocialkowski (43):
> media: sun6i-csi: Define and use driver name and (reworked)
> description
> media: sun6i-csi: Refactor main driver data structures
> media: sun6i-csi: Tidy up platform code
> media: sun6i-csi: Always set exclusive module clock rate
> media: sun6i-csi: Define and use variant to get module clock rate
> media: sun6i-csi: Use runtime pm for clocks and reset
> media: sun6i-csi: Tidy up Kconfig
> media: sun6i-csi: Tidy up v4l2 code
> media: sun6i-csi: Tidy up video code
> media: sun6i-csi: Pass and store csi device directly in video code
> media: sun6i-csi: Register the media device after creation
> media: sun6i-csi: Remove controls handler from the driver
> media: sun6i-csi: Add media ops with link notify callback
> media: sun6i-csi: Introduce and use video helper functions
> media: sun6i-csi: Move csi buffer definition to main header file
> media: sun6i-csi: Add bridge v4l2 subdev with port management
> media: sun6i-csi: Rename sun6i_video to sun6i_csi_capture
> media: sun6i-csi: Add capture state using vsync for page flip
> media: sun6i-csi: Rework register definitions, invert misleading
> fields
> media: sun6i-csi: Add dimensions and format helpers to capture
> media: sun6i-csi: Implement address configuration without indirection
> media: sun6i-csi: Split stream sequences and irq code in capture
> media: sun6i-csi: Move power management to runtime pm in capture
> media: sun6i-csi: Move register configuration to capture
> media: sun6i-csi: Rework capture format management with helper
> media: sun6i-csi: Remove custom format helper and rework configure
> media: sun6i-csi: Add bridge dimensions and format helpers
> media: sun6i-csi: Get mbus code from bridge instead of storing it
> media: sun6i-csi: Tidy capture configure code
> media: sun6i-csi: Introduce bridge format structure, list and helper
> media: sun6i-csi: Introduce capture format structure, list and helper
> media: sun6i-csi: Configure registers from format tables
> media: sun6i-csi: Introduce format match structure, list and helper
> media: sun6i-csi: Implement capture link validation with logic
> media: sun6i-csi: Get bridge subdev directly in capture stream ops
> media: sun6i-csi: Move hardware control to the bridge
> media: sun6i-csi: Rename the capture video device to sun6i-csi-capture
> media: sun6i-csi: Cleanup headers and includes, update copyright lines
> media: sun6i-csi: Add support for MIPI CSI-2 to the bridge code
> media: sun6i-csi: Only configure capture when streaming
> media: sun6i-csi: Add extra checks to the interrupt routine
> media: sun6i-csi: Request a shared interrupt
> MAINTAINERS: Add myself as sun6i-csi maintainer and rename/move entry
>
> MAINTAINERS | 17 +-
> .../media/platform/sunxi/sun6i-csi/Kconfig | 12 +-
> .../media/platform/sunxi/sun6i-csi/Makefile | 2 +-
> .../platform/sunxi/sun6i-csi/sun6i_csi.c | 1027 ++++------------
> .../platform/sunxi/sun6i-csi/sun6i_csi.h | 149 +--
> .../sunxi/sun6i-csi/sun6i_csi_bridge.c | 844 +++++++++++++
> .../sunxi/sun6i-csi/sun6i_csi_bridge.h | 69 ++
> .../sunxi/sun6i-csi/sun6i_csi_capture.c | 1089 +++++++++++++++++
> .../sunxi/sun6i-csi/sun6i_csi_capture.h | 88 ++
> .../platform/sunxi/sun6i-csi/sun6i_csi_reg.h | 362 +++---
> .../platform/sunxi/sun6i-csi/sun6i_video.c | 685 -----------
> .../platform/sunxi/sun6i-csi/sun6i_video.h | 38 -
> 12 files changed, 2551 insertions(+), 1831 deletions(-)
> create mode 100644 drivers/media/platform/sunxi/sun6i-csi/sun6i_csi_bridge.c
> create mode 100644 drivers/media/platform/sunxi/sun6i-csi/sun6i_csi_bridge.h
> create mode 100644 drivers/media/platform/sunxi/sun6i-csi/sun6i_csi_capture.c
> create mode 100644 drivers/media/platform/sunxi/sun6i-csi/sun6i_csi_capture.h
> delete mode 100644 drivers/media/platform/sunxi/sun6i-csi/sun6i_video.c
> delete mode 100644 drivers/media/platform/sunxi/sun6i-csi/sun6i_video.h
>
> --
> 2.37.1
>
--
Paul Kocialkowski, Bootlin
Embedded Linux and kernel engineering
https://bootlin.com
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2022-10-21 14:13 UTC|newest]
Thread overview: 52+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-26 18:31 [PATCH v6 00/43] Allwinner A31/A83T MIPI CSI-2 and A31 ISP / CSI Rework Paul Kocialkowski
2022-08-26 18:31 ` [PATCH v6 01/43] media: sun6i-csi: Define and use driver name and (reworked) description Paul Kocialkowski
2022-08-26 18:31 ` [PATCH v6 02/43] media: sun6i-csi: Refactor main driver data structures Paul Kocialkowski
2022-08-26 18:32 ` [PATCH v6 03/43] media: sun6i-csi: Tidy up platform code Paul Kocialkowski
2022-08-26 18:32 ` [PATCH v6 04/43] media: sun6i-csi: Always set exclusive module clock rate Paul Kocialkowski
2022-08-26 18:32 ` [PATCH v6 05/43] media: sun6i-csi: Define and use variant to get " Paul Kocialkowski
2022-08-26 18:32 ` [PATCH v6 06/43] media: sun6i-csi: Use runtime pm for clocks and reset Paul Kocialkowski
2022-08-26 18:32 ` [PATCH v6 07/43] media: sun6i-csi: Tidy up Kconfig Paul Kocialkowski
2022-08-26 18:32 ` [PATCH v6 08/43] media: sun6i-csi: Tidy up v4l2 code Paul Kocialkowski
2022-08-26 18:32 ` [PATCH v6 09/43] media: sun6i-csi: Tidy up video code Paul Kocialkowski
2022-08-26 18:32 ` [PATCH v6 10/43] media: sun6i-csi: Pass and store csi device directly in " Paul Kocialkowski
2022-08-26 18:32 ` [PATCH v6 11/43] media: sun6i-csi: Register the media device after creation Paul Kocialkowski
2022-08-26 18:32 ` [PATCH v6 12/43] media: sun6i-csi: Remove controls handler from the driver Paul Kocialkowski
2022-10-31 9:06 ` Jernej Škrabec
2022-08-26 18:32 ` [PATCH v6 13/43] media: sun6i-csi: Add media ops with link notify callback Paul Kocialkowski
2022-08-26 18:32 ` [PATCH v6 14/43] media: sun6i-csi: Introduce and use video helper functions Paul Kocialkowski
2022-08-26 18:32 ` [PATCH v6 15/43] media: sun6i-csi: Move csi buffer definition to main header file Paul Kocialkowski
2022-08-26 18:32 ` [PATCH v6 16/43] media: sun6i-csi: Add bridge v4l2 subdev with port management Paul Kocialkowski
2022-10-31 9:10 ` Jernej Škrabec
2022-08-26 18:32 ` [PATCH v6 17/43] media: sun6i-csi: Rename sun6i_video to sun6i_csi_capture Paul Kocialkowski
2022-08-26 18:32 ` [PATCH v6 18/43] media: sun6i-csi: Add capture state using vsync for page flip Paul Kocialkowski
2022-10-31 9:15 ` Jernej Škrabec
2022-08-26 18:32 ` [PATCH v6 19/43] media: sun6i-csi: Rework register definitions, invert misleading fields Paul Kocialkowski
2022-08-26 18:32 ` [PATCH v6 20/43] media: sun6i-csi: Add dimensions and format helpers to capture Paul Kocialkowski
2022-08-26 18:32 ` [PATCH v6 21/43] media: sun6i-csi: Implement address configuration without indirection Paul Kocialkowski
2022-08-26 18:32 ` [PATCH v6 22/43] media: sun6i-csi: Split stream sequences and irq code in capture Paul Kocialkowski
2022-08-26 18:32 ` [PATCH v6 23/43] media: sun6i-csi: Move power management to runtime pm " Paul Kocialkowski
2022-08-26 18:32 ` [PATCH v6 24/43] media: sun6i-csi: Move register configuration to capture Paul Kocialkowski
2022-08-26 18:32 ` [PATCH v6 25/43] media: sun6i-csi: Rework capture format management with helper Paul Kocialkowski
2022-08-26 18:32 ` [PATCH v6 26/43] media: sun6i-csi: Remove custom format helper and rework configure Paul Kocialkowski
2022-08-26 18:32 ` [PATCH v6 27/43] media: sun6i-csi: Add bridge dimensions and format helpers Paul Kocialkowski
2022-08-26 18:32 ` [PATCH v6 28/43] media: sun6i-csi: Get mbus code from bridge instead of storing it Paul Kocialkowski
2022-08-26 18:32 ` [PATCH v6 29/43] media: sun6i-csi: Tidy capture configure code Paul Kocialkowski
2022-08-26 18:32 ` [PATCH v6 30/43] media: sun6i-csi: Introduce bridge format structure, list and helper Paul Kocialkowski
2022-08-26 18:32 ` [PATCH v6 31/43] media: sun6i-csi: Introduce capture " Paul Kocialkowski
2022-08-26 18:32 ` [PATCH v6 32/43] media: sun6i-csi: Configure registers from format tables Paul Kocialkowski
2022-08-26 18:32 ` [PATCH v6 33/43] media: sun6i-csi: Introduce format match structure, list and helper Paul Kocialkowski
2022-08-26 18:32 ` [PATCH v6 34/43] media: sun6i-csi: Implement capture link validation with logic Paul Kocialkowski
2022-08-26 18:32 ` [PATCH v6 35/43] media: sun6i-csi: Get bridge subdev directly in capture stream ops Paul Kocialkowski
2022-08-26 18:32 ` [PATCH v6 36/43] media: sun6i-csi: Move hardware control to the bridge Paul Kocialkowski
2022-10-31 9:18 ` Jernej Škrabec
2022-08-26 18:32 ` [PATCH v6 37/43] media: sun6i-csi: Rename the capture video device to sun6i-csi-capture Paul Kocialkowski
2022-08-26 18:32 ` [PATCH v6 38/43] media: sun6i-csi: Cleanup headers and includes, update copyright lines Paul Kocialkowski
2022-08-26 18:32 ` [PATCH v6 39/43] media: sun6i-csi: Add support for MIPI CSI-2 to the bridge code Paul Kocialkowski
2022-08-26 18:32 ` [PATCH v6 40/43] media: sun6i-csi: Only configure capture when streaming Paul Kocialkowski
2022-08-26 18:32 ` [PATCH v6 41/43] media: sun6i-csi: Add extra checks to the interrupt routine Paul Kocialkowski
2022-08-26 18:32 ` [PATCH v6 42/43] media: sun6i-csi: Request a shared interrupt Paul Kocialkowski
2022-08-26 18:32 ` [PATCH v6 43/43] MAINTAINERS: Add myself as sun6i-csi maintainer and rename/move entry Paul Kocialkowski
2022-09-07 8:47 ` [PATCH v6 00/43] Allwinner A31/A83T MIPI CSI-2 and A31 ISP / CSI Rework Hans Verkuil
2022-09-07 10:03 ` Paul Kocialkowski
2022-10-21 14:13 ` Paul Kocialkowski [this message]
2022-10-31 9:21 ` Sakari Ailus
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y1Ko+rNREvM2QClC@aptenodytes \
--to=paul.kocialkowski@bootlin.com \
--cc=jernej.skrabec@gmail.com \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-sunxi@lists.linux.dev \
--cc=mchehab@kernel.org \
--cc=mripard@kernel.org \
--cc=samuel@sholland.org \
--cc=thomas.petazzoni@bootlin.com \
--cc=wens@csie.org \
--cc=yong.deng@magewell.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).