From: Corentin Labbe <clabbe.montjoie@gmail.com>
To: Samuel Holland <samuel@sholland.org>
Cc: Herbert Xu <herbert@gondor.apana.org.au>,
"David S . Miller" <davem@davemloft.net>,
Chen-Yu Tsai <wens@csie.org>,
Jernej Skrabec <jernej.skrabec@gmail.com>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Rob Herring <robh+dt@kernel.org>,
Albert Ou <aou@eecs.berkeley.edu>,
Conor Dooley <conor@kernel.org>,
Palmer Dabbelt <palmer@dabbelt.com>,
Paul Walmsley <paul.walmsley@sifive.com>,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-riscv@lists.infradead.org, linux-sunxi@lists.linux.dev
Subject: Re: [PATCH v2 2/3] crypto: sun8i-ce - Add TRNG clock to the D1 variant
Date: Fri, 6 Jan 2023 09:18:24 +0100 [thread overview]
Message-ID: <Y7fZUDSWaZhpL0hc@Red> (raw)
In-Reply-To: <20221231220146.646-3-samuel@sholland.org>
Le Sat, Dec 31, 2022 at 04:01:44PM -0600, Samuel Holland a écrit :
> At least the D1 variant requires a separate clock for the TRNG.
> Without this clock enabled, reading from /dev/hwrng reports:
>
> sun8i-ce 3040000.crypto: DMA timeout for TRNG (tm=96) on flow 3
>
> Experimentation shows that the necessary clock is the SoC's internal
> RC oscillator. This makes sense, as noise from the oscillator can be
> used as a source of entropy.
>
> Signed-off-by: Samuel Holland <samuel@sholland.org>
> ---
>
Acked-by: Corentin Labbe <clabbe.montjoie@gmail.com>
Thanks
next prev parent reply other threads:[~2023-01-06 8:18 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-31 22:01 [PATCH v2 0/3] crypto: Allwinner D1 crypto support Samuel Holland
2022-12-31 22:01 ` [PATCH v2 1/3] dt-bindings: crypto: sun8i-ce: Add compatible for D1 Samuel Holland
2023-01-01 15:57 ` Krzysztof Kozlowski
2023-01-06 8:20 ` Corentin Labbe
2023-01-13 3:51 ` Herbert Xu
2023-01-13 8:33 ` Krzysztof Kozlowski
2023-01-13 8:37 ` Herbert Xu
2022-12-31 22:01 ` [PATCH v2 2/3] crypto: sun8i-ce - Add TRNG clock to the D1 variant Samuel Holland
2023-01-05 16:29 ` Jernej Škrabec
2023-01-06 8:18 ` Corentin Labbe [this message]
2022-12-31 22:01 ` [PATCH v2 3/3] riscv: dts: allwinner: d1: Add crypto engine node Samuel Holland
2023-01-05 16:30 ` Jernej Škrabec
2023-03-07 20:55 ` Palmer Dabbelt
2023-03-14 20:35 ` Jernej Škrabec
2023-01-13 8:40 ` [PATCH v2 0/3] crypto: Allwinner D1 crypto support Herbert Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y7fZUDSWaZhpL0hc@Red \
--to=clabbe.montjoie@gmail.com \
--cc=aou@eecs.berkeley.edu \
--cc=conor@kernel.org \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=herbert@gondor.apana.org.au \
--cc=jernej.skrabec@gmail.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=linux-sunxi@lists.linux.dev \
--cc=palmer@dabbelt.com \
--cc=paul.walmsley@sifive.com \
--cc=robh+dt@kernel.org \
--cc=samuel@sholland.org \
--cc=wens@csie.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).