From: Alexandre Belloni <alexandre.belloni@bootlin.com>
To: Roman Beranek <roman.beranek@prusa3d.cz>
Cc: "Thierry Reding" <thierry.reding@gmail.com>,
"Emil Lenngren" <emil.lenngren@gmail.com>,
"Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>,
"Lee Jones" <lee.jones@linaro.org>,
"Maxime Ripard" <mripard@kernel.org>,
"Chen-Yu Tsai" <wens@csie.org>,
"Jernej Skrabec" <jernej.skrabec@siol.net>,
linux-pwm@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-sunxi@lists.linux.dev, linux-sunxi@googlegroups.com,
"Roman Beranek" <roman.beranek@prusa3d.com>
Subject: Re: [PATCH] pwm: sun4i: Avoid waiting until the next period
Date: Thu, 27 May 2021 15:53:48 +0200 [thread overview]
Message-ID: <YK+kbJIvx7mVNDCE@piout.net> (raw)
In-Reply-To: <CBO0N2KNI5MJ.1KDTI8B2UE4SM@zen.local>
Hi,
On 27/05/2021 14:10:35+0200, Roman Beranek wrote:
> Hello Thierry,
>
> On Tue May 25, 2021 at 6:41 PM CEST, Thierry Reding wrote:
> > I'm pretty sure Alexandre at the time reported that the instantiation of
> > the controller that he was using required waiting for the period to
> > complete before the output went to the disabled state. It's possible
> > that this was changed in subsequent versions of the IP, so perhaps we
> > need to distinguish based on compatible string?
>
I can't recall what I tested exactly. I probably assumed it would take
the whole period to update because this is how it is working on v1 of
the atmel PWM and this is what I was working on at the time. I did test
on a CHIP. I guess linux-sunxi.org is more correct than I was at the
time.
> I've got myself an A10 (sun4i) board to test my new patchset with and
> indeed the 2 cycles seem to be enough.
>
> I have yet to write a cover letter for it though, expect it by Monday
> at the latest.
>
> Best regards,
> Roman
--
Alexandre Belloni, co-owner and COO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
next prev parent reply other threads:[~2021-05-27 13:53 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-11 22:00 [PATCH] pwm: sun4i: Avoid waiting until the next period Roman Beranek
2021-05-12 0:55 ` Emil Lenngren
2021-05-12 4:13 ` Roman Beranek
2021-05-12 4:41 ` Uwe Kleine-König
2021-05-12 9:18 ` Emil Lenngren
2021-05-25 16:41 ` Thierry Reding
2021-05-27 12:10 ` Roman Beranek
2021-05-27 13:53 ` Alexandre Belloni [this message]
2021-06-25 17:25 ` Uwe Kleine-König
2021-05-12 5:31 ` Roman Beranek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YK+kbJIvx7mVNDCE@piout.net \
--to=alexandre.belloni@bootlin.com \
--cc=emil.lenngren@gmail.com \
--cc=jernej.skrabec@siol.net \
--cc=lee.jones@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-pwm@vger.kernel.org \
--cc=linux-sunxi@googlegroups.com \
--cc=linux-sunxi@lists.linux.dev \
--cc=mripard@kernel.org \
--cc=roman.beranek@prusa3d.com \
--cc=roman.beranek@prusa3d.cz \
--cc=thierry.reding@gmail.com \
--cc=u.kleine-koenig@pengutronix.de \
--cc=wens@csie.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).