From: Mark Brown <broonie@kernel.org>
To: Ralf Schlatterbeck <rsc@runtux.com>
Cc: Andre Przywara <andre.przywara@arm.com>,
Maxime Ripard <mripard@kernel.org>, Chen-Yu Tsai <wens@csie.org>,
Jernej Skrabec <jernej.skrabec@gmail.com>,
linux-spi@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-sunxi@lists.linux.dev, linux-kernel@vger.kernel.org,
Mirko Vogt <mirko-dev|linux@nanl.de>
Subject: Re: [PATCH 1/1] spi-sun6i: Fix chipselect/clock bug
Date: Tue, 25 May 2021 15:35:51 +0100 [thread overview]
Message-ID: <YK0LR3077RUsSYti@sirena.org.uk> (raw)
In-Reply-To: <20210521201913.2gapcmrzynxekro7@runtux.com>
[-- Attachment #1: Type: text/plain, Size: 756 bytes --]
On Fri, May 21, 2021 at 10:19:13PM +0200, Ralf Schlatterbeck wrote:
> From: Mirko Vogt <mirko-dev|linux@nanl.de>
>
> The current sun6i SPI implementation initializes the transfer too early,
> resulting in SCK going high before the transfer. When using an additional
> (gpio) chipselect with sun6i, the chipselect is asserted at a time when
> clock is high, making the SPI transfer fail.
Please don't send new patches in reply to old threads, this makes
it hard to follow what is going on and creates confusion as to
what the current version of things is and means things can easily
get missed if the earlier thread gets discarded - this goes along
with the thing Andre mentioned about flagging the version of the
patch in the subject line.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2021-05-25 14:54 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-20 10:06 [PATCH 1/1] spi-sun6i: Fix chipselect/clock bug Ralf Schlatterbeck
2021-05-21 16:30 ` Andre Przywara
2021-05-21 20:16 ` Ralf Schlatterbeck
2021-05-21 20:19 ` Ralf Schlatterbeck
2021-05-24 12:33 ` Andre Przywara
2021-05-24 16:24 ` Ralf Schlatterbeck
2021-05-25 14:35 ` Mark Brown [this message]
2021-05-27 11:39 ` Ralf Schlatterbeck
2021-06-05 14:06 ` Mirko Vogt
2021-06-14 14:47 ` Ralf Schlatterbeck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YK0LR3077RUsSYti@sirena.org.uk \
--to=broonie@kernel.org \
--cc=andre.przywara@arm.com \
--cc=jernej.skrabec@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=linux-sunxi@lists.linux.dev \
--cc=mirko-dev|linux@nanl.de \
--cc=mripard@kernel.org \
--cc=rsc@runtux.com \
--cc=wens@csie.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).