linux-sunxi.lists.linux.dev archive mirror
 help / color / mirror / Atom feed
From: Christoph Hellwig <hch@infradead.org>
To: guoren@kernel.org
Cc: anup.patel@wdc.com, palmerdabbelt@google.com, arnd@arndb.de,
	linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org,
	linux-arch@vger.kernel.org, linux-sunxi@lists.linux.dev,
	Guo Ren <guoren@linux.alibaba.com>
Subject: Re: [PATCH 2/3] riscv: Fixup PAGE_UP in asm/page.h
Date: Tue, 25 May 2021 07:34:35 +0100	[thread overview]
Message-ID: <YKyae+8O25A8vxMS@infradead.org> (raw)
In-Reply-To: <1621839068-31738-2-git-send-email-guoren@kernel.org>

On Mon, May 24, 2021 at 06:51:07AM +0000, guoren@kernel.org wrote:
> From: Guo Ren <guoren@linux.alibaba.com>
> 
> Current PAGE_UP implementation is wrong. PAGE_UP(0) should be
> 0x1000, but current implementation will give out 0.
> 
> Although the current PAGE_UP isn't used, it will soon be used in
> tlb_flush optimization.

Nak.  Please just remove the PAGE_UP/PAGE_DOWN macros just like they
have been removed from other architectures long ago and use the
generic DIV_ROUND_UP macro for your new code like everyone else.

  reply	other threads:[~2021-05-25  6:35 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-05-24  6:51 [PATCH 1/3] riscv: Fixup _PAGE_GLOBAL in _PAGE_KERNEL guoren
2021-05-24  6:51 ` [PATCH 2/3] riscv: Fixup PAGE_UP in asm/page.h guoren
2021-05-25  6:34   ` Christoph Hellwig [this message]
2021-05-25  9:28     ` Guo Ren
2021-05-25  9:34       ` Christoph Hellwig
2021-05-24  6:51 ` [PATCH 3/3] riscv: Use use_asid_allocator flush TLB guoren
2021-05-24  8:13   ` Anup Patel
2021-05-24  8:03 ` [PATCH 1/3] riscv: Fixup _PAGE_GLOBAL in _PAGE_KERNEL Anup Patel
2021-05-24  8:22   ` Guo Ren
2021-05-24 10:42 ` Anup Patel
2021-05-24 12:01   ` Guo Ren

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YKyae+8O25A8vxMS@infradead.org \
    --to=hch@infradead.org \
    --cc=anup.patel@wdc.com \
    --cc=arnd@arndb.de \
    --cc=guoren@kernel.org \
    --cc=guoren@linux.alibaba.com \
    --cc=linux-arch@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-riscv@lists.infradead.org \
    --cc=linux-sunxi@lists.linux.dev \
    --cc=palmerdabbelt@google.com \
    --subject='Re: [PATCH 2/3] riscv: Fixup PAGE_UP in asm/page.h' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).