From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BB9C070 for ; Tue, 25 May 2021 09:35:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=77alA0oNaOdxO9Nn5XAmzEZ6uOPGgpzTh0etFfYrlAM=; b=CJtzWCtnRisoGTNMJQCQYaQgVp ZVGRtAAqogEkkwH9F9sBAGoaUIJqf8hyB4tWDL7yuZj/sqQh0U+BWtvZWmQGjuMN34YGl+CVRhKqY SpUjecHol9ErWniyWlQeiZ55SyQ6f5qUrCbAB5OfKHdCF0QtETh17x5xH9Cm8rZZgktR5YKtOhTaY BAo+VxbRlblic7Pi6monzUyPO9BA4KI29sePHIRFeDpFieohokdd8OHlD/lC11YmnpM9AjF2UhJvK mi4DXoLwyN6+LX4/ewdxrfmy4NRfdBhlIaoT1r8+VKmnGA1IUj76nNdLFH4YSTQJZb4oPpyYKmINK b2mPNq0A==; Received: from hch by casper.infradead.org with local (Exim 4.94 #2 (Red Hat Linux)) id 1llTSP-003LFb-Qx; Tue, 25 May 2021 09:34:52 +0000 Date: Tue, 25 May 2021 10:34:37 +0100 From: Christoph Hellwig To: Guo Ren Cc: Christoph Hellwig , Anup Patel , Palmer Dabbelt , Arnd Bergmann , linux-riscv , Linux Kernel Mailing List , linux-arch , linux-sunxi@lists.linux.dev, Guo Ren Subject: Re: [PATCH 2/3] riscv: Fixup PAGE_UP in asm/page.h Message-ID: References: <1621839068-31738-1-git-send-email-guoren@kernel.org> <1621839068-31738-2-git-send-email-guoren@kernel.org> X-Mailing-List: linux-sunxi@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-SRS-Rewrite: SMTP reverse-path rewritten from by casper.infradead.org. See http://www.infradead.org/rpr.html On Tue, May 25, 2021 at 05:28:21PM +0800, Guo Ren wrote: > On Tue, May 25, 2021 at 2:34 PM Christoph Hellwig wrote: > > > > On Mon, May 24, 2021 at 06:51:07AM +0000, guoren@kernel.org wrote: > > > From: Guo Ren > > > > > > Current PAGE_UP implementation is wrong. PAGE_UP(0) should be > > > 0x1000, but current implementation will give out 0. > > > > > > Although the current PAGE_UP isn't used, it will soon be used in > > > tlb_flush optimization. > > > > Nak. Please just remove the PAGE_UP/PAGE_DOWN macros just like they > > have been removed from other architectures long ago and use the > > generic DIV_ROUND_UP macro for your new code like everyone else. > > This patch has been dropped because it's wrong, ref Anup's reply. > > Remove PAGE_UP/DOWN is okay for me. How about: > static inline void local_flush_tlb_range_asid(unsigned long start, > unsigned long size, > unsigned long asid) > { > - unsigned long page_add = PAGE_DOWN(start); > - unsigned long page_end = PAGE_UP(start + size); > + unsigned long page_add = _ALIGN_DOWN(start, PAGE_SIZE); > + unsigned long page_end = _ALIGN_UP(start + size, PAGE_SIZE); > > _ALIGN_XXX are also defined in arch/riscv/include/asm/page.h. And these also are leftovers from days gone by and should be removed. I think this should simply be: unsigned long page_add = start & PAGE_MASK; unsigned long page_end = PAGE_ALIGN(start + size); (and page_add is a pretty horrible name as well..)