Re: [RESEND v2 1/3] dt-bindings: gpio: Convert X-Powers AXP209 GPIO binding to a schema

From: Lee Jones <lee.jones@linaro.org>
To: Rob Herring <robh+dt@kernel.org>
Cc: "Maxime Ripard" <maxime@cerno.tech>,
	"Chen-Yu Tsai" <wens@csie.org>,
	"Jernej Škrabec" <jernej.skrabec@gmail.com>,
	"Frank Rowand" <frowand.list@gmail.com>,
	linux-arm-kernel <linux-arm-kernel@lists.infradead.org>,
	devicetree@vger.kernel.org, linux-sunxi@lists.linux.dev,
	"Linus Walleij" <linus.walleij@linaro.org>,
	"open list:GPIO SUBSYSTEM" <linux-gpio@vger.kernel.org>,
	"Bartosz Golaszewski" <bgolaszewski@baylibre.com>
Subject: Re: [RESEND v2 1/3] dt-bindings: gpio: Convert X-Powers AXP209 GPIO binding to a schema
Date: Tue, 12 Oct 2021 16:52:04 +0100	[thread overview]
Message-ID: <YWWvJKs8K9Z8WIGV@google.com> (raw)
In-Reply-To: <YWWu+t487giK/FB2@google.com>

On Tue, 12 Oct 2021, Lee Jones wrote:

> On Tue, 12 Oct 2021, Rob Herring wrote:
> 
> > On Tue, Oct 12, 2021 at 9:51 AM Lee Jones <lee.jones@linaro.org> wrote:
> > >
> > > On Tue, 12 Oct 2021, Rob Herring wrote:
> > >
> > > > On Fri, Sep 24, 2021 at 2:16 AM Maxime Ripard <maxime@cerno.tech> wrote:
> > > > >
> > > > > The X-Powers AXP PMICs feature a GPIO Controller supported by Linux
> > > > > thanks to its device tree binding.
> > > > >
> > > > > Now that we have the DT validation in place, let's convert the device
> > > > > tree bindings for that driver over to a YAML schema.
> > > > >
> > > > > Cc: Chen-Yu Tsai <wens@csie.org>
> > > > > Cc: Linus Walleij <linus.walleij@linaro.org>
> > > > > Cc: linux-gpio@vger.kernel.org
> > > > > Acked-by: Bartosz Golaszewski <bgolaszewski@baylibre.com>
> > > > > Reviewed-by: Rob Herring <robh@kernel.org>
> > > > > Signed-off-by: Maxime Ripard <maxime@cerno.tech>
> > > > >
> > > > > ---
> > > > >
> > > > > Changes from v1:
> > > > >   - Removed the example and moved it in the mfd schema
> > > > > ---
> > > > >  .../devicetree/bindings/gpio/gpio-axp209.txt  | 75 -------------------
> > > > >  .../bindings/gpio/x-powers,axp209-gpio.yaml   | 55 ++++++++++++++
> > > > >  2 files changed, 55 insertions(+), 75 deletions(-)
> > > > >  delete mode 100644 Documentation/devicetree/bindings/gpio/gpio-axp209.txt
> > > > >  create mode 100644 Documentation/devicetree/bindings/gpio/x-powers,axp209-gpio.yaml
> > > >
> > > > This one not being applied with the rest of the series is also
> > > > breaking linux-next.
> > > >
> > > > b4 am -P_ -sl -o - 20210924071614.868307-1-maxime@cerno.tech | git am
> > >
> > > Thanks for the link.
> > >
> > > Seeing as there are no *real* dependencies, it would be better for
> > > Linus to take the patch (if he's okay with it of course).
> > 
> > Only that 'make dt_binding_check' is broken for anyone using your
> > branch (and linux-next ATM). It's as real as a broken build due to a
> > missing header. If you don't think this is a problem, then don't apply
> > MFD binding patches.
> 
> Ah, I missed Bartosz Ack up there.
> 
> Happy to apply it.

Linus, Bartosz, do you require a PR?

-- 
Lee Jones [李琼斯]
Senior Technical Lead - Developer Services
Linaro.org │ Open source software for Arm SoCs
Follow Linaro: Facebook | Twitter | Blog