From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from lahtoruutu.iki.fi (lahtoruutu.iki.fi [185.185.170.37]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A05451ED3A for ; Tue, 25 Jul 2023 10:59:13 +0000 (UTC) Received: from meesny.iki.fi (meesny.iki.fi [195.140.195.201]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lahtoruutu.iki.fi (Postfix) with ESMTPS id 4R9DP42Hyhz49Q7N for ; Tue, 25 Jul 2023 13:51:52 +0300 (EEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=iki.fi; s=lahtoruutu; t=1690282312; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=nVTFYmNWV1jP27+FDM4eqhSzMI/cuSd7gi5VmMNOAfg=; b=I58/mZha/XrVqwvkdmEqfLdCohC/nvuwymYvaO3Hdth2eQhnIC4Du3+GKRsorvLg2WZiR/ xqVPbCx3kUj0WxWPEphFU07c9JamaukGNYh9herk+b+fN5bNSIvqybe6HTBgnskUSvjTIy R0O/pWPr8fhyx/AnZoO+753Spj2cOlMWlhBRH6+QpwEVuWyzP4Zhrgody64BaWlgsGWjYu +xuZzoZCnZG/WbbvWLHR/la9ZYjjvH6RFXlHEfONLv0hHfUeo0HVB7YXGgTPGVku8zDJ0L X0tCFWVtIQDjo4UoPozR4ls2c55vjoKbP0TrgCQpbiqKndWYhbpHRqOYseZa1Q== Received: from hillosipuli.retiisi.eu (dkzdf0gkyyyyyyyyyyyyt-3.rev.dnainternet.fi [IPv6:2001:14ba:4506:4f15::1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: sailus) by meesny.iki.fi (Postfix) with ESMTPSA id 4R9DNk1zV3zyRB; Tue, 25 Jul 2023 13:51:33 +0300 (EEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=iki.fi; s=meesny; t=1690282303; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=nVTFYmNWV1jP27+FDM4eqhSzMI/cuSd7gi5VmMNOAfg=; b=OIKPneVysIIsOt0iRF7c9GoTrhfIJR3pJ1fYanttlyHbKxBnxdV50h3BXqREUF1tnvN/8H ttNqApgMpAYqB7vDQZc+xH2UvgGKtx66Hw1y+pGiPqPEw8hU2G2wzUdMtgPO8868lDUEuC mAamey/Dq8fuzD8h9oyCJhONbjrEu28= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=iki.fi; s=meesny; t=1690282303; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=nVTFYmNWV1jP27+FDM4eqhSzMI/cuSd7gi5VmMNOAfg=; b=B8bdNu9uBV5ZXRnWapFwaJRrCRvDVUeUl1pyKdPWhaxXOVJ824gQaLzPRbWHbGIpGc9grs jqcDmI9Bw1kzqTupLqxIloBqC/4NgCsOXWuXufhnKIg2jSO/0Ve1RtJU6Ax3Z+d0PLJPoe dAV05DsdXtLCk2N97Jcdz7E1wVO/iwM= ARC-Authentication-Results: i=1; ORIGINATING; auth=pass smtp.auth=sailus smtp.mailfrom=sakari.ailus@iki.fi ARC-Seal: i=1; s=meesny; d=iki.fi; t=1690282303; a=rsa-sha256; cv=none; b=vct141sa+XcGyQ1kVIQejOrk1qw2TvdjLqv5zflvOIbiywY4zEj5ryKGPtYOfkQM0he69/ 7oqKcieTLFTTIM75qqs7mrU3HO4obQNPfyig41htRHqPfObXhKwFeAh5H9FyPca2wIIHTX Wvb5rALlBcEDu3u29PPObFj7UthU4Mw= Received: from valkosipuli.retiisi.eu (valkosipuli.localdomain [192.168.4.2]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (prime256v1) server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by hillosipuli.retiisi.eu (Postfix) with ESMTPS id 304E7634C23; Tue, 25 Jul 2023 13:51:33 +0300 (EEST) Date: Tue, 25 Jul 2023 10:51:33 +0000 From: Sakari Ailus To: Krzysztof Kozlowski Cc: Hans Verkuil , Joe Tessler , Mauro Carvalho Chehab , Neil Armstrong , Kevin Hilman , Jerome Brunet , Martin Blumenstingl , Thierry Reding , Jonathan Hunter , Manivannan Sadhasivam , Michael Tretter , Pengutronix Kernel Team , Jacopo Mondi , Kieran Bingham , Laurent Pinchart , Niklas =?iso-8859-1?Q?S=F6derlund?= , Rui Miguel Silva , Wenyou Yang , Bin Liu , Matthias Brugger , AngeloGioacchino Del Regno , Minghsiu Tsai , Houlong Wei , Andrew-CT Chen , Andrzej Pietrasiewicz , Jacek Anaszewski , Sylwester Nawrocki , Patrice Chotard , Yong Deng , Paul Kocialkowski , Chen-Yu Tsai , Jernej Skrabec , Samuel Holland , "Lad, Prabhakar" , Ezequiel Garcia , Philipp Zabel , Sean Young , linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, linux-amlogic@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-tegra@vger.kernel.org, linux-mediatek@lists.infradead.org, linux-sunxi@lists.linux.dev, linux-rockchip@lists.infradead.org Subject: Re: [PATCH 01/28] media: cec: ch7322: drop of_match_ptr for ID table Message-ID: References: <20230312131318.351173-1-krzysztof.kozlowski@linaro.org> <98a77653-ec58-56c4-9893-3b424f67c87e@linaro.org> <5afcec8b-b8f6-35b0-278a-5de185e4a7a2@xs4all.nl> <158425ec-86e8-ca3e-eed8-e14b37c42730@linaro.org> Precedence: bulk X-Mailing-List: linux-sunxi@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: Hi Krzysztof, On Thu, Jul 13, 2023 at 08:46:58AM +0200, Krzysztof Kozlowski wrote: > On 19/06/2023 16:13, Krzysztof Kozlowski wrote: > > On 25/05/2023 15:19, Sakari Ailus wrote: > >> Hi folks, > >> > >> On Thu, May 25, 2023 at 03:40:04PM +0300, Sakari Ailus wrote: > >>> Hi Hans, > >>> > >>> On Sat, May 13, 2023 at 11:57:33AM +0200, Hans Verkuil wrote: > >>>> On 12/05/2023 18:35, Krzysztof Kozlowski wrote: > >>>>> On 12/03/2023 14:12, Krzysztof Kozlowski wrote: > >>>>>> The driver can match only via the DT table so the table should be always > >>>>>> used and the of_match_ptr does not have any sense (this also allows ACPI > >>>>>> matching via PRP0001, even though it might not be relevant here). > >>>>>> > >>>>>> drivers/media/cec/i2c/ch7322.c:583:34: error: ‘ch7322_of_match’ defined but not used [-Werror=unused-const-variable=] > >>>>>> > >>>>>> Signed-off-by: Krzysztof Kozlowski > >>>>>> --- > >>>>> > >>>>> Hans, Sakari, > >>>>> > >>>>> Can you pick up the patchset? There was positive feedback: > >>>>> https://patchwork.linuxtv.org/project/linux-media/patch/20230312131318.351173-1-krzysztof.kozlowski@linaro.org/ > >>>>> > >>>>> but it seems it was not applied. > >>>> > >>>> I see it is delegated to Sakari in patchwork and marked Under Review, but I don't > >>>> see a corresponding pull request for this series. > >>>> > >>>> Sakari, did something go wrong? > >>> > >>> I spotted this as Hans notified me in IRC, I wasn't cc'd. Apologies for > >>> this --- I intended to take these but I think I must have missed something > >>> important in the process. I'll take them now. > >>> > >>> Thanks. > >> > >> This no longer applied cleanly. Mostly there was fuzz near .of_match_table > >> changes as probe_new (and remove_new?) changes have been recently merged. > >> There were other issues as well, I marked a few patches in the set "not > >> applicable" as other patches had already done equivalent changes earlier. > >> > >> There were substance-changing changes in the 20th patch, replied to the > >> disuccsion there. > >> > >> I've pushed the result here and intend to send PR to Mauro soon if there > >> are no issues: > >> > >> > > > > One month later, I still don't see this set in the linux-next. What's > > happening here? > > > > I don't think this was merged in v6.5-rc1. It's not in linux-next, > either. Another month passed... These are now in the media-stage tree . Assuming nothing goes wrong, these should end up in Linus's tree for 6.6. The issues related to media tree maintenance are being addressed as we're changing the process how the tree is maintained. The patches will eventually get in still, also expect this to improve in the future. -- Regards, Sakari Ailus