From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from out198-179.us.a.mail.aliyun.com (out198-179.us.a.mail.aliyun.com [47.90.198.179]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id AD468179A2 for ; Mon, 25 Dec 2023 09:54:15 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=sjterm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=sjterm.com X-Alimail-AntiSpam:AC=CONTINUE;BC=0.07944658|-1;CH=green;DM=|CONTINUE|false|;DS=CONTINUE|ham_system_inform|0.0484377-0.000797998-0.950764;FP=0|0|0|0|0|-1|-1|-1;HT=ay29a033018047199;MF=fuyao@sjterm.com;NM=1;PH=DS;RN=11;RT=11;SR=0;TI=SMTPD_---.VsRwBJW_1703498043; Received: from localhost(mailfrom:fuyao@sjterm.com fp:SMTPD_---.VsRwBJW_1703498043) by smtp.aliyun-inc.com; Mon, 25 Dec 2023 17:54:03 +0800 Date: Mon, 25 Dec 2023 17:54:03 +0800 From: fuyao To: Jernej =?utf-8?Q?=C5=A0krabec?= , Lee Jones Cc: Andre Przywara , Lee Jones , fuyao , Chen-Yu Tsai , Samuel Holland , linux-arm-kernel@lists.infradead.org, linux-sunxi@lists.linux.dev, linux-kernel@vger.kernel.org, Maxime Ripard , maijianzhang Subject: Re: [PATCH RESEND] iio: adc: sun4i-gpadc-iio: adaptation interrupt number Message-ID: Mail-Followup-To: Jernej =?utf-8?Q?=C5=A0krabec?= , Lee Jones , Andre Przywara , fuyao , Chen-Yu Tsai , Samuel Holland , linux-arm-kernel@lists.infradead.org, linux-sunxi@lists.linux.dev, linux-kernel@vger.kernel.org, Maxime Ripard , maijianzhang References: <20231220115412.65bbc8c7@donnerap.manchester.arm.com> <20231221152553.GM10102@google.com> <4953611.0VBMTVartN@jernej-laptop> Precedence: bulk X-Mailing-List: linux-sunxi@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <4953611.0VBMTVartN@jernej-laptop> Organization: work_work_work On Fri, Dec 22, 2023 at 06:54:53PM +0100, Jernej Škrabec wrote: > Dne četrtek, 21. december 2023 ob 16:25:53 CET je Lee Jones napisal(a): > > On Wed, 20 Dec 2023, Andre Przywara wrote: > > > > > On Wed, 20 Dec 2023 15:23:17 +0800 > > > fuyao wrote: > > > > > > Hi, > > > > > > > __platform_get_irq_byname determinies whether the interrupt > > > > number is 0 and returns EINVAL. > > > > > > can you please say what this fixes, exactly? Is something not working at > > > the moment? Can you please provide parts of the error message? > > > > > > And maybe expand the explanation a bit more? For instance mention that the > > > identifiers are used as IRQ resource numbers, where 0 is treated specially. > > > > > > Cheers, > > > Andre > > > > > > > > > > > Signed-off-by: fuyao > > > > You have to use your full real name as well. > > Isn't that enough after > https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=d4563201f33a022fc0353033d9dfeb1606a88330 ? Thanks > > Best regards, > Jernej > > > > > > > Acked-by: Jernej Skrabec > > > > --- > > > > include/linux/mfd/sun4i-gpadc.h | 4 ++-- > > > > 1 file changed, 2 insertions(+), 2 deletions(-) > > > > > > > > diff --git a/include/linux/mfd/sun4i-gpadc.h b/include/linux/mfd/sun4i-gpadc.h > > > > index ea0ccf33a459..021f820f9d52 100644 > > > > --- a/include/linux/mfd/sun4i-gpadc.h > > > > +++ b/include/linux/mfd/sun4i-gpadc.h > > > > @@ -81,8 +81,8 @@ > > > > #define SUN4I_GPADC_TEMP_DATA 0x20 > > > > #define SUN4I_GPADC_DATA 0x24 > > > > > > > > -#define SUN4I_GPADC_IRQ_FIFO_DATA 0 > > > > -#define SUN4I_GPADC_IRQ_TEMP_DATA 1 > > > > +#define SUN4I_GPADC_IRQ_FIFO_DATA 1 > > > > +#define SUN4I_GPADC_IRQ_TEMP_DATA 2 > > > > > > > > /* 10s delay before suspending the IP */ > > > > #define SUN4I_GPADC_AUTOSUSPEND_DELAY 10000 > > > > > > > > > > > -- CYG Technology.