From: Sean Anderson <sean.anderson@seco.com> To: Andre Przywara <andre.przywara@arm.com>, Simon Glass <sjg@chromium.org>, Jagan Teki <jagan@amarulasolutions.com> Cc: u-boot@lists.denx.de, linux-sunxi@lists.linux.dev, Patrick Delaunay <patrick.delaunay@foss.st.com>, Heiko Schocher <hs@denx.de>, Kever Yang <kever.yang@rock-chips.com>, Philipp Tomsich <philipp.tomsich@vrull.eu> Subject: Re: [RFC PATCH 2/3] sunxi: Implement fastboot_get_mmc_device() Date: Mon, 24 May 2021 10:33:58 -0400 [thread overview] Message-ID: <c4cd77a4-5e61-d2a4-15e3-164024e0051f@seco.com> (raw) In-Reply-To: <20210524003650.24469-3-andre.przywara@arm.com> On 5/23/21 8:36 PM, Andre Przywara wrote: > The default MMC device to use for the fastboot flash command is hard to > decide at runtime, since the numbering of the MMC devices depends on > devicetree nodes. On the hardware side, the eMMC is connected to device > 2, but this might be U-Boot's device 1 or 2, depending on whether the DT > contains a WiFi node for the hardware MMC1 device. Can you fix this with aliases? e.g. aliases { mmc0 = &mmc0; mmc1 = &mmc1; mmc2 = &mmc2; }; That way the mmcs will always have the same number even if (e.g.) hardware mmc 1 is absent. --Sean > > To avoid hardcoding this for each board, let's scan all MMC devices, and > try to find the eMMC device, given that this is enabled. If not, we use > the SD card. > > Signed-off-by: Andre Przywara <andre.przywara@arm.com> > --- > board/sunxi/board.c | 37 +++++++++++++++++++++++++++++++++++++ > 1 file changed, 37 insertions(+) > > diff --git a/board/sunxi/board.c b/board/sunxi/board.c > index 21651a1bfca..5f64887e48b 100644 > --- a/board/sunxi/board.c > +++ b/board/sunxi/board.c > @@ -625,6 +625,43 @@ int board_mmc_init(struct bd_info *bis) > } > #endif > > +#ifdef CONFIG_FASTBOOT_FLASH_MMC > +int fastboot_get_mmc_device(void) > +{ > + struct udevice *dev; > + static int mmc_dev = -1; > + int sd_card = -1; > + > + if (mmc_dev != -1) > + return mmc_dev; > + > + for (uclass_first_device(UCLASS_MMC, &dev); > + dev; > + uclass_next_device(&dev)) { > + struct mmc *mmc = mmc_get_mmc_dev(dev); > + > + mmc_init(mmc); > + if (!mmc->has_init) > + continue; > + > + if (IS_SD(mmc)) { > + sd_card = dev->seq_; > + continue; > + } else { > + mmc_dev = dev->seq_; > + break; > + } > + } > + > + if (mmc_dev == -1) > + mmc_dev = sd_card; > + if (mmc_dev == -1) > + mmc_dev = 0; > + > + return mmc_dev; > +} > +#endif > + > #ifdef CONFIG_SPL_BUILD > > static void sunxi_spl_store_dram_size(phys_addr_t dram_size) >
next prev parent reply other threads:[~2021-05-24 14:34 UTC|newest] Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-05-24 0:36 [RFC PATCH 0/3] fastboot: sunxi: Determine MMC device at runtime Andre Przywara 2021-05-24 0:36 ` [RFC PATCH 1/3] fastboot: Allow runtime determination of MMC device Andre Przywara 2021-05-27 13:44 ` Simon Glass 2021-05-24 0:36 ` [RFC PATCH 2/3] sunxi: Implement fastboot_get_mmc_device() Andre Przywara 2021-05-24 14:33 ` Sean Anderson [this message] 2021-05-24 14:57 ` Andre Przywara 2021-05-24 0:36 ` [RFC PATCH 3/3] sunxi: Drop sunxi FASTBOOT_FLASH_MMC_DEV defaults Andre Przywara 2021-05-24 14:37 ` [RFC PATCH 0/3] fastboot: sunxi: Determine MMC device at runtime Sean Anderson 2021-05-24 15:15 ` Andre Przywara 2021-05-24 15:33 ` Sean Anderson 2021-05-24 15:28 ` Maxime Ripard 2021-05-24 15:43 ` Sean Anderson 2021-06-07 15:14 ` Maxime Ripard 2021-06-07 15:21 ` Sean Anderson
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=c4cd77a4-5e61-d2a4-15e3-164024e0051f@seco.com \ --to=sean.anderson@seco.com \ --cc=andre.przywara@arm.com \ --cc=hs@denx.de \ --cc=jagan@amarulasolutions.com \ --cc=kever.yang@rock-chips.com \ --cc=linux-sunxi@lists.linux.dev \ --cc=patrick.delaunay@foss.st.com \ --cc=philipp.tomsich@vrull.eu \ --cc=sjg@chromium.org \ --cc=u-boot@lists.denx.de \ --subject='Re: [RFC PATCH 2/3] sunxi: Implement fastboot_get_mmc_device()' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).