From: Tom Lendacky <thomas.lendacky@amd.com>
To: Wolfram Sang <wsa+renesas@sang-engineering.com>,
linux-kernel@vger.kernel.org
Cc: "David S. Miller" <davem@davemloft.net>,
"Eric Dumazet" <edumazet@google.com>,
"Jakub Kicinski" <kuba@kernel.org>,
"Paolo Abeni" <pabeni@redhat.com>,
"Jay Vosburgh" <j.vosburgh@gmail.com>,
"Veaceslav Falico" <vfalico@gmail.com>,
"Andy Gospodarek" <andy@greyhouse.net>,
"Wolfgang Grandegger" <wg@grandegger.com>,
"Marc Kleine-Budde" <mkl@pengutronix.de>,
"Florian Fainelli" <f.fainelli@gmail.com>,
"Andrew Lunn" <andrew@lunn.ch>,
"Vivien Didelot" <vivien.didelot@gmail.com>,
"Vladimir Oltean" <olteanv@gmail.com>,
"Kurt Kanzenbach" <kurt@linutronix.de>,
"Steffen Klassert" <klassert@kernel.org>,
"David Dillow" <dave@thedillows.org>,
"Russell King" <linux@armlinux.org.uk>,
"Ion Badulescu" <ionut@badula.org>,
"Andreas Larsson" <andreas@gaisler.com>,
"Mark Einon" <mark.einon@gmail.com>,
"Lino Sanfilippo" <LinoSanfilippo@gmx.de>,
"Chen-Yu Tsai" <wens@csie.org>,
"Jernej Skrabec" <jernej.skrabec@gmail.com>,
"Samuel Holland" <samuel@sholland.org>,
"Jes Sorensen" <jes@trained-monkey.org>,
"Shay Agroskin" <shayagr@amazon.com>,
"Arthur Kiyanovski" <akiyano@amazon.com>,
"David Arinzon" <darinzon@amazon.com>,
"Noam Dagan" <ndagan@amazon.com>,
"Saeed Bishara" <saeedb@amazon.com>,
"Don Fry" <pcnet32@frontier.com>,
"Shyam Sundar S K" <Shyam-sundar.S-k@amd.com>,
"Igor Russkikh" <irusskikh@marvell.com>,
"Chris Snook" <chris.snook@gmail.com>,
"Michael Chan" <michael.chan@broadcom.com>,
"Broadcom internal kernel review list"
<bcm-kernel-feedback-list@broadcom.com>,
"Rafał Miłecki" <rafal@milecki.pl>,
"Rasesh Mody" <rmody@marvell.com>,
GR-Linux-NIC-Dev@marvell.com, "Ariel Elior" <aelior@marvell.com>,
"Sudarsana Kalluru" <skalluru@marvell.com>,
"Manish Chopra" <manishc@marvell.com>,
"Doug Berger" <opendmb@gmail.com>,
"Siva Reddy Kallam" <siva.kallam@broadcom.com>,
"Prashant Sreedharan" <prashant@broadcom.com>,
"Sunil Goutham" <sgoutham@marvell.com>,
"Raju Rangoju" <rajur@chelsio.com>,
"Ayush Sawal" <ayush.sawal@chelsio.com>,
"Vinay Kumar Yadav" <vinay.yadav@chelsio.com>,
"Rohit Maheshwari" <rohitm@chelsio.com>,
"Hartley Sweeten" <hsweeten@visionengravers.com>,
"Christian Benvenuti" <benve@cisco.com>,
"Govindarajulu Varadarajan" <_govind@gmx.com>,
"Denis Kirjanov" <kda@linux-powerpc.org>,
"Ajit Khaparde" <ajit.khaparde@broadcom.com>,
"Sriharsha Basavapatna" <sriharsha.basavapatna@broadcom.com>,
"Somnath Kotur" <somnath.kotur@broadcom.com>,
"Madalin Bucur" <madalin.bucur@nxp.com>,
"Ioana Ciornei" <ioana.ciornei@nxp.com>,
"Claudiu Manoil" <claudiu.manoil@nxp.com>,
"Joakim Zhang" <qiangqing.zhang@nxp.com>,
"Pantelis Antoniou" <pantelis.antoniou@gmail.com>,
"Li Yang" <leoyang.li@nxp.com>,
"Yisen Zhuang" <yisen.zhuang@huawei.com>,
"Salil Mehta" <salil.mehta@huawei.com>,
"Douglas Miller" <dougmill@linux.ibm.com>,
"Michael Ellerman" <mpe@ellerman.id.au>,
"Nicholas Piggin" <npiggin@gmail.com>,
"Christophe Leroy" <christophe.leroy@csgroup.eu>,
"Nick Child" <nnac123@linux.ibm.com>,
"Jesse Brandeburg" <jesse.brandeburg@intel.com>,
"Tony Nguyen" <anthony.l.nguyen@intel.com>,
"Guo-Fu Tseng" <cooldavid@cooldavid.org>,
"Sebastian Hesselbarth" <sebastian.hesselbarth@gmail.com>,
"Thomas Petazzoni" <thomas.petazzoni@bootlin.com>,
"Marcin Wojtas" <mw@semihalf.com>,
"Geetha sowjanya" <gakula@marvell.com>,
"Subbaraya Sundeep" <sbhatta@marvell.com>,
hariprasad <hkelam@marvell.com>,
"Taras Chornyi" <tchornyi@marvell.com>,
"Mirko Lindner" <mlindner@marvell.com>,
"Stephen Hemminger" <stephen@networkplumber.org>,
"Felix Fietkau" <nbd@nbd.name>, "John Crispin" <john@phrozen.org>,
"Sean Wang" <sean.wang@mediatek.com>,
"Mark Lee" <Mark-MC.Lee@mediatek.com>,
"Matthias Brugger" <matthias.bgg@gmail.com>,
"Tariq Toukan" <tariqt@nvidia.com>,
"Saeed Mahameed" <saeedm@nvidia.com>,
"Leon Romanovsky" <leon@kernel.org>,
"Ido Schimmel" <idosch@nvidia.com>,
"Petr Machata" <petrm@nvidia.com>,
"Bryan Whitehead" <bryan.whitehead@microchip.com>,
UNGLinuxDriver@microchip.com,
"Chris Lee" <christopher.lee@cspi.com>,
"Jon Mason" <jdmason@kudzu.us>,
"Simon Horman" <simon.horman@corigine.com>,
"Rain River" <rain.1986.08.12@gmail.com>,
"Zhu Yanjun" <zyjzyj2000@gmail.com>,
"Vladimir Zapolskiy" <vz@mleia.com>,
"Rahul Verma" <rahulv@marvell.com>,
"Shahed Shaikh" <shshaikh@marvell.com>,
"Heiner Kallweit" <hkallweit1@gmail.com>,
nic_swsd@realtek.com, "Jiri Pirko" <jiri@resnulli.us>,
"Byungho An" <bh74.an@samsung.com>,
"Edward Cree" <ecree.xilinx@gmail.com>,
"Martin Habets" <habetsm.xilinx@gmail.com>,
"Ralf Baechle" <ralf@linux-mips.org>,
"Francois Romieu" <romieu@fr.zoreil.com>,
"Daniele Venzano" <venza@brownhat.org>,
"Nicolas Pitre" <nico@fluxnic.net>,
"Steve Glendinning" <steve.glendinning@shawell.net>,
"Jassi Brar" <jaswinder.singh@linaro.org>,
"Ilias Apalodimas" <ilias.apalodimas@linaro.org>,
"Kunihiko Hayashi" <hayashi.kunihiko@socionext.com>,
"Giuseppe Cavallaro" <peppe.cavallaro@st.com>,
"Alexandre Torgue" <alexandre.torgue@foss.st.com>,
"Jose Abreu" <joabreu@synopsys.com>,
"Maxime Coquelin" <mcoquelin.stm32@gmail.com>,
"Grygorii Strashko" <grygorii.strashko@ti.com>,
"Samuel Chessman" <chessman@tux.org>,
"Geoff Levand" <geoff@infradead.org>,
"Ishizaki Kou" <kou.ishizaki@toshiba.co.jp>,
"Kevin Brace" <kevinbrace@bracecomputerlab.com>,
"Radhey Shyam Pandey" <radhey.shyam.pandey@xilinx.com>,
"Michal Simek" <michal.simek@xilinx.com>,
"Krzysztof Halasa" <khalasa@piap.pl>,
"K. Y. Srinivasan" <kys@microsoft.com>,
"Haiyang Zhang" <haiyangz@microsoft.com>,
"Wei Liu" <wei.liu@kernel.org>,
"Dexuan Cui" <decui@microsoft.com>,
"Sridhar Samudrala" <sridhar.samudrala@intel.com>,
"Dave Jiang" <dave.jiang@intel.com>,
"Allen Hubbe" <allenbh@gmail.com>,
"Michael Hennerich" <michael.hennerich@analog.com>,
"Petko Manolov" <petkan@nucleusys.com>,
"Oliver Neukum" <oneukum@suse.com>,
"Michael S. Tsirkin" <mst@redhat.com>,
"Jason Wang" <jasowang@redhat.com>,
"Ronak Doshi" <doshir@vmware.com>,
"VMware PV-Drivers Reviewers" <pv-drivers@vmware.com>,
"David Ahern" <dsahern@kernel.org>,
"Kalle Valo" <kvalo@kernel.org>,
"Christian Lamparter" <chunkeey@googlemail.com>,
"Simon Kelley" <simon@thekelleys.org.uk>,
"Larry Finger" <Larry.Finger@lwfinger.net>,
"Arend van Spriel" <aspriel@gmail.com>,
"Franky Lin" <franky.lin@broadcom.com>,
"Hante Meuleman" <hante.meuleman@broadcom.com>,
"Stanislav Yakovlev" <stas.yakovlev@gmail.com>,
"Stanislaw Gruszka" <stf_xl@wp.pl>, "Jouni Malinen" <j@w1.fi>,
"Ajay Singh" <ajay.kathat@microchip.com>,
"Claudiu Beznea" <claudiu.beznea@microchip.com>,
"Igor Mitsyanko" <imitsyanko@quantenna.com>,
"Sergey Matyukevich" <geomatsi@gmail.com>,
"Herton Ronaldo Krzesinski" <herton@canonical.com>,
"Hin-Tak Leung" <htl10@users.sourceforge.net>,
netdev@vger.kernel.org, linux-can@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-sunxi@lists.linux.dev, linux-acenic@sunsite.dk,
linux-parisc@vger.kernel.org, linuxppc-dev@lists.ozlabs.org,
intel-wired-lan@lists.osuosl.org,
linux-mediatek@lists.infradead.org, linux-rdma@vger.kernel.org,
oss-drivers@corigine.com, linux-mips@vger.kernel.org,
linux-stm32@st-md-mailman.stormreply.com,
linux-omap@vger.kernel.org, linux-hyperv@vger.kernel.org,
ntb@lists.linux.dev, linux-usb@vger.kernel.org,
virtualization@lists.linux-foundation.org,
linux-wireless@vger.kernel.org, b43-dev@lists.infradead.org,
brcm80211-dev-list.pdl@broadcom.com,
SHA-cyfmac-dev-list@infineon.com,
libertas-dev@lists.infradead.org
Subject: Re: [PATCH] net: move from strlcpy with unused retval to strscpy
Date: Fri, 19 Aug 2022 10:45:29 -0500 [thread overview]
Message-ID: <fa2b1f1a-75e9-fd4c-aa23-84653562c346@amd.com> (raw)
In-Reply-To: <20220818210050.7108-1-wsa+renesas@sang-engineering.com>
On 8/18/22 16:00, Wolfram Sang wrote:
> Follow the advice of the below link and prefer 'strscpy' in this
> subsystem. Conversion is 1:1 because the return value is not used.
> Generated by a coccinelle script.
>
> Link: https://lore.kernel.org/r/CAHk-=wgfRnXz0W3D37d01q3JFkr_i_uTL=V6A6G1oUZcprmknw@mail.gmail.com/
> Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
> ---
> diff --git a/drivers/net/ethernet/amd/xgbe/xgbe-ethtool.c b/drivers/net/ethernet/amd/xgbe/xgbe-ethtool.c
> index 6ceb1cdf6eba..6e83ff59172a 100644
> --- a/drivers/net/ethernet/amd/xgbe/xgbe-ethtool.c
> +++ b/drivers/net/ethernet/amd/xgbe/xgbe-ethtool.c
> @@ -402,8 +402,8 @@ static void xgbe_get_drvinfo(struct net_device *netdev,
> struct xgbe_prv_data *pdata = netdev_priv(netdev);
> struct xgbe_hw_features *hw_feat = &pdata->hw_feat;
>
> - strlcpy(drvinfo->driver, XGBE_DRV_NAME, sizeof(drvinfo->driver));
> - strlcpy(drvinfo->bus_info, dev_name(pdata->dev),
> + strscpy(drvinfo->driver, XGBE_DRV_NAME, sizeof(drvinfo->driver));
> + strscpy(drvinfo->bus_info, dev_name(pdata->dev),
> sizeof(drvinfo->bus_info));
> snprintf(drvinfo->fw_version, sizeof(drvinfo->fw_version), "%d.%d.%d",
> XGMAC_GET_BITS(hw_feat->version, MAC_VR, USERVER),
For drivers/net/ethernet/amd/xgbe/xgbe-ethtool.c
Acked-by: Tom Lendacky <thomas.lendacky@amd.com>
next prev parent reply other threads:[~2022-08-19 15:46 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-18 21:00 [PATCH] net: move from strlcpy with unused retval to strscpy Wolfram Sang
2022-08-19 15:26 ` Geoff Levand
2022-08-19 15:45 ` Tom Lendacky [this message]
2022-08-19 16:06 ` Marcin Wojtas
2022-08-21 11:39 ` Leon Romanovsky
2022-08-22 7:00 ` Shay Agroskin
2022-08-23 1:05 ` Jakub Kicinski
2022-08-30 19:59 ` Wolfram Sang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fa2b1f1a-75e9-fd4c-aa23-84653562c346@amd.com \
--to=thomas.lendacky@amd.com \
--cc=GR-Linux-NIC-Dev@marvell.com \
--cc=Larry.Finger@lwfinger.net \
--cc=LinoSanfilippo@gmx.de \
--cc=Mark-MC.Lee@mediatek.com \
--cc=SHA-cyfmac-dev-list@infineon.com \
--cc=Shyam-sundar.S-k@amd.com \
--cc=UNGLinuxDriver@microchip.com \
--cc=_govind@gmx.com \
--cc=aelior@marvell.com \
--cc=ajay.kathat@microchip.com \
--cc=ajit.khaparde@broadcom.com \
--cc=akiyano@amazon.com \
--cc=alexandre.torgue@foss.st.com \
--cc=allenbh@gmail.com \
--cc=andreas@gaisler.com \
--cc=andrew@lunn.ch \
--cc=andy@greyhouse.net \
--cc=anthony.l.nguyen@intel.com \
--cc=aspriel@gmail.com \
--cc=ayush.sawal@chelsio.com \
--cc=b43-dev@lists.infradead.org \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=benve@cisco.com \
--cc=bh74.an@samsung.com \
--cc=brcm80211-dev-list.pdl@broadcom.com \
--cc=bryan.whitehead@microchip.com \
--cc=chessman@tux.org \
--cc=chris.snook@gmail.com \
--cc=christophe.leroy@csgroup.eu \
--cc=christopher.lee@cspi.com \
--cc=chunkeey@googlemail.com \
--cc=claudiu.beznea@microchip.com \
--cc=claudiu.manoil@nxp.com \
--cc=cooldavid@cooldavid.org \
--cc=darinzon@amazon.com \
--cc=dave.jiang@intel.com \
--cc=dave@thedillows.org \
--cc=davem@davemloft.net \
--cc=decui@microsoft.com \
--cc=doshir@vmware.com \
--cc=dougmill@linux.ibm.com \
--cc=dsahern@kernel.org \
--cc=ecree.xilinx@gmail.com \
--cc=edumazet@google.com \
--cc=f.fainelli@gmail.com \
--cc=franky.lin@broadcom.com \
--cc=gakula@marvell.com \
--cc=geoff@infradead.org \
--cc=geomatsi@gmail.com \
--cc=grygorii.strashko@ti.com \
--cc=habetsm.xilinx@gmail.com \
--cc=haiyangz@microsoft.com \
--cc=hante.meuleman@broadcom.com \
--cc=hayashi.kunihiko@socionext.com \
--cc=herton@canonical.com \
--cc=hkallweit1@gmail.com \
--cc=hkelam@marvell.com \
--cc=hsweeten@visionengravers.com \
--cc=htl10@users.sourceforge.net \
--cc=idosch@nvidia.com \
--cc=ilias.apalodimas@linaro.org \
--cc=imitsyanko@quantenna.com \
--cc=intel-wired-lan@lists.osuosl.org \
--cc=ioana.ciornei@nxp.com \
--cc=ionut@badula.org \
--cc=irusskikh@marvell.com \
--cc=j.vosburgh@gmail.com \
--cc=j@w1.fi \
--cc=jasowang@redhat.com \
--cc=jaswinder.singh@linaro.org \
--cc=jdmason@kudzu.us \
--cc=jernej.skrabec@gmail.com \
--cc=jes@trained-monkey.org \
--cc=jesse.brandeburg@intel.com \
--cc=jiri@resnulli.us \
--cc=joabreu@synopsys.com \
--cc=john@phrozen.org \
--cc=kda@linux-powerpc.org \
--cc=kevinbrace@bracecomputerlab.com \
--cc=khalasa@piap.pl \
--cc=klassert@kernel.org \
--cc=kou.ishizaki@toshiba.co.jp \
--cc=kuba@kernel.org \
--cc=kurt@linutronix.de \
--cc=kvalo@kernel.org \
--cc=kys@microsoft.com \
--cc=leon@kernel.org \
--cc=leoyang.li@nxp.com \
--cc=libertas-dev@lists.infradead.org \
--cc=linux-acenic@sunsite.dk \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-can@vger.kernel.org \
--cc=linux-hyperv@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-mips@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux-parisc@vger.kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=linux-stm32@st-md-mailman.stormreply.com \
--cc=linux-sunxi@lists.linux.dev \
--cc=linux-usb@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=madalin.bucur@nxp.com \
--cc=manishc@marvell.com \
--cc=mark.einon@gmail.com \
--cc=matthias.bgg@gmail.com \
--cc=mcoquelin.stm32@gmail.com \
--cc=michael.chan@broadcom.com \
--cc=michael.hennerich@analog.com \
--cc=michal.simek@xilinx.com \
--cc=mkl@pengutronix.de \
--cc=mlindner@marvell.com \
--cc=mpe@ellerman.id.au \
--cc=mst@redhat.com \
--cc=mw@semihalf.com \
--cc=nbd@nbd.name \
--cc=ndagan@amazon.com \
--cc=netdev@vger.kernel.org \
--cc=nic_swsd@realtek.com \
--cc=nico@fluxnic.net \
--cc=nnac123@linux.ibm.com \
--cc=npiggin@gmail.com \
--cc=ntb@lists.linux.dev \
--cc=olteanv@gmail.com \
--cc=oneukum@suse.com \
--cc=opendmb@gmail.com \
--cc=oss-drivers@corigine.com \
--cc=pabeni@redhat.com \
--cc=pantelis.antoniou@gmail.com \
--cc=pcnet32@frontier.com \
--cc=peppe.cavallaro@st.com \
--cc=petkan@nucleusys.com \
--cc=petrm@nvidia.com \
--cc=prashant@broadcom.com \
--cc=pv-drivers@vmware.com \
--cc=qiangqing.zhang@nxp.com \
--cc=radhey.shyam.pandey@xilinx.com \
--cc=rafal@milecki.pl \
--cc=rahulv@marvell.com \
--cc=rain.1986.08.12@gmail.com \
--cc=rajur@chelsio.com \
--cc=ralf@linux-mips.org \
--cc=rmody@marvell.com \
--cc=rohitm@chelsio.com \
--cc=romieu@fr.zoreil.com \
--cc=saeedb@amazon.com \
--cc=saeedm@nvidia.com \
--cc=salil.mehta@huawei.com \
--cc=samuel@sholland.org \
--cc=sbhatta@marvell.com \
--cc=sean.wang@mediatek.com \
--cc=sebastian.hesselbarth@gmail.com \
--cc=sgoutham@marvell.com \
--cc=shayagr@amazon.com \
--cc=shshaikh@marvell.com \
--cc=simon.horman@corigine.com \
--cc=simon@thekelleys.org.uk \
--cc=siva.kallam@broadcom.com \
--cc=skalluru@marvell.com \
--cc=somnath.kotur@broadcom.com \
--cc=sridhar.samudrala@intel.com \
--cc=sriharsha.basavapatna@broadcom.com \
--cc=stas.yakovlev@gmail.com \
--cc=stephen@networkplumber.org \
--cc=steve.glendinning@shawell.net \
--cc=stf_xl@wp.pl \
--cc=tariqt@nvidia.com \
--cc=tchornyi@marvell.com \
--cc=thomas.petazzoni@bootlin.com \
--cc=venza@brownhat.org \
--cc=vfalico@gmail.com \
--cc=vinay.yadav@chelsio.com \
--cc=virtualization@lists.linux-foundation.org \
--cc=vivien.didelot@gmail.com \
--cc=vz@mleia.com \
--cc=wei.liu@kernel.org \
--cc=wens@csie.org \
--cc=wg@grandegger.com \
--cc=wsa+renesas@sang-engineering.com \
--cc=yisen.zhuang@huawei.com \
--cc=zyjzyj2000@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).