From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.3 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 85155C4363A for ; Tue, 27 Oct 2020 21:52:45 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 3BF2620756 for ; Tue, 27 Oct 2020 21:52:45 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="B4QspCpf" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S374521AbgJ0Vwm (ORCPT ); Tue, 27 Oct 2020 17:52:42 -0400 Received: from mail-lj1-f195.google.com ([209.85.208.195]:46836 "EHLO mail-lj1-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2902336AbgJ0Vwl (ORCPT ); Tue, 27 Oct 2020 17:52:41 -0400 Received: by mail-lj1-f195.google.com with SMTP id 2so3437882ljj.13; Tue, 27 Oct 2020 14:52:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=EOfn+rTY41ZPk98ImlWCzM2uVjjLkgWeTbnbpRiwx94=; b=B4QspCpfrLoBxm8nbt/nY6Vc6pvrNIWz0XoyVAv6U5qDKlIhEpSOmL5MULuDcdRz4J NdVU97JPLEFFINpxs1bR7kXaAKKRc5t1LCYjmSEpeV3k25tRxIfa+w5hulTco0XoPAL5 NuYRujrqdYbq/2dROB5gt/BTZEUgllml+clfdS5r0UrbBpE1TBOBE+/PavDPL2xwqXQC X3UQBo8IKouDxrYKv17oC5H+7ff5WfzODsT8VtCHUrF6PnvPf8QBTXbyxtNZxLCHJioF z5+/59liqD8IS9SzzLvJrOgdyLJ3wnvNbwVfCnJVNKk24nRT7n3gjTF0PfTy6hhJpJeE /YcA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=EOfn+rTY41ZPk98ImlWCzM2uVjjLkgWeTbnbpRiwx94=; b=gaNuYylAcbUkjyS2Zztvxv351HMaLvo1yTeBHmjOJojSB+4cD95r6bFbrAqTN9bgFY J1xtPZ2TTmwvMqZbaOEipVz36C2o76Fsc6XJIg4YNkdgSB9vn7mvYVXBkNzz0WlUE1Ut z4/VZjpXYvheBwJrgjjnvhy9h2BLjjeOR/SXEtSlbZ21Q1e0Q7QWQR0bGG4GlNlxnrMi YUsoruxdjl9SVhZjdqP+N7eKsHy5pTBv/5JyP9avxgeVd2mLh/5KfiDvvkdq8ckVexdm 3De2tGah4SbDhbCRF3XOKMidqMvzMa2duv0+IrNUI4Eez64RUo1G3kqyG9zoodnU6e+L yuJg== X-Gm-Message-State: AOAM530Z3fhEcSBKEWndZ53RHz0F4BiSnKxn95Vusw0y+eqXa3RXCr35 cFKKeKOCIj6710yJQ1EEWWo= X-Google-Smtp-Source: ABdhPJxqwwB2L+NAENWqofO9hI5lVEPJjt9KYwjz/a5RXKvfYnoEDFODsN2229mWTIkaTH7zqrcUAw== X-Received: by 2002:a2e:8985:: with SMTP id c5mr2100186lji.406.1603835559052; Tue, 27 Oct 2020 14:52:39 -0700 (PDT) Received: from [192.168.2.145] (109-252-193-186.dynamic.spd-mgts.ru. [109.252.193.186]) by smtp.googlemail.com with ESMTPSA id v16sm303423lfq.68.2020.10.27.14.52.37 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 27 Oct 2020 14:52:38 -0700 (PDT) Subject: Re: [PATCH v3 0/3] implement I2C retries for mXT1368 To: "Wang, Jiada" , dmitry.torokhov@gmail.com, robh+dt@kernel.org, thierry.reding@gmail.com, jonathanh@nvidia.com Cc: nick@shmanahar.org, linux-input@vger.kernel.org, linux-kernel@vger.kernel.org, linux-tegra@vger.kernel.org, erosca@de.adit-jv.com, andrew_gabbasov@mentor.com References: <20200930151259.18119-1-jiada_wang@mentor.com> <653c24a4-704a-4d65-2622-49c55a82c901@mentor.com> From: Dmitry Osipenko Message-ID: <082b9b1c-5f89-7deb-728b-3de4339ac131@gmail.com> Date: Wed, 28 Oct 2020 00:52:37 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <653c24a4-704a-4d65-2622-49c55a82c901@mentor.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-tegra@vger.kernel.org 21.10.2020 04:14, Wang, Jiada пишет: > Hello Dmitry and all > > Kind reminder on this patch-set Hello Jiada, Thinking a bit more about these patches, I'm coming back to the variant with the atmel,wakeup-method property. There are three possible wake-up variants for mXT1368: - NONE - GPIO - I2C-SCL and this series covers only the I2C-SCL. I was also skimming through datasheets of other maxtouch touchscreens and noticed that the retries aren't unique to mXT1368. For example mXT3432 controller also needs exactly the same retrying logic. Hence I think it should be better if we could generalize the wakeup-method in the device-tree. What do you think?