linux-tegra.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Andrzej Pietrasiewicz <andrzej.p@collabora.com>
To: linux-pm@vger.kernel.org, linux-acpi@vger.kernel.org,
	linux-kernel@vger.kernel.org, linux-iio@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	linux-samsung-soc@vger.kernel.org, linux-input@vger.kernel.org,
	linux-tegra@vger.kernel.org, patches@opensource.cirrus.com,
	ibm-acpi-devel@lists.sourceforge.net,
	platform-driver-x86@vger.kernel.org
Cc: kernel@collabora.com, Nick Dyer <nick@shmanahar.org>,
	Laxman Dewangan <ldewangan@nvidia.com>,
	Peter Meerwald-Stadler <pmeerw@pmeerw.net>,
	Peter Hutterer <peter.hutterer@redhat.com>,
	Fabio Estevam <festevam@gmail.com>,
	Lars-Peter Clausen <lars@metafoo.de>,
	Krzysztof Kozlowski <krzk@kernel.org>,
	Jonathan Hunter <jonathanh@nvidia.com>,
	Kukjin Kim <kgene@kernel.org>, NXP Linux Team <linux-imx@nxp.com>,
	Sylvain Lemieux <slemieux.tyco@gmail.com>,
	Len Brown <lenb@kernel.org>,
	Michael Hennerich <michael.hennerich@analog.com>,
	Sascha Hauer <s.hauer@pengutronix.de>,
	Henrique de Moraes Holschuh <ibm-acpi@hmh.eng.br>,
	Vladimir Zapolskiy <vz@mleia.com>,
	Hans de Goede <hdegoede@redhat.com>,
	Barry Song <baohua@kernel.org>, Ferruh Yigit <fery@cypress.com>,
	Dmitry Torokhov <dmitry.torokhov@gmail.com>,
	"Rafael J . Wysocki" <rjw@rjwysocki.net>,
	Andrzej Pietrasiewicz <andrzej.p@collabora.c>
Subject: [PATCH v3 3/7] ACPI: button: Access input device's users under appropriate mutex
Date: Fri,  5 Jun 2020 19:33:31 +0200	[thread overview]
Message-ID: <20200605173335.13753-4-andrzej.p@collabora.com> (raw)
In-Reply-To: <20200605173335.13753-1-andrzej.p@collabora.com>

Inspecting input device's 'users' member should be done under device's
mutex, so add appropriate invocations.

Signed-off-by: Andrzej Pietrasiewicz <andrzej.p@collabora.com>
---
 drivers/acpi/button.c | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/drivers/acpi/button.c b/drivers/acpi/button.c
index 78cfc70cb320..ff7ab291f678 100644
--- a/drivers/acpi/button.c
+++ b/drivers/acpi/button.c
@@ -456,13 +456,16 @@ static int acpi_button_resume(struct device *dev)
 {
 	struct acpi_device *device = to_acpi_device(dev);
 	struct acpi_button *button = acpi_driver_data(device);
+	struct input_dev *input = button->input;
 
 	button->suspended = false;
-	if (button->type == ACPI_BUTTON_TYPE_LID && button->input->users) {
+	mutex_lock(&input->mutex);
+	if (button->type == ACPI_BUTTON_TYPE_LID && input->users) {
 		button->last_state = !!acpi_lid_evaluate_state(device);
 		button->last_time = ktime_get();
 		acpi_lid_initialize_state(device);
 	}
+	mutex_unlock(&input->mutex);
 	return 0;
 }
 #endif
-- 
2.17.1

  reply	other threads:[~2020-06-05 17:33 UTC|newest]

Thread overview: 90+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20200506002746.GB89269@dtor-ws>
2020-05-15 16:49 ` [PATCHv2 0/7] Support inhibiting input devices Andrzej Pietrasiewicz
     [not found]   ` <20200515164943.28480-1-andrzej.p-ZGY8ohtN/8qB+jHODAdFcQ@public.gmane.org>
2020-05-15 16:51     ` [PATCHv2 1/7] Input: add input_device_enabled() Andrzej Pietrasiewicz
2020-05-15 16:51     ` [PATCHv2 2/7] Input: use input_device_enabled() Andrzej Pietrasiewicz
2020-05-15 16:52     ` [PATCHv2 6/7] Input: Add "inhibited" property Andrzej Pietrasiewicz
2020-05-15 18:19     ` [PATCHv2 0/7] Support inhibiting input devices Hans de Goede
     [not found]       ` <842b95bb-8391-5806-fe65-be64b02de122-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2020-05-17 22:55         ` Peter Hutterer
2020-05-18  2:40           ` Dmitry Torokhov
2020-05-18  7:36             ` Hans de Goede
2020-05-22 15:35             ` Andrzej Pietrasiewicz
2020-05-27  6:13               ` Peter Hutterer
2020-05-18 10:48         ` Andrzej Pietrasiewicz
     [not found]           ` <e6030957-97dc-5b04-7855-bc14a78164c8-ZGY8ohtN/8qB+jHODAdFcQ@public.gmane.org>
2020-05-18 12:24             ` Hans de Goede
2020-05-18 13:49               ` Andrzej Pietrasiewicz
2020-05-18 14:23                 ` Hans de Goede
2020-05-19  9:02                   ` Andrzej Pietrasiewicz
2020-05-19  9:36                     ` Hans de Goede
     [not found]                       ` <aa2ce2ab-e5bc-9cb4-8b53-c1ef9348b646-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2020-05-27  6:34                         ` Dmitry Torokhov
2020-06-02 16:56                           ` Andrzej Pietrasiewicz
2020-06-02 17:52                             ` Dmitry Torokhov
2020-06-02 18:50                               ` Andrzej Pietrasiewicz
2020-06-02 20:19                                 ` Hans de Goede
     [not found]                                   ` <8f97d2e1-497a-495d-bc82-f46dbeba440c-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2020-06-03 13:07                                     ` Andrzej Pietrasiewicz
2020-06-03 17:38                                       ` Hans de Goede
2020-06-03 17:54                                         ` Andrzej Pietrasiewicz
2020-06-03 19:37                                           ` Hans de Goede
2020-06-04  7:28                                             ` Dmitry Torokhov
2020-06-05 17:33                                               ` [PATCH v3 " Andrzej Pietrasiewicz
2020-06-05 17:33                                                 ` Andrzej Pietrasiewicz [this message]
2020-06-05 17:33                                                 ` [PATCH v3 5/7] iio: adc: exynos: Use input_device_enabled() Andrzej Pietrasiewicz
     [not found]                                                   ` <20200605173335.13753-6-andrzej.p-ZGY8ohtN/8qB+jHODAdFcQ@public.gmane.org>
2020-06-05 19:49                                                     ` Michał Mirosław
     [not found]                                                 ` <20200605173335.13753-1-andrzej.p-ZGY8ohtN/8qB+jHODAdFcQ@public.gmane.org>
2020-06-05 17:33                                                   ` [PATCH v3 1/7] Input: add input_device_enabled() Andrzej Pietrasiewicz
2020-06-05 17:33                                                   ` [PATCH v3 2/7] Input: use input_device_enabled() Andrzej Pietrasiewicz
2020-06-05 17:33                                                   ` [PATCH v3 4/7] ACPI: button: Use input_device_enabled() helper Andrzej Pietrasiewicz
2020-06-05 17:33                                                   ` [PATCH v3 6/7] platform/x86: thinkpad_acpi: Use input_device_enabled() Andrzej Pietrasiewicz
2020-06-07 20:24                                                   ` [PATCH v3 0/7] Support inhibiting input devices Pavel Machek
2020-06-08  5:37                                                     ` Dmitry Torokhov
2020-06-08  9:28                                                       ` Andrzej Pietrasiewicz
2020-06-05 17:33                                                 ` [PATCH v3 7/7] Input: Add "inhibited" property Andrzej Pietrasiewicz
2020-06-05 17:41                                                   ` Hans de Goede
     [not found]                                                     ` <2336e15d-ff4b-bbb6-c701-dbf3aa110fcd-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2020-06-08 11:22                                                       ` [PATCH v4 0/7] Support inhibiting input devices Andrzej Pietrasiewicz
2020-06-08 11:22                                                         ` [PATCH v4 1/7] Input: add input_device_enabled() Andrzej Pietrasiewicz
2020-12-03  6:25                                                           ` Dmitry Torokhov
2020-06-08 11:22                                                         ` [PATCH v4 2/7] Input: use input_device_enabled() Andrzej Pietrasiewicz
2020-12-03  6:26                                                           ` Dmitry Torokhov
     [not found]                                                           ` <CGME20201207133237eucas1p26f8484944760a14e51dc7353ed33cd28@eucas1p2.samsung.com>
2020-12-07 13:32                                                             ` Marek Szyprowski
2020-12-07 15:50                                                               ` Andrzej Pietrasiewicz
2020-12-08 10:05                                                                 ` Marek Szyprowski
2020-12-09  6:37                                                                   ` Dmitry Torokhov
2020-12-11  7:09                                                                     ` [PATCH] Input: cyapa - do not call input_device_enabled from power mode handler Dmitry Torokhov
2020-12-11  8:22                                                                       ` Marek Szyprowski
2020-12-11  8:31                                                                         ` Dmitry Torokhov
2020-06-08 11:22                                                         ` [PATCH v4 3/7] ACPI: button: Access input device's users under appropriate mutex Andrzej Pietrasiewicz
2020-06-24 15:00                                                           ` Rafael J. Wysocki
2020-06-25  5:23                                                             ` Dmitry Torokhov
2020-06-25 10:55                                                               ` Rafael J. Wysocki
2020-10-05  5:08                                                                 ` Dmitry Torokhov
2020-06-08 11:22                                                         ` [PATCH v4 4/7] ACPI: button: Use input_device_enabled() helper Andrzej Pietrasiewicz
2020-06-25  5:24                                                           ` Dmitry Torokhov
2020-10-05  5:06                                                             ` Dmitry Torokhov
2020-06-08 11:22                                                         ` [PATCH v4 5/7] iio: adc: exynos: Use input_device_enabled() Andrzej Pietrasiewicz
     [not found]                                                           ` <20200608112211.12125-6-andrzej.p-ZGY8ohtN/8qB+jHODAdFcQ@public.gmane.org>
2020-06-10  1:28                                                             ` Michał Mirosław
2020-06-10  7:52                                                               ` [FIXED PATCH " Andrzej Pietrasiewicz
2020-06-08 11:22                                                         ` [PATCH v4 6/7] platform/x86: thinkpad_acpi: " Andrzej Pietrasiewicz
2020-06-08 11:22                                                         ` [PATCH v4 7/7] Input: Add "inhibited" property Andrzej Pietrasiewicz
2020-10-05 18:10                                                           ` Dmitry Torokhov
2020-10-06 13:04                                                             ` Andrzej Pietrasiewicz
2020-10-07  1:11                                                               ` Dmitry Torokhov
2020-10-07  1:12                                                                 ` Dmitry Torokhov
2020-12-03  6:26                                                                   ` Dmitry Torokhov
     [not found]                                                         ` <20200608112211.12125-1-andrzej.p-ZGY8ohtN/8qB+jHODAdFcQ@public.gmane.org>
2020-06-10  9:49                                                           ` [PATCH v4 0/7] Support inhibiting input devices Hans de Goede
2020-06-10 10:38                                                             ` Rafael J. Wysocki
     [not found]                                                               ` <CAJZ5v0hB2ra2K=dd9ZjVyy1V2b1PmFHm79uDO2HtHU1D_4YUbw-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2020-06-10 13:12                                                                 ` Andrzej Pietrasiewicz
2020-06-10 13:21                                                                   ` Hans de Goede
2020-06-10 13:41                                                                     ` Andrzej Pietrasiewicz
     [not found]                                                                       ` <2d5fd063-66bc-c707-4041-84a17c0a7d04-ZGY8ohtN/8qB+jHODAdFcQ@public.gmane.org>
2020-06-12  8:30                                                                         ` Hans de Goede
2020-06-12  8:47                                                                           ` Andrzej Pietrasiewicz
2020-06-16 17:29                                                                           ` [PATCH] Input: document inhibiting Andrzej Pietrasiewicz
2020-06-16 17:38                                                                             ` Randy Dunlap
     [not found]                                                                             ` <20200616172909.21625-1-andrzej.p-ZGY8ohtN/8qB+jHODAdFcQ@public.gmane.org>
2020-06-17  7:44                                                                               ` Hans de Goede
     [not found]                                                                                 ` <f9007f37-c526-5fa4-3188-a554d2434177-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2020-06-17 10:18                                                                                   ` [PATCH v2] " Andrzej Pietrasiewicz
     [not found]                                                                                     ` <20200617101822.8558-1-andrzej.p-ZGY8ohtN/8qB+jHODAdFcQ@public.gmane.org>
2020-06-17 10:21                                                                                       ` Hans de Goede
2020-06-17 16:52                                                                                     ` Randy Dunlap
2020-06-23 13:35                                                                                     ` Pavel Machek
2020-12-03  6:27                                                                                     ` Dmitry Torokhov
     [not found]                                                                     ` <3e61c9c1-b211-da9f-c55b-b44eb6522f2a-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2020-06-10 14:01                                                                       ` [PATCH v4 0/7] Support inhibiting input devices Rafael J. Wysocki
2020-06-10 13:52                                                                 ` Hans de Goede
2020-06-10 18:28                                                               ` Dmitry Torokhov
2020-06-12  8:14                                                                 ` Hans de Goede
2020-06-12  8:17                                                         ` Hans de Goede
2020-08-03 14:40                                                           ` Andrzej Pietrasiewicz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200605173335.13753-4-andrzej.p@collabora.com \
    --to=andrzej.p@collabora.com \
    --cc=andrzej.p@collabora.c \
    --cc=baohua@kernel.org \
    --cc=dmitry.torokhov@gmail.com \
    --cc=fery@cypress.com \
    --cc=festevam@gmail.com \
    --cc=hdegoede@redhat.com \
    --cc=ibm-acpi-devel@lists.sourceforge.net \
    --cc=ibm-acpi@hmh.eng.br \
    --cc=jonathanh@nvidia.com \
    --cc=kernel@collabora.com \
    --cc=kgene@kernel.org \
    --cc=krzk@kernel.org \
    --cc=lars@metafoo.de \
    --cc=ldewangan@nvidia.com \
    --cc=lenb@kernel.org \
    --cc=linux-acpi@vger.kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-iio@vger.kernel.org \
    --cc=linux-imx@nxp.com \
    --cc=linux-input@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=linux-samsung-soc@vger.kernel.org \
    --cc=linux-tegra@vger.kernel.org \
    --cc=michael.hennerich@analog.com \
    --cc=nick@shmanahar.org \
    --cc=patches@opensource.cirrus.com \
    --cc=peter.hutterer@redhat.com \
    --cc=platform-driver-x86@vger.kernel.org \
    --cc=pmeerw@pmeerw.net \
    --cc=rjw@rjwysocki.net \
    --cc=s.hauer@pengutronix.de \
    --cc=slemieux.tyco@gmail.com \
    --cc=vz@mleia.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).