From: Thierry Reding <thierry.reding-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
To: Lorenzo Pieralisi
<lorenzo.pieralisi-5wv7dgnIgG8@public.gmane.org>,
Bjorn Helgaas <bhelgaas-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org>,
Rob Herring <robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
Cc: Jon Hunter <jonathanh-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>,
linux-pci-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH v2 1/2] dt-bindings: pci: tegra: Remove PLL power supplies
Date: Thu, 16 Jul 2020 14:59:45 +0200 [thread overview]
Message-ID: <20200716125945.GD535268@ulmo> (raw)
In-Reply-To: <20200623145528.1658337-1-thierry.reding-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
[-- Attachment #1: Type: text/plain, Size: 3020 bytes --]
On Tue, Jun 23, 2020 at 04:55:27PM +0200, Thierry Reding wrote:
> From: Thierry Reding <treding-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
>
> The XUSB pad controller, which provides access to various USB, PCI and
> SATA pads (or PHYs), needs to bring up the PLLs associated with these
> pads. In order to properly do so, it needs to control the power supplied
> to these PLLs.
>
> Remove the PLL power supplies from the PCIe controller because it does
> not need direct access to them. Instead it will only use the configured
> pads provided by the XUSB pad controller.
>
> Signed-off-by: Thierry Reding <treding-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
> ---
> Hi Rob,
>
> I already made this change as part of the conversion series, but wanted
> to send this out as part of this subseries since it addresses a fairly
> long-standing issue that I'd like to clean up irrespective of the DT
> binding conversion. Since it looks like the conversion series will take
> a bit longer, I think it makes sense to send this out separately.
>
> Thierry
>
> .../devicetree/bindings/pci/nvidia,tegra20-pcie.txt | 12 ------------
> 1 file changed, 12 deletions(-)
Hi Rob, any feedback on this?
Thanks,
Thierry
> diff --git a/Documentation/devicetree/bindings/pci/nvidia,tegra20-pcie.txt b/Documentation/devicetree/bindings/pci/nvidia,tegra20-pcie.txt
> index 7939bca47861..d099f3476ccc 100644
> --- a/Documentation/devicetree/bindings/pci/nvidia,tegra20-pcie.txt
> +++ b/Documentation/devicetree/bindings/pci/nvidia,tegra20-pcie.txt
> @@ -112,28 +112,16 @@ Power supplies for Tegra124:
> - Required:
> - avddio-pex-supply: Power supply for analog PCIe logic. Must supply 1.05 V.
> - dvddio-pex-supply: Power supply for digital PCIe I/O. Must supply 1.05 V.
> - - avdd-pex-pll-supply: Power supply for dedicated (internal) PCIe PLL. Must
> - supply 1.05 V.
> - hvdd-pex-supply: High-voltage supply for PCIe I/O and PCIe output clocks.
> Must supply 3.3 V.
> - - hvdd-pex-pll-e-supply: High-voltage supply for PLLE (shared with USB3).
> - Must supply 3.3 V.
> - vddio-pex-ctl-supply: Power supply for PCIe control I/O partition. Must
> supply 2.8-3.3 V.
> - - avdd-pll-erefe-supply: Power supply for PLLE (shared with USB3). Must
> - supply 1.05 V.
>
> Power supplies for Tegra210:
> - Required:
> - - avdd-pll-uerefe-supply: Power supply for PLLE (shared with USB3). Must
> - supply 1.05 V.
> - hvddio-pex-supply: High-voltage supply for PCIe I/O and PCIe output
> clocks. Must supply 1.8 V.
> - dvddio-pex-supply: Power supply for digital PCIe I/O. Must supply 1.05 V.
> - - dvdd-pex-pll-supply: Power supply for dedicated (internal) PCIe PLL. Must
> - supply 1.05 V.
> - - hvdd-pex-pll-e-supply: High-voltage supply for PLLE (shared with USB3).
> - Must supply 3.3 V.
> - vddio-pex-ctl-supply: Power supply for PCIe control I/O partition. Must
> supply 1.8 V.
>
> --
> 2.27.0
>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2020-07-16 12:59 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-23 14:55 [PATCH v2 1/2] dt-bindings: pci: tegra: Remove PLL power supplies Thierry Reding
[not found] ` <20200623145528.1658337-1-thierry.reding-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2020-06-23 14:55 ` [PATCH v2 2/2] PCI: " Thierry Reding
[not found] ` <20200623145528.1658337-2-thierry.reding-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2020-07-16 13:00 ` Thierry Reding
2020-07-16 14:07 ` Lorenzo Pieralisi
[not found] ` <20200716140704.GA20249-LhTu/34fCX3ZROr8t4l/smS4ubULX0JqMm0uRHvK7Nw@public.gmane.org>
2020-07-16 15:06 ` Thierry Reding
2020-07-27 16:21 ` Rob Herring
2020-07-27 17:21 ` Thierry Reding
2020-07-27 17:43 ` Rob Herring
2020-07-16 12:59 ` Thierry Reding [this message]
2020-07-17 10:48 ` [PATCH v2 1/2] dt-bindings: pci: " Lorenzo Pieralisi
2020-07-27 16:17 ` Rob Herring
2020-07-28 10:20 ` Lorenzo Pieralisi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200716125945.GD535268@ulmo \
--to=thierry.reding-re5jqeeqqe8avxtiumwx3w@public.gmane.org \
--cc=bhelgaas-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org \
--cc=jonathanh-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org \
--cc=linux-pci-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=lorenzo.pieralisi-5wv7dgnIgG8@public.gmane.org \
--cc=robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).