From: Krzysztof Kozlowski <krzk@kernel.org>
To: Arnd Bergmann <arnd@arndb.de>, Olof Johansson <olof@lixom.net>,
Markus Mayer <mmayer@broadcom.com>,
bcm-kernel-feedback-list@broadcom.com,
Florian Fainelli <f.fainelli@gmail.com>,
Santosh Shilimkar <ssantosh@kernel.org>,
Matthias Brugger <matthias.bgg@gmail.com>,
Roger Quadros <rogerq@ti.com>, Tony Lindgren <tony@atomide.com>,
Vladimir Zapolskiy <vz@mleia.com>, Kukjin Kim <kgene@kernel.org>,
Thierry Reding <thierry.reding@gmail.com>,
Jonathan Hunter <jonathanh@nvidia.com>,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-mediatek@lists.infradead.org, linux-omap@vger.kernel.org,
linux-samsung-soc@vger.kernel.org, linux-tegra@vger.kernel.org
Cc: Andrew Morton <akpm@linux-foundation.org>,
Linus Torvalds <torvalds@linux-foundation.org>,
Krzysztof Kozlowski <krzk@kernel.org>
Subject: [RFT v2 20/29] memory: omap-gpmc: Return meaningful error codes in gpmc_cs_set_timings()
Date: Fri, 24 Jul 2020 09:40:29 +0200 [thread overview]
Message-ID: <20200724074038.5597-21-krzk@kernel.org> (raw)
In-Reply-To: <20200724074038.5597-1-krzk@kernel.org>
The callers of gpmc_cs_set_timings() expect to receive -ERRNO on errors
and they pass further what they have received.
However gpmc_cs_set_timings() was returning -1 (equal to -EPERM) which
does not make sense in this context.
Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
---
Not tested
Changes since v1:
1. New patch
---
drivers/memory/omap-gpmc.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/memory/omap-gpmc.c b/drivers/memory/omap-gpmc.c
index c158b6cae9a9..1e370142dfca 100644
--- a/drivers/memory/omap-gpmc.c
+++ b/drivers/memory/omap-gpmc.c
@@ -638,7 +638,7 @@ static int set_gpmc_timing_reg(int cs, int reg, int st_bit, int end_bit, int max
#define GPMC_SET_ONE_CD_MAX(reg, st, end, max, field, cd) \
if (set_gpmc_timing_reg(cs, (reg), (st), (end), (max), \
t->field, (cd), #field) < 0) \
- return -1
+ return -ENXIO
#define GPMC_SET_ONE(reg, st, end, field) \
GPMC_SET_ONE_CD_MAX(reg, st, end, 0, field, GPMC_CD_FCLK)
@@ -708,7 +708,7 @@ int gpmc_cs_set_timings(int cs, const struct gpmc_timings *t,
div = gpmc_calc_divider(t->sync_clk);
if (div < 0)
- return div;
+ return -EINVAL;
/*
* See if we need to change the divider for waitmonitoringtime.
@@ -733,7 +733,7 @@ int gpmc_cs_set_timings(int cs, const struct gpmc_timings *t,
__func__,
t->wait_monitoring
);
- return -1;
+ return -ENXIO;
}
}
--
2.17.1
next prev parent reply other threads:[~2020-07-24 7:42 UTC|newest]
Thread overview: 55+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-24 7:40 [PATCH v2 00/29] *memory: Cleanup, improve and compile test memory drivers Krzysztof Kozlowski
2020-07-24 7:40 ` [RFT v2 01/29] memory: omap-gpmc: Remove unneeded asm/mach-types.h inclusion Krzysztof Kozlowski
2020-08-17 18:27 ` Krzysztof Kozlowski
2020-07-24 7:40 ` [RFT v2 02/29] memory: omap-gpmc: Remove unused file-scope phys_base and mem_size Krzysztof Kozlowski
2020-08-17 18:31 ` Krzysztof Kozlowski
2020-07-24 7:40 ` [PATCH v2 03/29] memory: omap-gpmc: Include <linux/sizes.h> for SZ_16M Krzysztof Kozlowski
2020-07-24 14:09 ` Krzysztof Kozlowski
2020-07-24 7:40 ` [PATCH v2 04/29] memory: ti-aemif: Rename SS to SSTROBE to avoid name conflicts Krzysztof Kozlowski
2020-07-24 14:10 ` Krzysztof Kozlowski
2020-07-24 7:40 ` [PATCH v2 05/29] memory: jz4780-nemc: Do not enable by default on every compile test Krzysztof Kozlowski
2020-07-24 13:45 ` Arnd Bergmann
2020-07-24 13:53 ` Krzysztof Kozlowski
2020-07-24 7:40 ` [PATCH v2 06/29] memory: Enable compile testing for most of the drivers Krzysztof Kozlowski
2020-07-27 8:17 ` Krzysztof Kozlowski
2020-07-24 7:40 ` [PATCH v2 07/29] memory: of: Remove unused headers Krzysztof Kozlowski
2020-07-24 7:40 ` [PATCH v2 08/29] memory: of: Remove __func__ in device related messages Krzysztof Kozlowski
2020-07-24 7:40 ` [PATCH v2 09/29] memory: of: Correct indentation Krzysztof Kozlowski
2020-07-24 7:40 ` [PATCH v2 10/29] memory: of: Remove unneeded extern from function declarations Krzysztof Kozlowski
2020-07-24 7:40 ` [PATCH v2 11/29] memory: emif-asm-offsets: Add GPLv2 SPDX license header Krzysztof Kozlowski
2020-07-24 14:10 ` Krzysztof Kozlowski
2020-07-24 7:40 ` [PATCH v2 12/29] memory: emif: Put constant in comparison on the right side Krzysztof Kozlowski
2020-07-24 14:10 ` Krzysztof Kozlowski
2020-07-24 7:40 ` [PATCH v2 13/29] memory: emif: Fix whitespace coding style violations Krzysztof Kozlowski
2020-07-24 14:11 ` Krzysztof Kozlowski
2020-07-24 7:40 ` [PATCH v2 14/29] memory: emif: Silence platform_get_irq() error in driver Krzysztof Kozlowski
2020-07-24 14:11 ` Krzysztof Kozlowski
2020-07-24 7:40 ` [PATCH v2 15/29] memory: ti-emif-pm: Fix cast to iomem pointer Krzysztof Kozlowski
2020-07-24 14:12 ` Krzysztof Kozlowski
2020-07-24 7:40 ` [PATCH v2 16/29] memory: renesas-rpc-if: Simplify with PTR_ERR_OR_ZERO Krzysztof Kozlowski
2020-08-17 18:34 ` Krzysztof Kozlowski
2020-07-24 7:40 ` [PATCH v2 17/29] memory: brcmstb_dpfe: Constify the contents of string Krzysztof Kozlowski
2020-07-24 14:12 ` Krzysztof Kozlowski
2020-07-24 7:40 ` [PATCH v2 18/29] memory: brcmstb_dpfe: Remove unneeded braces Krzysztof Kozlowski
2020-07-24 14:13 ` Krzysztof Kozlowski
2020-07-24 7:40 ` [PATCH v2 19/29] memory: mtk-smi: Add argument to function pointer definition Krzysztof Kozlowski
2020-07-24 14:13 ` Krzysztof Kozlowski
2020-07-24 7:40 ` Krzysztof Kozlowski [this message]
2020-08-17 18:32 ` [RFT v2 20/29] memory: omap-gpmc: Return meaningful error codes in gpmc_cs_set_timings() Krzysztof Kozlowski
2020-07-24 7:40 ` [RFT v2 21/29] memory: omap-gpmc: Remove GPMC_SET_ONE_CD_MAX macro for safety Krzysztof Kozlowski
2020-08-17 18:33 ` Krzysztof Kozlowski
2020-07-24 7:40 ` [PATCH v2 22/29] memory: omap-gpmc: Fix whitespace issue Krzysztof Kozlowski
2020-07-24 14:16 ` Krzysztof Kozlowski
2020-07-24 7:40 ` [PATCH v2 23/29] memory: pl172: Add GPLv2 SPDX license header Krzysztof Kozlowski
2020-07-24 14:16 ` Krzysztof Kozlowski
2020-07-24 7:40 ` [PATCH v2 24/29] memory: tegra: tegra210-emc: Fix indentation Krzysztof Kozlowski
2020-08-17 18:34 ` Krzysztof Kozlowski
2020-07-24 7:40 ` [PATCH v2 25/29] MAINTAINERS: Add Krzysztof Kozlowski as maintainer of memory controllers Krzysztof Kozlowski
2020-07-24 7:40 ` [PATCH v2 26/29] memory: fsl_ifc: Fix whitespace issues Krzysztof Kozlowski
2020-07-24 14:15 ` Krzysztof Kozlowski
2020-07-24 7:40 ` [PATCH v2 27/29] memory: da8xx-ddrctl: Remove unused 'node' variable Krzysztof Kozlowski
2020-07-24 14:15 ` Krzysztof Kozlowski
2020-07-24 7:40 ` [PATCH v2 28/29] memory: Describe the MEMORY Kconfig entry Krzysztof Kozlowski
2020-07-24 7:40 ` [PATCH v2 29/29] memory: samsung: exynos-srom: Describe the " Krzysztof Kozlowski
2020-07-24 13:51 ` [PATCH v2 00/29] *memory: Cleanup, improve and compile test memory drivers Arnd Bergmann
2020-07-24 14:03 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200724074038.5597-21-krzk@kernel.org \
--to=krzk@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=arnd@arndb.de \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=f.fainelli@gmail.com \
--cc=jonathanh@nvidia.com \
--cc=kgene@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=matthias.bgg@gmail.com \
--cc=mmayer@broadcom.com \
--cc=olof@lixom.net \
--cc=rogerq@ti.com \
--cc=ssantosh@kernel.org \
--cc=thierry.reding@gmail.com \
--cc=tony@atomide.com \
--cc=torvalds@linux-foundation.org \
--cc=vz@mleia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).