From: "Michał Mirosław" <mirq-linux@rere.qmqm.pl>
To: Thierry Reding <thierry.reding@gmail.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-usb@vger.kernel.org, linux-tegra@vger.kernel.org
Subject: Re: [PATCH 2/2] usb: common: usb-conn-gpio: Print error on failure to get VBUS
Date: Sat, 8 Aug 2020 05:01:44 +0200 [thread overview]
Message-ID: <20200808030144.GB1658@qmqm.qmqm.pl> (raw)
In-Reply-To: <20200806160248.3936771-2-thierry.reding@gmail.com>
On Thu, Aug 06, 2020 at 06:02:48PM +0200, Thierry Reding wrote:
> The exact error that happened trying to get the VBUS supply can be
> useful to troubleshoot what's going on.
[...]
> --- a/drivers/usb/common/usb-conn-gpio.c
> +++ b/drivers/usb/common/usb-conn-gpio.c
> @@ -206,7 +206,7 @@ static int usb_conn_probe(struct platform_device *pdev)
>
> if (IS_ERR(info->vbus)) {
> if (PTR_ERR(info->vbus) != -EPROBE_DEFER)
> - dev_err(dev, "failed to get vbus\n");
> + dev_err(dev, "failed to get vbus: %ld\n", PTR_ERR(info->vbus));
There is now a nice "%pe" format, that can make this even better.
Best Regards,
Michał Mirosław
prev parent reply other threads:[~2020-08-08 3:01 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-06 16:02 [PATCH 1/2] usb: common: usb-conn-gpio: Make VBUS supply optional Thierry Reding
2020-08-06 16:02 ` [PATCH 2/2] usb: common: usb-conn-gpio: Print error on failure to get VBUS Thierry Reding
2020-08-08 3:01 ` Michał Mirosław [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200808030144.GB1658@qmqm.qmqm.pl \
--to=mirq-linux@rere.qmqm.pl \
--cc=gregkh@linuxfoundation.org \
--cc=linux-tegra@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=thierry.reding@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).