From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.6 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5A308C47426 for ; Tue, 29 Sep 2020 22:20:56 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 0463C2075A for ; Tue, 29 Sep 2020 22:20:55 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="X9jdsjD0" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728958AbgI2WUq (ORCPT ); Tue, 29 Sep 2020 18:20:46 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53620 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728877AbgI2WUp (ORCPT ); Tue, 29 Sep 2020 18:20:45 -0400 Received: from mail-lj1-x241.google.com (mail-lj1-x241.google.com [IPv6:2a00:1450:4864:20::241]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 594B3C0613D0; Tue, 29 Sep 2020 15:20:45 -0700 (PDT) Received: by mail-lj1-x241.google.com with SMTP id k25so5352425ljk.0; Tue, 29 Sep 2020 15:20:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=H2rq0nVEOS84HR3P8fvBTnOUMIN2ZeUzy3s5LRGgHQw=; b=X9jdsjD08RlJ3UQ+VUNmGvQBwIv2CRN+aiW8cLMUXxcF/+QjGar7TTOGvEg1YiK59D 0jM/Rln74pwfhKWAnyUPpNijsI0zO9fVT2+LwiDLmncECNpXr3C0f/MbsJGblxsrh9Qv IcW4k7VFEbMBSY9kp4ORhEg3xrC35hopAWzPaxloQd8ixXDVlN8wns37gpFi6Tw9dOqC /eBMEQ5hM8wz2UN0X2W1ZCMxWvJTddBt+EG0TcdMGzO2vN3YVqWkZDo75Qe1fNJrdtM1 6tbhlssmxnnppnSslu1cUs2rq8equmyRlUEwTH4/KxhdakL0vmSmLCsbOl/m0d27YQxn Bi2g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=H2rq0nVEOS84HR3P8fvBTnOUMIN2ZeUzy3s5LRGgHQw=; b=ehidjXzd3YNBAiLBWMO54DvjlrY0suhAAQ4tEjkngkP1rAKVcVO+2bK0Px0hAE12B/ 43/VrjBYemQ7TOfN/TPbIHEnb0xWViRDDhov8NCIQfckoX5h5+vU/BK+7YkSP2qjrPcl 8ZifSa65A1Q8Sh//Kr5rFRSoWQYNh/FJ3QMnxIf79UB2P9UGBv2M/XSMI6x92oxNOriE 5Ba9Tgj3mkxDvD6jPWcs3hTTDnOmOSh/z2yPDZRAQxjOjYF0susm+/GYKLBktyF7VvxG WTyAg5s+mR8eJiYofD/DEOHQMD2HQbsOzY9wzNuSJcPJKenJ7rUbwLUaBFsxCj1qf+mH xE5w== X-Gm-Message-State: AOAM530B3NsWGZ/Qpd5IVZvLZTABdntjyX3s/8Ji+vSYXq8xy2U8cRzV 1bbatlcvCQG1JjZEOfT/a5I= X-Google-Smtp-Source: ABdhPJzjK7zBjNU6E8/l4mVy5XPSyPaA1cP21gRQAiIw1Z7Wa43qAO+v6yUmXLVYEJdVLbbF0GsPWw== X-Received: by 2002:a2e:7119:: with SMTP id m25mr1937296ljc.365.1601418043801; Tue, 29 Sep 2020 15:20:43 -0700 (PDT) Received: from localhost.localdomain (109-252-170-211.dynamic.spd-mgts.ru. [109.252.170.211]) by smtp.gmail.com with ESMTPSA id q18sm3379750lfr.138.2020.09.29.15.20.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 29 Sep 2020 15:20:43 -0700 (PDT) From: Dmitry Osipenko To: Thierry Reding , Jonathan Hunter , Laxman Dewangan , Wolfram Sang , =?UTF-8?q?Micha=C5=82=20Miros=C5=82aw?= , Andy Shevchenko Cc: linux-i2c@vger.kernel.org, linux-tegra@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH v9 08/32] i2c: tegra: Remove error message used for devm_request_irq() failure Date: Wed, 30 Sep 2020 01:18:51 +0300 Message-Id: <20200929221915.10979-9-digetx@gmail.com> X-Mailer: git-send-email 2.27.0 In-Reply-To: <20200929221915.10979-1-digetx@gmail.com> References: <20200929221915.10979-1-digetx@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-tegra@vger.kernel.org The error message prints number of vIRQ, which isn't a useful information. In practice devm_request_irq() never fails, hence let's remove the bogus message in order to make code cleaner. Reviewed-by: Michał Mirosław Reviewed-by: Andy Shevchenko Reviewed-by: Thierry Reding Tested-by: Thierry Reding Signed-off-by: Dmitry Osipenko --- drivers/i2c/busses/i2c-tegra.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/i2c/busses/i2c-tegra.c b/drivers/i2c/busses/i2c-tegra.c index a52c72135390..b813c0976c10 100644 --- a/drivers/i2c/busses/i2c-tegra.c +++ b/drivers/i2c/busses/i2c-tegra.c @@ -1807,10 +1807,8 @@ static int tegra_i2c_probe(struct platform_device *pdev) ret = devm_request_irq(&pdev->dev, i2c_dev->irq, tegra_i2c_isr, IRQF_NO_SUSPEND, dev_name(&pdev->dev), i2c_dev); - if (ret) { - dev_err(&pdev->dev, "Failed to request irq %i\n", i2c_dev->irq); + if (ret) goto release_dma; - } i2c_set_adapdata(&i2c_dev->adapter, i2c_dev); i2c_dev->adapter.owner = THIS_MODULE; -- 2.27.0