linux-tegra.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Thierry Reding <thierry.reding@gmail.com>
To: Nicolin Chen <nicoleotsuka@gmail.com>
Cc: Dmitry Osipenko <digetx@gmail.com>,
	joro@8bytes.org, vdumpa@nvidia.com, jonathanh@nvidia.com,
	linux-tegra@vger.kernel.org, iommu@lists.linux-foundation.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v4 2/3] iommu/tegra-smmu: Rework tegra_smmu_probe_device()
Date: Mon, 5 Oct 2020 11:47:52 +0200	[thread overview]
Message-ID: <20201005094752.GG425362@ulmo> (raw)
In-Reply-To: <20201002195328.GE29706@Asurada-Nvidia>

[-- Attachment #1: Type: text/plain, Size: 1449 bytes --]

On Fri, Oct 02, 2020 at 12:53:28PM -0700, Nicolin Chen wrote:
> On Fri, Oct 02, 2020 at 05:58:29PM +0300, Dmitry Osipenko wrote:
> > 02.10.2020 17:22, Dmitry Osipenko пишет:
> > > 02.10.2020 09:08, Nicolin Chen пишет:
> > >> -static void tegra_smmu_release_device(struct device *dev)
> > >> -{
> > >> -	dev_iommu_priv_set(dev, NULL);
> > >> -}
> > >> +static void tegra_smmu_release_device(struct device *dev) {}
> > > 
> > > Please keep the braces as-is.
> > > 
> > 
> > I noticed that you borrowed this style from the sun50i-iommu driver, but
> > this is a bit unusual coding style for the c files. At least to me it's
> > unusual to see header-style function stub in a middle of c file. But
> > maybe it's just me.
> 
> I don't see a rule in ./Documentation/process/coding-style.rst
> against this, and there're plenty of drivers doing so. If you
> feel uncomfortable with this style, you may add a rule to that
> doc so everyone will follow :)

I also prefer braces on separate lines. Even better would be to just
drop this entirely and make ->release_device() optional. At least the
following drivers could be cleaned up that way:

    * fsl-pamu
    * msm-iommu
    * sun50i-iommu
    * tegra-gart
    * tegra-smmu

And it looks like mtk-iommu and mtk-iommu-v1 do only iommu_fwspec_free()
in their ->release_device() implementations, but that's already done via
iommu_release_device().

Thierry

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

  reply	other threads:[~2020-10-05  9:47 UTC|newest]

Thread overview: 46+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-10-02  6:08 [PATCH v4 0/3] iommu/tegra-smmu: Add PCI support Nicolin Chen
2020-10-02  6:08 ` [PATCH v4 1/3] iommu/tegra-smmu: Use fwspec in tegra_smmu_(de)attach_dev Nicolin Chen
2020-10-02 14:22   ` Dmitry Osipenko
2020-10-02 14:52     ` Dmitry Osipenko
2020-10-02 19:56       ` Nicolin Chen
2020-10-02 14:26   ` Dmitry Osipenko
2020-10-02 14:41   ` Dmitry Osipenko
2020-10-02 19:45     ` Nicolin Chen
2020-10-02 20:12       ` Dmitry Osipenko
2020-10-02 23:53         ` Nicolin Chen
2020-10-03  4:01           ` Dmitry Osipenko
2020-10-02  6:08 ` [PATCH v4 2/3] iommu/tegra-smmu: Rework tegra_smmu_probe_device() Nicolin Chen
2020-10-02 14:22   ` Dmitry Osipenko
2020-10-02 14:58     ` Dmitry Osipenko
2020-10-02 19:53       ` Nicolin Chen
2020-10-05  9:47         ` Thierry Reding [this message]
2020-10-02 14:22   ` Dmitry Osipenko
2020-10-02 14:50     ` Dmitry Osipenko
2020-10-05  9:53       ` Thierry Reding
2020-10-05 10:36         ` Dmitry Osipenko
2020-10-05 11:15           ` Thierry Reding
2020-10-05 13:28             ` Dmitry Osipenko
2020-10-05 14:22               ` Thierry Reding
2020-10-05  9:51     ` Thierry Reding
2020-10-02 14:23   ` Dmitry Osipenko
2020-10-02 18:01     ` Nicolin Chen
2020-10-02 18:20       ` Dmitry Osipenko
2020-10-02 15:02   ` Dmitry Osipenko
2020-10-02 18:58     ` Nicolin Chen
2020-10-05  9:57       ` Thierry Reding
2020-10-06  1:05         ` Nicolin Chen
2020-10-08  9:53           ` Thierry Reding
2020-10-08 21:12             ` Nicolin Chen
2020-10-09 12:25               ` Thierry Reding
2020-10-09 15:54                 ` Nicolin Chen
2020-10-02 15:23   ` Dmitry Osipenko
2020-10-02 16:00     ` Dmitry Osipenko
2020-10-02 16:37       ` Dmitry Osipenko
2020-10-02 16:50         ` Dmitry Osipenko
2020-10-02  6:08 ` [PATCH v4 3/3] iommu/tegra-smmu: Add PCI support Nicolin Chen
2020-10-02 14:35   ` Dmitry Osipenko
2020-10-02 17:45     ` Nicolin Chen
2020-10-02 18:04       ` Dmitry Osipenko
2020-10-02 18:04   ` Dmitry Osipenko
2020-10-05 10:04   ` Thierry Reding
2020-10-06  0:54     ` Nicolin Chen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20201005094752.GG425362@ulmo \
    --to=thierry.reding@gmail.com \
    --cc=digetx@gmail.com \
    --cc=iommu@lists.linux-foundation.org \
    --cc=jonathanh@nvidia.com \
    --cc=joro@8bytes.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-tegra@vger.kernel.org \
    --cc=nicoleotsuka@gmail.com \
    --cc=vdumpa@nvidia.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).