From: Rob Herring <robh@kernel.org>
To: Sameer Pujar <spujar@nvidia.com>
Cc: broonie@kernel.org, lgirdwood@gmail.com,
kuninori.morimoto.gx@renesas.com,
pierre-louis.bossart@linux.intel.com, perex@perex.cz,
tiwai@suse.com, p.zabel@pengutronix.de, thierry.reding@gmail.com,
jonathanh@nvidia.com, alsa-devel@alsa-project.org,
devicetree@vger.kernel.org, linux-tegra@vger.kernel.org,
linux-kernel@vger.kernel.org, sharadg@nvidia.com,
mkumard@nvidia.com, viswanathl@nvidia.com, rlokhande@nvidia.com,
dramesh@nvidia.com, atalambedu@nvidia.com, nwartikar@nvidia.com,
swarren@nvidia.com, nicoleotsuka@gmail.com
Subject: Re: [PATCH v4 11/15] ASoC: dt-bindings: tegra: Add json-schema for Tegra audio graph card
Date: Mon, 19 Oct 2020 17:16:12 -0500 [thread overview]
Message-ID: <20201019221612.GA3690258@bogus> (raw)
In-Reply-To: <1602859382-19505-12-git-send-email-spujar@nvidia.com>
On Fri, Oct 16, 2020 at 08:12:58PM +0530, Sameer Pujar wrote:
> Add YAML schema for Tegra audio graph sound card DT bindings. It uses the
> same DT bindings provided by generic audio graph driver. Along with this
> few standard clock DT bindings are added which are specifically required
> for Tegra audio.
>
> Signed-off-by: Sameer Pujar <spujar@nvidia.com>
> ---
> .../sound/nvidia,tegra-audio-graph-card.yaml | 158 +++++++++++++++++++++
> 1 file changed, 158 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/sound/nvidia,tegra-audio-graph-card.yaml
>
> diff --git a/Documentation/devicetree/bindings/sound/nvidia,tegra-audio-graph-card.yaml b/Documentation/devicetree/bindings/sound/nvidia,tegra-audio-graph-card.yaml
> new file mode 100644
> index 0000000..284d185
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/sound/nvidia,tegra-audio-graph-card.yaml
> @@ -0,0 +1,158 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/sound/nvidia,tegra-audio-graph-card.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Audio Graph based Tegra sound card driver
> +
> +description: |
> + This is based on generic audio graph card driver along with additional
> + customizations for Tegra platforms. It uses the same bindings with
> + additional standard clock DT bindings required for Tegra.
> +
> + See{LINUX}/Documentation/devicetree/bindings/sound/audio-graph-card.yaml
You should be able to just $ref this at the top level.
> +
> +maintainers:
> + - Jon Hunter <jonathanh@nvidia.com>
> + - Sameer Pujar <spujar@nvidia.com>
> +
> +properties:
> + compatible:
> + items:
> + - enum:
> + - nvidia,tegra210-audio-graph-card
> + - nvidia,tegra186-audio-graph-card
> +
> + dais:
> + $ref: /schemas/sound/audio-graph-card.yaml#/properties/dais
> +
> + label:
> + $ref: /schemas/sound/simple-card.yaml#/properties/label
> +
> + pa-gpios:
> + $ref: /schemas/sound/audio-graph-card.yaml#/properties/pa-gpios
> +
> + widgets:
> + $ref: /schemas/sound/simple-card.yaml#/definitions/widgets
> +
> + routing:
> + $ref: /schemas/sound/simple-card.yaml#/definitions/routing
> +
> + mclk-fs:
> + $ref: /schemas/sound/simple-card.yaml#/definitions/mclk-fs
> +
> + prefix:
> + $ref: /schemas/sound/simple-card.yaml#/definitions/prefix
And drop all of these.
> +
> + clocks:
> + minItems: 2
> +
> + clock-names:
> + minItems: 2
Don't need this.
> + items:
> + - const: pll_a
> + - const: plla_out0
> +
> + assigned-clocks:
> + minItems: 1
> + maxItems: 3
> +
> + assigned-clock-parents:
> + minItems: 1
> + maxItems: 3
> +
> + assigned-clock-rates:
> + minItems: 1
> + maxItems: 3
> +
> + ports:
> + $ref: /schemas/sound/audio-graph-card.yaml#/properties/ports
> +
> +patternProperties:
> + "^port(@[0-9a-f]+)?$":
> + $ref: /schemas/sound/audio-graph-card.yaml#/definitions/port
And these can be dropped. Unless what each port is is Tegra specific.
> +
> +additionalProperties: false
> +
> +required:
> + - compatible
> + - dais
> + - clocks
> + - clock-names
> + - assigned-clocks
> + - assigned-clock-parents
> +
> +examples:
> + - |
> + #include<dt-bindings/clock/tegra210-car.h>
> +
> + tegra_sound {
> + compatible = "nvidia,tegra210-audio-graph-card";
> +
> + clocks = <&tegra_car TEGRA210_CLK_PLL_A>,
> + <&tegra_car TEGRA210_CLK_PLL_A_OUT0>;
> + clock-names = "pll_a", "plla_out0";
> +
> + assigned-clocks = <&tegra_car TEGRA210_CLK_PLL_A>,
> + <&tegra_car TEGRA210_CLK_PLL_A_OUT0>,
> + <&tegra_car TEGRA210_CLK_EXTERN1>;
> + assigned-clock-parents = <0>, <0>, <&tegra_car TEGRA210_CLK_PLL_A_OUT0>;
> + assigned-clock-rates = <368640000>, <49152000>, <12288000>;
> +
> + dais = /* FE */
> + <&admaif1_port>,
> + /* Router */
> + <&xbar_i2s1_port>,
> + /* I/O DAP Ports */
> + <&i2s1_port>;
> +
> + label = "jetson-tx1-ape";
> + };
> +
> + tegra_ahub: ahub@702d0800 {
> + // ...
> +
> + reg = <0x702d0800 0x800>;
> +
> + ports {
> + #address-cells = <1>;
> + #size-cells = <0>;
> +
> + xbar_i2s1_port: port@a {
> + reg = <0xa>;
> + xbar_i2s1_ep: endpoint {
> + remote-endpoint = <&i2s1_cif_ep>;
> + };
> + };
> + };
> + };
> +
> + tegra_i2s1: i2s@702d1000 {
> + // ...
> +
> + #address-cells = <1>;
> + #size-cells = <0>;
> +
> + reg = <0x702d1000 0x100>;
> +
> + port@0 {
> + reg = <0>;
> +
> + i2s1_cif_ep: endpoint {
> + remote-endpoint = <&xbar_i2s1_ep>;
> + };
> + };
> +
> + i2s1_port: port@1 {
> + reg = <1>;
> +
> + i2s1_dap: endpoint {
> + dai-format = "i2s";
> +
> + // ...
> + };
> + };
> + };
> +
> +...
> --
> 2.7.4
>
next prev parent reply other threads:[~2020-10-19 22:16 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-16 14:42 [PATCH v4 00/15] Audio graph card updates and usage with Tegra210 audio Sameer Pujar
2020-10-16 14:42 ` [PATCH v4 01/15] ASoC: soc-core: Fix component name_prefix parsing Sameer Pujar
2020-10-16 14:42 ` [PATCH v4 02/15] ASoC: soc-pcm: Get all BEs along DAPM path Sameer Pujar
2020-10-16 14:42 ` [PATCH v4 03/15] ASoC: audio-graph: Use of_node and DAI for DPCM DAI link names Sameer Pujar
2020-10-16 14:42 ` [PATCH v4 04/15] ASoC: audio-graph: Identify 'no_pcm' DAI links for DPCM Sameer Pujar
2020-10-16 14:42 ` [PATCH v4 05/15] ASoC: audio-graph: Support empty Codec endpoint Sameer Pujar
2020-10-16 14:42 ` [PATCH v4 06/15] ASoC: audio-graph: Expose new members for asoc_simple_priv Sameer Pujar
2020-10-16 14:42 ` [PATCH v4 07/15] ASoC: audio-graph: Expose helpers from audio graph Sameer Pujar
2020-10-16 14:42 ` [PATCH v4 08/15] Documentation: of: Convert graph bindings to json-schema Sameer Pujar
2020-10-19 21:56 ` Rob Herring
2020-10-20 5:34 ` Sameer Pujar
2020-10-20 8:30 ` Philipp Zabel
2020-10-23 13:45 ` Sameer Pujar
2020-10-16 14:42 ` [PATCH v4 09/15] ASoC: dt-bindings: audio-graph: Convert " Sameer Pujar
2020-10-19 2:50 ` Kuninori Morimoto
2020-10-19 4:30 ` Sameer Pujar
2020-10-19 4:41 ` Kuninori Morimoto
2020-10-19 22:11 ` Rob Herring
2020-10-16 14:42 ` [PATCH v4 10/15] ASoC: dt-bindings: tegra: Add graph bindings Sameer Pujar
2020-10-19 22:11 ` Rob Herring
2020-10-20 6:03 ` Sameer Pujar
2020-10-16 14:42 ` [PATCH v4 11/15] ASoC: dt-bindings: tegra: Add json-schema for Tegra audio graph card Sameer Pujar
2020-10-19 22:16 ` Rob Herring [this message]
2020-10-20 6:16 ` Sameer Pujar
2020-10-20 13:24 ` Rob Herring
2020-10-16 14:42 ` [PATCH v4 12/15] ASoC: tegra: Add audio graph based card driver Sameer Pujar
2020-10-16 14:43 ` [PATCH v4 13/15] arm64: defconfig: Enable Tegra audio graph " Sameer Pujar
2020-10-16 14:43 ` [PATCH v4 14/15] arm64: tegra: Audio graph header for Tegra210 Sameer Pujar
2020-10-16 14:43 ` [PATCH v4 15/15] arm64: tegra: Audio graph sound card for Jetson Nano and TX1 Sameer Pujar
2020-10-30 6:34 ` [PATCH v4 00/15] Audio graph card updates and usage with Tegra210 audio Sameer Pujar
2020-10-30 13:58 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201019221612.GA3690258@bogus \
--to=robh@kernel.org \
--cc=alsa-devel@alsa-project.org \
--cc=atalambedu@nvidia.com \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dramesh@nvidia.com \
--cc=jonathanh@nvidia.com \
--cc=kuninori.morimoto.gx@renesas.com \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=mkumard@nvidia.com \
--cc=nicoleotsuka@gmail.com \
--cc=nwartikar@nvidia.com \
--cc=p.zabel@pengutronix.de \
--cc=perex@perex.cz \
--cc=pierre-louis.bossart@linux.intel.com \
--cc=rlokhande@nvidia.com \
--cc=sharadg@nvidia.com \
--cc=spujar@nvidia.com \
--cc=swarren@nvidia.com \
--cc=thierry.reding@gmail.com \
--cc=tiwai@suse.com \
--cc=viswanathl@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).