From: Thierry Reding <thierry.reding@gmail.com>
To: Vidya Sagar <vidyas@nvidia.com>
Cc: lorenzo.pieralisi@arm.com, robh+dt@kernel.org,
bhelgaas@google.com, jonathanh@nvidia.com,
amanharitsh123@gmail.com, dinghao.liu@zju.edu.cn, kw@linux.com,
linux-pci@vger.kernel.org, linux-tegra@vger.kernel.org,
linux-kernel@vger.kernel.org, kthota@nvidia.com,
mmaddireddy@nvidia.com, sagar.tv@gmail.com
Subject: Re: [PATCH V4 0/6] Enhancements to Tegra194 PCIe driver
Date: Wed, 25 Nov 2020 18:57:09 +0100 [thread overview]
Message-ID: <20201125175709.GA1274379@ulmo> (raw)
In-Reply-To: <20201109171937.28326-1-vidyas@nvidia.com>
[-- Attachment #1: Type: text/plain, Size: 2163 bytes --]
On Mon, Nov 09, 2020 at 10:49:31PM +0530, Vidya Sagar wrote:
> This series of patches do some enhancements and some bug fixes to the
> Tegra194 PCIe platform driver like
> - Fix Vendor-ID corruption
> - Map DBI space correctly
> - Update DWC IP version
> - Continue with uninitialization sequence even if parts fail
> - Check return value of tegra_pcie_init_controller()
>
> V4:
> * Added a new patch to address link-up issues with some of the cards
>
> V3:
> * Addressed Bjorn's review comments
> * Split earlier patch-4 into two
> - Continue with the uninitialization sequence even if some parts fail
> - Check return value of tegra_pcie_init_controller() and exit accordingly
>
> V2:
> * Addressed Rob's comments. Changed 'Strongly Ordered' to 'nGnRnE'
>
> Vidya Sagar (6):
> PCI: tegra: Fix ASPM-L1SS advertisement disable code
> PCI: tegra: Map configuration space as nGnRnE
> PCI: tegra: Set DesignWare IP version
> PCI: tegra: Continue unconfig sequence even if parts fail
> PCI: tegra: Check return value of tegra_pcie_init_controller()
> PCI: tegra: Disable LTSSM during L2 entry
>
> drivers/pci/controller/dwc/pcie-tegra194.c | 78 +++++++++++-----------
> 1 file changed, 39 insertions(+), 39 deletions(-)
I was going to test this series, but then I noticed that PCI is causing
a crash on linux-next (as of fairly recently). So I tried applying this
on top of v5.10-rc1, but that gives me the following:
[ 3.595161] ahci 0001:01:00.0: version 3.0
[ 3.595726] ahci 0001:01:00.0: SSS flag set, parallel bus scan disabled
[ 4.609923] ahci 0001:01:00.0: controller reset failed (0xffffffff)
[ 4.610343] ahci: probe of 0001:01:00.0 failed with error -5
So the device enumerates fine, but it's not able to reset the SATA
controller. That said, this seems to happen regardless of this patch
series, so plain v5.10-rc1 also shows the above.
Given the above, I think we should hold off on applying this series
until we've fixed PCI on linux-next and made sure that SATA also works
properly, otherwise we don't have a known good baseline to test this
against.
Thierry
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2020-11-25 17:57 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-09 17:19 [PATCH V4 0/6] Enhancements to Tegra194 PCIe driver Vidya Sagar
2020-11-09 17:19 ` [PATCH V4 1/6] PCI: tegra: Fix ASPM-L1SS advertisement disable code Vidya Sagar
2020-11-26 11:33 ` Thierry Reding
2020-12-03 12:36 ` Vidya Sagar
2020-11-09 17:19 ` [PATCH V4 2/6] PCI: tegra: Map configuration space as nGnRnE Vidya Sagar
2020-11-26 11:33 ` Thierry Reding
2020-12-03 12:56 ` Vidya Sagar
2020-11-09 17:19 ` [PATCH V4 3/6] PCI: tegra: Set DesignWare IP version Vidya Sagar
2020-11-26 11:34 ` Thierry Reding
2020-11-09 17:19 ` [PATCH V4 4/6] PCI: tegra: Continue unconfig sequence even if parts fail Vidya Sagar
2020-11-26 11:34 ` Thierry Reding
2020-11-30 12:10 ` Lorenzo Pieralisi
2020-12-01 14:24 ` Thierry Reding
2020-12-01 14:44 ` Lorenzo Pieralisi
2020-11-09 17:19 ` [PATCH V4 5/6] PCI: tegra: Check return value of tegra_pcie_init_controller() Vidya Sagar
2020-11-26 11:34 ` Thierry Reding
2020-11-09 17:19 ` [PATCH V4 6/6] PCI: tegra: Disable LTSSM during L2 entry Vidya Sagar
2020-11-26 11:34 ` Thierry Reding
2020-11-25 17:57 ` Thierry Reding [this message]
2020-11-25 19:51 ` [PATCH V4 0/6] Enhancements to Tegra194 PCIe driver Vidya Sagar
2020-11-26 11:31 ` Thierry Reding
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201125175709.GA1274379@ulmo \
--to=thierry.reding@gmail.com \
--cc=amanharitsh123@gmail.com \
--cc=bhelgaas@google.com \
--cc=dinghao.liu@zju.edu.cn \
--cc=jonathanh@nvidia.com \
--cc=kthota@nvidia.com \
--cc=kw@linux.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=lorenzo.pieralisi@arm.com \
--cc=mmaddireddy@nvidia.com \
--cc=robh+dt@kernel.org \
--cc=sagar.tv@gmail.com \
--cc=vidyas@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).