From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5DE33C77B7A for ; Tue, 6 Jun 2023 16:03:11 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237485AbjFFQDK (ORCPT ); Tue, 6 Jun 2023 12:03:10 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42326 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233062AbjFFQDJ (ORCPT ); Tue, 6 Jun 2023 12:03:09 -0400 Received: from metis.ext.pengutronix.de (metis.ext.pengutronix.de [IPv6:2001:67c:670:201:290:27ff:fe1d:cc33]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 632FEE4F for ; Tue, 6 Jun 2023 09:03:08 -0700 (PDT) Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1q6Z8u-0001e5-46; Tue, 06 Jun 2023 18:02:44 +0200 Received: from [2a0a:edc0:0:900:1d::77] (helo=ptz.office.stw.pengutronix.de) by drehscheibe.grey.stw.pengutronix.de with esmtp (Exim 4.94.2) (envelope-from ) id 1q6Z8l-005Xat-NX; Tue, 06 Jun 2023 18:02:35 +0200 Received: from ukl by ptz.office.stw.pengutronix.de with local (Exim 4.94.2) (envelope-from ) id 1q6Z8k-00BkQ7-PH; Tue, 06 Jun 2023 18:02:34 +0200 Date: Tue, 6 Jun 2023 18:02:34 +0200 From: Uwe =?utf-8?Q?Kleine-K=C3=B6nig?= To: Bjorn Helgaas Cc: Krzysztof =?utf-8?Q?Wilczy=C5=84ski?= , Miaoqian Lin , Vignesh Raghavendra , linux-pci@vger.kernel.org, Lorenzo Pieralisi , Matthias Brugger , Thierry Reding , Jisheng Zhang , Toan Le , Heiko Stuebner , Rob Herring , Florian Fainelli , linux-rockchip@lists.infradead.org, Joyce Ooi , Jonathan Hunter , Jianjun Wang , Sergio Paracuellos , Rahul Tanwar , Jim Quinlan , Broadcom internal kernel review list , linux-arm-msm@vger.kernel.org, Shawn Lin , Nicolas Saenz Julienne , linux-tegra@vger.kernel.org, kernel@pengutronix.de, Manivannan Sadhasivam , Ray Jui , Ryder Lee , linux-mediatek@lists.infradead.org, linux-rpi-kernel@lists.infradead.org, Bjorn Helgaas , linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org, AngeloGioacchino Del Regno , Scott Branden , Vidya Sagar , Serge Semin , Tom Joseph , Thomas Petazzoni , Shawn Guo , Pali =?utf-8?B?Um9ow6Fy?= Subject: Re: [PATCH 00/15] PCI: Convert to platform remove callback returning void Message-ID: <20230606160234.elcvyqlz2j3mggih@pengutronix.de> References: <20230530140742.ebbrxmpieuphbmz3@pengutronix.de> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="zxsm4y3nhwayyseu" Content-Disposition: inline In-Reply-To: X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: ukl@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-tegra@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-tegra@vger.kernel.org --zxsm4y3nhwayyseu Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hello, [dropped Tom Joseph and Joyce Ooi from Cc:, my last mail in this thread resulted in a bounce for their addresses.] On Fri, Jun 02, 2023 at 04:37:34PM -0500, Bjorn Helgaas wrote: > On Tue, May 30, 2023 at 04:07:42PM +0200, Uwe Kleine-K=F6nig wrote: > > Hello Bjorn, > >=20 > > On Tue, Mar 21, 2023 at 08:31:53PM +0100, Uwe Kleine-K=F6nig wrote: > > > this series adapts the platform drivers below drivers/pci to use the > > > .remove_new() callback. Compared to the traditional .remove() callback > > > .remove_new() returns no value. This is a good thing because the driv= er core > > > doesn't (and cannot) cope for errors during remove. The only effect o= f a > > > non-zero return value in .remove() is that the driver core emits a wa= rning. The > > > device is removed anyhow and an early return from .remove() usually y= ields a > > > resource leak. > > >=20 > > > By changing the remove callback to return void driver authors cannot > > > reasonably assume any more that there is some kind of cleanup later. > > >=20 > > > All drivers were easy to convert as they all returned zero in their > > > remove callback. Only for iproc the conversion wasn't trivial, the ot= her > > > were converted using coccinelle. > > >=20 > > > There are no interdependencies between these patches. So even if there > > > are some concerns for individual patches, I ask you to apply the > > > remaining set. Then I only have to care for the review feedback of the > > > refused patches. (Having said that I don't expect any serious objecti= on, > > > just things like squashing or separating patches, or maybe I picked a > > > wrong subject prefix.) > >=20 > > These patches wait for application for quite some time now. They apply > > just fine to v6.4-rc1 and next/master. Would be great to get them in > > during the next merge window and ideally give them some time in next > > before. >=20 > Thanks, these seem fine to me, and Lorenzo normally takes care of > drivers/pci/controller/. Lorenzo, if it's easier to have me apply > them, that's fine, too, just let me know. >=20 > The only tweaks I would make would be: >=20 > PCI: j721e: Convert to platform remove callback returning void > PCI: dwc: Convert to platform remove callback returning void If it's easier for you (or Lorenzo) I can resend with these tweaks. Otherwise if these are adapted when applying them, that's fine for me, too. Just tell me if I should do anything here. Best regards Uwe --=20 Pengutronix e.K. | Uwe Kleine-K=F6nig | Industrial Linux Solutions | https://www.pengutronix.de/ | --zxsm4y3nhwayyseu Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEP4GsaTp6HlmJrf7Tj4D7WH0S/k4FAmR/WJkACgkQj4D7WH0S /k6o4QgAswvhCfm74HQnoTwnC+IoMm4EP1uz/xxeEg2IRLGbrC34TS1Z84R+TfOq npW+Bvfva1xto9TqFtxPapMCURjsueSiw5mqKI4wkMiNqBPBmCoR1kzsPM4zY/v1 hI83Ar+x5UD94+L6lMpQKKl4diNnzFZPAJGX5576Pb/OsrYPBelBsiD2CPyas+ij CvVl7AhNVPfTIr8db3ngHUE+Dc47kiTXmrgk9PMd7v4gFWRMLmF0jcRLX5Ri0TbA G4d95IrdAHIC/okElC+mPjfp6Ilgzlhvaxupaw26oS0mEKSqG9ZOZh5E17boefVN cISjXwl3/zNxHdQUilLemtYFK/fyTQ== =aXLj -----END PGP SIGNATURE----- --zxsm4y3nhwayyseu--