From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: Saravana Kannan <saravanak@google.com>,
Stephen Boyd <sboyd@kernel.org>,
Dario Binacchi <dario.binacchi@amarulasolutions.com>,
Tony Lindgren <tony@atomide.com>,
linux-kernel@vger.kernel.org, linux-clk@vger.kernel.org,
linux-tegra@vger.kernel.org, linux-omap@vger.kernel.org,
"Rafael J. Wysocki" <rafael@kernel.org>,
Peter De Schrijver <pdeschrijver@nvidia.com>,
Prashant Gaikwad <pgaikwad@nvidia.com>,
Michael Turquette <mturquette@baylibre.com>,
Thierry Reding <thierry.reding@gmail.com>,
Jonathan Hunter <jonathanh@nvidia.com>,
Tero Kristo <kristo@kernel.org>,
Andy Shevchenko <andy@kernel.org>
Subject: Re: [PATCH v1 2/4] driver core: Replace kstrdup() + strreplace() with kstrdup_and_replace()
Date: Fri, 4 Aug 2023 16:10:01 +0200 [thread overview]
Message-ID: <2023080456-ride-unrobed-b738@gregkh> (raw)
In-Reply-To: <20230628153211.52988-3-andriy.shevchenko@linux.intel.com>
On Wed, Jun 28, 2023 at 06:32:09PM +0300, Andy Shevchenko wrote:
> Replace open coded functionalify of kstrdup_and_replace() with a call.
>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> ---
> drivers/base/core.c | 5 ++---
> 1 file changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/base/core.c b/drivers/base/core.c
> index 3dff5037943e..af0ee691520a 100644
> --- a/drivers/base/core.c
> +++ b/drivers/base/core.c
> @@ -17,7 +17,6 @@
> #include <linux/kstrtox.h>
> #include <linux/module.h>
> #include <linux/slab.h>
> -#include <linux/string.h>
> #include <linux/kdev_t.h>
> #include <linux/notifier.h>
> #include <linux/of.h>
> @@ -28,6 +27,7 @@
> #include <linux/netdevice.h>
> #include <linux/sched/signal.h>
> #include <linux/sched/mm.h>
> +#include <linux/string_helpers.h>
> #include <linux/swiotlb.h>
> #include <linux/sysfs.h>
> #include <linux/dma-map-ops.h> /* for dma_default_coherent */
> @@ -3910,10 +3910,9 @@ const char *device_get_devnode(const struct device *dev,
> return dev_name(dev);
>
> /* replace '!' in the name with '/' */
> - s = kstrdup(dev_name(dev), GFP_KERNEL);
> + s = kstrdup_and_replace(dev_name(dev), '!', '/', GFP_KERNEL);
> if (!s)
> return NULL;
> - strreplace(s, '!', '/');
> return *tmp = s;
> }
>
> --
> 2.40.0.1.gaa8946217a0b
>
Acked-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
next prev parent reply other threads:[~2023-08-04 14:10 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-28 15:32 [PATCH v1 0/4] clk: Add kstrdup_and_replace() helper and use it Andy Shevchenko
2023-06-28 15:32 ` [PATCH v1 1/4] lib/string_helpers: Add kstrdup_and_replace() helper Andy Shevchenko
2023-06-28 15:32 ` [PATCH v1 2/4] driver core: Replace kstrdup() + strreplace() with kstrdup_and_replace() Andy Shevchenko
2023-08-04 14:10 ` Greg Kroah-Hartman [this message]
2023-08-04 14:30 ` Andy Shevchenko
2023-08-04 14:46 ` Andy Shevchenko
2023-06-28 15:32 ` [PATCH v1 3/4] clk: tegra: " Andy Shevchenko
2023-06-28 15:32 ` [PATCH v1 4/4] clk: ti: " Andy Shevchenko
[not found] ` <ad13bab23313ca4bdfd405528a76ac37.sboyd@kernel.org>
2023-07-20 8:32 ` [PATCH v1 0/4] clk: Add kstrdup_and_replace() helper and use it Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2023080456-ride-unrobed-b738@gregkh \
--to=gregkh@linuxfoundation.org \
--cc=andriy.shevchenko@linux.intel.com \
--cc=andy@kernel.org \
--cc=dario.binacchi@amarulasolutions.com \
--cc=jonathanh@nvidia.com \
--cc=kristo@kernel.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=mturquette@baylibre.com \
--cc=pdeschrijver@nvidia.com \
--cc=pgaikwad@nvidia.com \
--cc=rafael@kernel.org \
--cc=saravanak@google.com \
--cc=sboyd@kernel.org \
--cc=thierry.reding@gmail.com \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).