From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 651D4C6FD1F for ; Tue, 14 Mar 2023 19:51:59 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229513AbjCNTv6 (ORCPT ); Tue, 14 Mar 2023 15:51:58 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47268 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230205AbjCNTvw (ORCPT ); Tue, 14 Mar 2023 15:51:52 -0400 Received: from mail-ed1-x532.google.com (mail-ed1-x532.google.com [IPv6:2a00:1450:4864:20::532]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 81727233E0; Tue, 14 Mar 2023 12:51:51 -0700 (PDT) Received: by mail-ed1-x532.google.com with SMTP id o12so66704036edb.9; Tue, 14 Mar 2023 12:51:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; t=1678823510; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=8AT8USwG5WyHMLzA6/8T0IUfb3m04Mgmj2Z9mkS5Q9k=; b=VQ1Bxxrd0PI+Y36KGSR9tvLfCRNckswniNWELVaaPvUCxWivB6ajZpVwNfQPWx/bxk wlyb+IDMNnHUcblddMhuEzgUKSHLuI4IYjI16P82uxBFfu+92mr4ylyALdg2BFJvB0AO onmyGCP+1rgPgi7D6BPokZjuqWgag+074+OsP3gh5V8/s6Ajcuo0Ix20CPS0vWa6y38n CxUj1yc60ELISGN+7y9S+Iv2DRIOmu8bGsTq9Aeo9AEahw49g7yGwjhT0f4XFogDgefs /N/wuVy/EJ9AiQTL6+rT/SW6ZaLlic2kpZM0aIBubfPL2LM3uwH4k5DAmUCIPj+m+x3r sfcA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1678823510; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=8AT8USwG5WyHMLzA6/8T0IUfb3m04Mgmj2Z9mkS5Q9k=; b=oJNQBJDzWpTzt/Xz5j60S+1tcI4xKoBLJiFBvILS6BOSi2T9Lp9j+L43LTGBJuPOlx d0ieBRKW3FRVhraVnz7AQlzvTyz0Xh1gl5O0eOROtoFP2kyAvm4H+gXdnVD7NXykIjgW ac/jX+7kpQzKyV22ALUAuYAdIQjfxxjxh+rkLj3O7hx3Pb+rrDjeUzrYCPKQDc44oTS5 zU5ZgO5UFw7hOFMt3vRnNebushmblQj1spP6X/f4/6UyXiRIhFOCxajjerUkLprQD4+a lO1TJu2gbucSvbt9adFvVS1LHE1zbzPWBzZqxrvrKeCxoeANw0mfnXJTIcEgXRnoaoCJ Rs9Q== X-Gm-Message-State: AO0yUKV4AVbHo1QFWf5wTIUAdq0VeDaxTD1mC+X9kjGHQvqUaFxVfPp6 s8cgHKlQ3PnNosVZXscH2kM= X-Google-Smtp-Source: AK7set/tzuvE7xTzdstMMoDin2Jn1A93J29XnBrFLWGatjpCIuLb3twRybszlAVT52/X8b7+AM6KfA== X-Received: by 2002:a17:906:a249:b0:92b:b4d9:3f07 with SMTP id bi9-20020a170906a24900b0092bb4d93f07mr3722129ejb.14.1678823509909; Tue, 14 Mar 2023 12:51:49 -0700 (PDT) Received: from jernej-laptop.localnet (82-149-1-233.dynamic.telemach.net. [82.149.1.233]) by smtp.gmail.com with ESMTPSA id z4-20020a170906714400b008e53874f8d8sm1509261ejj.180.2023.03.14.12.51.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 14 Mar 2023 12:51:49 -0700 (PDT) From: Jernej =?utf-8?B?xaBrcmFiZWM=?= To: Joe Tessler , Hans Verkuil , Mauro Carvalho Chehab , Neil Armstrong , Kevin Hilman , Jerome Brunet , Martin Blumenstingl , Thierry Reding , Jonathan Hunter , Manivannan Sadhasivam , Michael Tretter , Pengutronix Kernel Team , Jacopo Mondi , Kieran Bingham , Laurent Pinchart , Niklas =?ISO-8859-1?Q?S=F6derlund?= , Rui Miguel Silva , Wenyou Yang , Bin Liu , Matthias Brugger , AngeloGioacchino Del Regno , Minghsiu Tsai , Houlong Wei , Andrew-CT Chen , Andrzej Pietrasiewicz , Jacek Anaszewski , Sylwester Nawrocki , Patrice Chotard , Yong Deng , Paul Kocialkowski , Chen-Yu Tsai , Samuel Holland , "Lad, Prabhakar" , Ezequiel Garcia , Philipp Zabel , Sean Young , linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, linux-amlogic@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-tegra@vger.kernel.org, linux-mediatek@lists.infradead.org, linux-sunxi@lists.linux.dev, linux-rockchip@lists.infradead.org, Krzysztof Kozlowski Cc: Krzysztof Kozlowski Subject: Re: [PATCH 16/28] media: platform: sun6i-csi: drop of_match_ptr for ID table Date: Tue, 14 Mar 2023 20:51:46 +0100 Message-ID: <2671303.mvXUDI8C0e@jernej-laptop> In-Reply-To: <20230312131318.351173-16-krzysztof.kozlowski@linaro.org> References: <20230312131318.351173-1-krzysztof.kozlowski@linaro.org> <20230312131318.351173-16-krzysztof.kozlowski@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-tegra@vger.kernel.org Dne nedelja, 12. marec 2023 ob 14:13:06 CET je Krzysztof Kozlowski napisal(= a): > The driver can match only via the DT table so the table should be always > used and the of_match_ptr does not have any sense (this also allows ACPI > matching via PRP0001, even though it might not be relevant here). This > also fixes !CONFIG_OF error: >=20 > drivers/media/platform/sunxi/sun6i-csi/sun6i_csi.c:401:34: error: > =E2=80=98sun6i_csi_of_match=E2=80=99 defined but not used [-Werror=3Dunus= ed-const-variable=3D] >=20 > Signed-off-by: Krzysztof Kozlowski > --- Acked-by: Jernej Skrabec Best regards, Jernej > drivers/media/platform/sunxi/sun6i-csi/sun6i_csi.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) >=20 > diff --git a/drivers/media/platform/sunxi/sun6i-csi/sun6i_csi.c > b/drivers/media/platform/sunxi/sun6i-csi/sun6i_csi.c index > e3e6650181c8..187a2419da96 100644 > --- a/drivers/media/platform/sunxi/sun6i-csi/sun6i_csi.c > +++ b/drivers/media/platform/sunxi/sun6i-csi/sun6i_csi.c > @@ -429,7 +429,7 @@ static struct platform_driver sun6i_csi_platform_driv= er > =3D { .remove =3D sun6i_csi_remove, > .driver =3D { > .name =3D SUN6I_CSI_NAME, > - .of_match_table =3D=20 of_match_ptr(sun6i_csi_of_match), > + .of_match_table =3D sun6i_csi_of_match, > .pm =3D &sun6i_csi_pm_ops, > }, > };