From: Daniel Lezcano <daniel.lezcano@linaro.org>
To: Thierry Reding <thierry.reding@gmail.com>,
Mikko Perttunen <mperttunen@nvidia.com>
Cc: rafael@kernel.org, viresh.kumar@linaro.org, jonathanh@nvidia.com,
krzysztof.kozlowski@canonical.com, lorenzo.pieralisi@arm.com,
robh@kernel.org, kw@linux.com, p.zabel@pengutronix.de,
rui.zhang@intel.com, amitk@kernel.org, linux-pm@vger.kernel.org,
linux-tegra@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-pci@vger.kernel.org
Subject: Re: [PATCH 1/5] thermal: tegra-bpmp: Handle errors in BPMP response
Date: Fri, 25 Feb 2022 13:22:37 +0100 [thread overview]
Message-ID: <3a1bd8c0-2522-2f4a-2505-e3a3edfb290c@linaro.org> (raw)
In-Reply-To: <YV86cX/omlQa3kpq@orome.fritz.box>
On 07/10/2021 20:20, Thierry Reding wrote:
> On Wed, Sep 15, 2021 at 11:55:13AM +0300, Mikko Perttunen wrote:
>> The return value from tegra_bpmp_transfer indicates the success or
>> failure of the IPC transaction with BPMP. If the transaction
>> succeeded, we also need to check the actual command's result code.
>> Add code to do this.
>>
>> Signed-off-by: Mikko Perttunen <mperttunen@nvidia.com>
>> ---
>> drivers/thermal/tegra/tegra-bpmp-thermal.c | 13 ++++++++++++-
>> 1 file changed, 12 insertions(+), 1 deletion(-)
>
> Perhaps this should be moved into tegra_bpmp_transfer() or some new
> helper to make sure we can keep this consistent across all callers.
>
> For instance, I'm not sure -EINVAL is the right (or best) error code in
> all the cases. Either way, seems fine in this case and this is certainly
> an improvement, so:
>
> Acked-by: Thierry Reding <treding@nvidia.com>
Applied, thanks
--
<http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs
Follow Linaro: <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog
prev parent reply other threads:[~2022-02-25 12:22 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-15 8:55 [PATCH 1/5] thermal: tegra-bpmp: Handle errors in BPMP response Mikko Perttunen
2021-09-15 8:55 ` [PATCH 2/5] reset: " Mikko Perttunen
2021-10-05 9:55 ` Philipp Zabel
2021-10-28 11:54 ` Jon Hunter
2021-11-02 13:10 ` Philipp Zabel
2021-11-12 11:30 ` Jon Hunter
2021-09-15 8:55 ` [PATCH 3/5] memory: tegra186-emc: " Mikko Perttunen
2021-09-20 8:34 ` (subset) " Krzysztof Kozlowski
2021-09-15 8:55 ` [PATCH 4/5] cpufreq: tegra186/tegra194: " Mikko Perttunen
2021-10-04 6:37 ` Viresh Kumar
2021-10-04 6:51 ` Mikko Perttunen
2021-10-04 7:01 ` Viresh Kumar
2021-10-04 7:02 ` Mikko Perttunen
2021-09-15 8:55 ` [PATCH 5/5] PCI: tegra194: " Mikko Perttunen
2021-10-07 18:21 ` Thierry Reding
2021-10-13 12:59 ` Lorenzo Pieralisi
2021-11-29 12:19 ` Lorenzo Pieralisi
2022-02-03 12:22 ` Lorenzo Pieralisi
2021-10-07 18:20 ` [PATCH 1/5] thermal: tegra-bpmp: " Thierry Reding
2022-02-25 12:22 ` Daniel Lezcano [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3a1bd8c0-2522-2f4a-2505-e3a3edfb290c@linaro.org \
--to=daniel.lezcano@linaro.org \
--cc=amitk@kernel.org \
--cc=jonathanh@nvidia.com \
--cc=krzysztof.kozlowski@canonical.com \
--cc=kw@linux.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=lorenzo.pieralisi@arm.com \
--cc=mperttunen@nvidia.com \
--cc=p.zabel@pengutronix.de \
--cc=rafael@kernel.org \
--cc=robh@kernel.org \
--cc=rui.zhang@intel.com \
--cc=thierry.reding@gmail.com \
--cc=viresh.kumar@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).