From: Mikko Perttunen <cyndis@kapsi.fi>
To: Nathan Chancellor <nathan@kernel.org>, Arnd Bergmann <arnd@kernel.org>
Cc: Thierry Reding <thierry.reding@gmail.com>,
David Airlie <airlied@gmail.com>, Daniel Vetter <daniel@ffwll.ch>,
Arnd Bergmann <arnd@arndb.de>,
Nick Desaulniers <ndesaulniers@google.com>,
Tom Rix <trix@redhat.com>,
Mikko Perttunen <mperttunen@nvidia.com>,
Christophe JAILLET <christophe.jaillet@wanadoo.fr>,
Robin Murphy <robin.murphy@arm.com>,
dri-devel@lists.freedesktop.org, linux-tegra@vger.kernel.org,
linux-kernel@vger.kernel.org, llvm@lists.linux.dev
Subject: Re: [PATCH] gpu: host1x: fix uninitialized variable use
Date: Sat, 28 Jan 2023 10:12:15 +0200 [thread overview]
Message-ID: <46a462ec-bc80-cbb7-4833-d9c430f4e9c3@kapsi.fi> (raw)
In-Reply-To: <Y9RbvPRP5Yw/fUMM@dev-arch.thelio-3990X>
On 1/28/23 01:18, Nathan Chancellor wrote:
> On Fri, Jan 27, 2023 at 11:14:00PM +0100, Arnd Bergmann wrote:
>> From: Arnd Bergmann <arnd@arndb.de>
>>
>> The error handling for platform_get_irq() failing no longer
>> works after a recent change, clang now points this out with
>> a warning:
>>
>> drivers/gpu/host1x/dev.c:520:6: error: variable 'syncpt_irq' is uninitialized when used here [-Werror,-Wuninitialized]
>> if (syncpt_irq < 0)
>> ^~~~~~~~~~
>>
>> Fix this by removing the variable and checking the correct
>> error status.
>>
>> Fixes: 625d4ffb438c ("gpu: host1x: Rewrite syncpoint interrupt handling")
>> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
>
> I had the same diff pending but civic duty called today :)
>
> Reviewed-by: Nathan Chancellor <nathan@kernel.org>
>
>> ---
>> drivers/gpu/host1x/dev.c | 5 ++---
>> 1 file changed, 2 insertions(+), 3 deletions(-)
>>
>> diff --git a/drivers/gpu/host1x/dev.c b/drivers/gpu/host1x/dev.c
>> index 4872d183d860..aae2efeef503 100644
>> --- a/drivers/gpu/host1x/dev.c
>> +++ b/drivers/gpu/host1x/dev.c
>> @@ -487,7 +487,6 @@ static int host1x_get_resets(struct host1x *host)
>> static int host1x_probe(struct platform_device *pdev)
>> {
>> struct host1x *host;
>> - int syncpt_irq;
>> int err;
>>
>> host = devm_kzalloc(&pdev->dev, sizeof(*host), GFP_KERNEL);
>> @@ -517,8 +516,8 @@ static int host1x_probe(struct platform_device *pdev)
>> }
>>
>> host->syncpt_irq = platform_get_irq(pdev, 0);
>> - if (syncpt_irq < 0)
>> - return syncpt_irq;
>> + if (host->syncpt_irq < 0)
>> + return host->syncpt_irq;
>>
>> mutex_init(&host->devices_lock);
>> INIT_LIST_HEAD(&host->devices);
>> --
>> 2.39.0
>>
Thanks both for the fix :)
FWIW,
Reviewed-by: Mikko Perttunen <mperttunen@nvidia.com>
next prev parent reply other threads:[~2023-01-28 8:12 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-27 22:14 [PATCH] gpu: host1x: fix uninitialized variable use Arnd Bergmann
2023-01-27 23:18 ` Nathan Chancellor
2023-01-28 8:12 ` Mikko Perttunen [this message]
2023-02-01 23:19 ` Nick Desaulniers
2023-02-23 16:28 ` Nathan Chancellor
2023-03-08 16:56 ` Nathan Chancellor
2023-03-08 17:28 ` Jon Hunter
2023-03-24 9:46 ` Daniel Vetter
2023-03-24 9:59 ` Daniel Vetter
2023-03-24 10:38 ` Thierry Reding
2023-03-24 10:50 ` Daniel Vetter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=46a462ec-bc80-cbb7-4833-d9c430f4e9c3@kapsi.fi \
--to=cyndis@kapsi.fi \
--cc=airlied@gmail.com \
--cc=arnd@arndb.de \
--cc=arnd@kernel.org \
--cc=christophe.jaillet@wanadoo.fr \
--cc=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=llvm@lists.linux.dev \
--cc=mperttunen@nvidia.com \
--cc=nathan@kernel.org \
--cc=ndesaulniers@google.com \
--cc=robin.murphy@arm.com \
--cc=thierry.reding@gmail.com \
--cc=trix@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).