Re: [PATCH v3 0/3] Support NVIDIA Tegra-based Ouya game console

From: Bob Ham <rah@settrans.net>
To: Stefan Agner <stefan@agner.ch>, Peter Geis <pgwipeout@gmail.com>
Cc: Rob Herring <robh+dt@kernel.org>,
	Thierry Reding <thierry.reding@gmail.com>,
	Jonathan Hunter <jonathanh@nvidia.com>,
	Matt Merhar <mattmerhar@protonmail.com>,
	Dmitry Osipenko <digetx@gmail.com>,
	Stephen Warren <swarren@wwwdotorg.org>,
	Leonardo Bras <leobras.c@gmail.com>,
	Michael Brougham <jusplainmike@gmail.com>,
	linux-tegra@vger.kernel.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org, Lukas Rusak <lorusak@gmail.com>
Subject: Re: [PATCH v3 0/3] Support NVIDIA Tegra-based Ouya game console
Date: Wed, 7 Oct 2020 14:36:26 +0100	[thread overview]
Message-ID: <4d3eb998-045b-f288-7a9c-aaa620c38bff@settrans.net> (raw)
In-Reply-To: <cdd0f520ae4990de90f461e21cb4f298@agner.ch>

Hi all,

The Bluetooth controller driver sent to linux-input by Lukas Rusak
(CC'd) is a bit of a concern.  Here is the original driver:

https://github.com/ouya/ouya_1_1-kernel/blob/master/drivers/hid/hid-ouya.c

and you can see that there is no SPDX header, no license information and
no MODULE_LICENSE declaration.  I'd previously noticed this as a
possible cause for concern in upstreaming the driver.

Meanwhile, Lukas's driver is clearly derived from the Ouya Inc. driver
and even retains the Ouya Inc. copyright notice line.  However, Lukas's
driver now has a MODULE_LICENSE("GPL") declaration added.

Lukas, did you get clear permission to license the driver as GPL?

Alternatively, kernel developers with greater legal or Ouya knowledge,
is this actually a concern or is it nothing to worry about?

Thanks,

Bob

On 07/10/2020 08:22, Stefan Agner wrote:
> Hi Peter,
> 
> On 2020-10-04 15:31, Peter Geis wrote:
>> Good Day,
>>
>> This series introduces upstream kernel support for the Ouya game
>> console device. Please review and apply. Thank you in advance.
> 
> Interesting patchset, maybe I can give my Ouya a second live now :-) Do
> you happen to have (a link) to instructions how to flash the device?
> 
> Btw, there was also a driver for the Bluetooth controller on the ML
> once, maybe a good time to revive that:
> https://spinics.net/lists/linux-input/msg56288.html
> 
> --
> Stefan
> 
>>
>> Changelog:
>> v3: - Reorder aliases per Dmitry Osipenko's review.
>>     - Add sdio clocks per Dmitry Osipenko's review.
>>     - Add missing ti sleep bits per Dmitry Osipenko's review.
>>     - Enable lp1 sleep mode.
>>     - Fix bluetooth comment and add missing power supplies.
>>
>> v2: - Update pmic and clock handles per Rob Herring's review.
>>     - Add acks from Rob Herring to patch 2 and 3.
>>
>> Peter Geis (3):
>>   ARM: tegra: Add device-tree for Ouya
>>   dt-bindings: Add vendor prefix for Ouya Inc.
>>   dt-bindings: ARM: tegra: Add Ouya game console
>>
>>  .../devicetree/bindings/arm/tegra.yaml        |    3 +
>>  .../devicetree/bindings/vendor-prefixes.yaml  |    2 +
>>  arch/arm/boot/dts/Makefile                    |    3 +-
>>  arch/arm/boot/dts/tegra30-ouya.dts            | 4511 +++++++++++++++++
>>  4 files changed, 4518 insertions(+), 1 deletion(-)
>>  create mode 100644 arch/arm/boot/dts/tegra30-ouya.dts
> 