From: Philipp Zabel <p.zabel-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
To: Rajesh Gumasta <rgumasta-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>,
ldewangan-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org,
jonathanh-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org,
vkoul-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org,
dan.j.williams-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org,
thierry.reding-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org,
dmaengine-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Cc: kyarlagadda-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org,
Pavan Kunapuli
<pkunapuli-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
Subject: Re: [Patch v1 2/4] dma: tegra: Adding Tegra GPC DMA controller driver
Date: Mon, 20 Jul 2020 11:37:51 +0200 [thread overview]
Message-ID: <636380f452ff696ab4505ad09dcea951283be06b.camel@pengutronix.de> (raw)
In-Reply-To: <1595226856-19241-3-git-send-email-rgumasta-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
Hi Rajesh,
On Mon, 2020-07-20 at 12:04 +0530, Rajesh Gumasta wrote:
> +
> + tdma->rst = devm_reset_control_get(&pdev->dev, "gpcdma");
Please use devm_reset_control_get_exclusive() directly.
> + if (IS_ERR(tdma->rst)) {
> + dev_err(&pdev->dev, "Missing controller reset\n");
You might want to suppress this message if the error is EPROBE_DEFER.
> + return PTR_ERR(tdma->rst);
> + }
> + reset_control_reset(tdma->rst);
regards
Philipp
next prev parent reply other threads:[~2020-07-20 9:37 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-20 6:34 [Patch v1 0/4] Add Nvidia Tegra GPC-DMA driver Rajesh Gumasta
2020-07-20 6:34 ` [Patch v1 1/4] dt-bindings: dma: Add DT binding document Rajesh Gumasta
2020-07-20 6:34 ` [Patch v1 2/4] dma: tegra: Adding Tegra GPC DMA controller driver Rajesh Gumasta
[not found] ` <1595226856-19241-3-git-send-email-rgumasta-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2020-07-20 9:37 ` Philipp Zabel [this message]
2020-07-20 11:58 ` kernel test robot
2020-07-20 15:12 ` Dmitry Osipenko
2020-07-20 15:42 ` Randy Dunlap
2020-07-27 9:07 ` Vinod Koul
[not found] ` <1595226856-19241-1-git-send-email-rgumasta-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2020-07-20 6:34 ` [Patch v1 3/4] arm64: configs: enable tegra gpc dma Rajesh Gumasta
2020-07-20 6:34 ` [Patch v1 4/4] arm64: tegra: Add GPCDMA node in dt Rajesh Gumasta
2020-07-20 9:25 ` [Patch v1 0/4] Add Nvidia Tegra GPC-DMA driver Thierry Reding
2020-07-20 10:00 ` Rajesh Gumasta
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=636380f452ff696ab4505ad09dcea951283be06b.camel@pengutronix.de \
--to=p.zabel-bicnvbalz9megne8c9+irq@public.gmane.org \
--cc=dan.j.williams-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org \
--cc=dmaengine-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=jonathanh-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org \
--cc=kyarlagadda-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org \
--cc=ldewangan-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=pkunapuli-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org \
--cc=rgumasta-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org \
--cc=thierry.reding-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
--cc=vkoul-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).